Map/object/event renaming about pokecrystal HOT 5 OPEN

Followup to #655.

from pokecrystal.

@mid-kid
#639 (comment)

wMapObjects is still left over from when we renamed "map object"s to "object event"s. I vaguely recall having talked about this issue before, and decided there wasn't a good solution, but I don't remember why.
Anyway, anything called MapObject should probably be renamed to ObjectEvent, unless someone reminds me of a reason not to.

The label ObjectEvent is currently already used here:

ObjectEvent::
	jumptextfaceplayer ObjectEventText

ObjectEventText::
	text_far _ObjectEventText
	text_end

And by many of the object_event macros:

object_event  7,  3, SPRITE_RAIKOU, SPRITEMOVEDATA_POKEMON, 0, 0, -1, -1, PAL_NPC_BROWN, OBJECTTYPE_SCRIPT, 0, ObjectEvent, EVENT_BURNED_TOWER_B1F_BEASTS_1

This ObjectEvent should ideally be renamed to ObjectEventScript, although It could be a annoying-ish disruptive change.

What are your thoughts Pfero?

from pokecrystal.

wMapObjects is the array where these object_event structs are copied into, the name isn't conflicting from what I remember.

from pokecrystal.

I was referring to renaming it to ObjectEvent... But... I just realized I was probably overthinking it... As I forgot the wram addresses start with w. 😂 So it would be something like wObjectEvent. Thus no conflict.

from pokecrystal.

I updated my label recommendations in the original post.

from pokecrystal.