pokeapi / pokekotlin Goto Github PK

Requesting /pokemon/129/ or /pokemon-species/129/ times out because it's a very slow call. Caused by https://github.com/phalt/pokeapi/issues/178.

I am getting a JSONDataException from com.squareup.moshi were it expects a string but it is getting a BEGIN_OBJECT.

The code I am using to make the call is as follows:

Call<Pokemon> pokemonCall = PokeApi.INSTANCE.getPokemon(nationalDexNumber);
pokemonCall.enqueue(new Callback<Pokemon>() {
    @Override
    public void onResponse(Call<Pokemon> call, retrofit2.Response<Pokemon> response) {
        Pokemon pokemon = response.body();
        for (LocationAreaEncounter encounter : pokemon.getLocation_area_encounters()) {
            ApiResource<LocationArea> areaApiResource = encounter.getLocation_area();
            areaEncounterList.add(areaApiResource.getUrl());
        }
    }

    @Override
    public void onFailure(Call<Pokemon> call, Throwable t) {
        Log.e(String.format("PokeApi.getPokemon(%d)", nationalDexNumber), "Failed to get Pokémon", t);
    }
});

Relevant Data

• Test Device: Samsung Galaxy S6+
• Editor: Android Studio 2.1
• minSdkVersion: 15
• targetSdkVersion: 23

Much of the client code is repetitive, and could probably make use of code generation. Maybe a custom Kobalt task could help here?

EDIT 2016/06/24: There's a new Kapt coming with Kotlin 1.0.4. Looks like Kobalt may support this better than the current Kapt, so this should be put on hold until then. Once that's out, we can use annotation processing instead of a custom Kobalt task to implement the code generation.

Hi,

Im trying to integrate PokeKotlin into my android project which using build.gradle.kts file for adding dependencies, The readMe file and the release section are showing different ways to integrate the Library, as per my understanding it is no longer hosted in bintray so tried to integrate using this dependency : implementation("me.sargunvohra.lib:pokekotlin:2.4.0"), but im facing the following error : "Failed to resolve: me.sargunvohra.lib:pokekotlin:2.4.0"

Is this repository still being maintained?

Show Async call and error handling

I get a ClassNotFoundException in the following line " PokeApi pokeApi = new PokeApiClient();".

• Ability
• Characteristic
• Egg group
• Gender
• Growth rate
• Nature
• Pokeathlon stat
• Pokemon
• Pokemon color
• Pokemon form
• Pokemon habitat
• Pokemon shape
• Pokemon species
• Stat
• Type

• Move
• Move ailment
• Move battle style
• Move category
• Move damage class
• Move learn method
• Move target

• Item
• Item attribute
• Item category
• Item fling effect
• Item pocket

Code like this is very common:

client.getMoveList(offset = 0, limit = service.getMoveList(0, 0).count)

There should be a convenience function for each resource list that takes no parameters and returns the full list via the above.

fun getMoveList() = getMoveList(0, getMoveList(0, 0).count)

Dear Developers,

I am facing a usability problem when using pokekotlin.
This is my situation:
I am writing a Java application and want to cache all abilities. My first intention was to call getAbility() until I get no more abilities:

        boolean continueLoop = true;
        for (int i = 1; continueLoop; i++) {
            Ability ability = pokeApi.getAbility(i);
            if (ability == null) {
                continueLoop = false;
            }
            else {
                //do somthing
            }
        }

However as soon as i reaches a value PokeAPI returns a 404 for, my application exits with this exception:

Exception in thread "main" me.sargunvohra.lib.pokekotlin.client.ErrorResponse: (404) Not Found
at me.sargunvohra.lib.pokekotlin.client.PokeApiClient.result(PokeApiClient.kt:13)
at me.sargunvohra.lib.pokekotlin.client.PokeApiClient.getAbility(PokeApiClient.kt:251)

I tried to catch the exception. This didn't work.
My next thought was to use the method getAbilityList(). This is working for me, but to get the actual Ability object I have to extract the id from the NamedApiResource and then do the getAbility() call with this id. This approach works but, I assume, PokeAPI is called twice for every ability. I would prefer not doing so.

I don't know nothing about kotlin and thus can't tell if this behaviour is intended or not. Also I have no idea how to prevent my application from exiting.

Wouldn't it be possible to just return null in case a HTTP call returns no result/404 error?

Regards
Adrian

P.S.: Nevertheless you are doing a great job. Kudos to you!

Edit the TestNG config to make the tests run in parallel.

Location area encounters have been left out of the bulk test since they were changed to be a subresource. It should be added as a new test inside the bulk test class.

This library should have a more detailed documentation and some examples.

EDIT: Should do this after 2.0.0

Kotlin 1.1 is coming soon, which will include data class inheritance. The resource models can probably be reworked with this new feature, which will cause some minor breaking changes in edge cases.

Since there will be another major version bump for this, it's probably also a good time to see if there's any more breaking refactoring that should be done (although most of that was taken care of with 2.0.0).

Should see if NamedApiResource and ApiResource can get a generic parameter for the type of resource it's pointing to. Also should make NamedApiResource extend from ApiResource. Should also add a base class for all API objects since they all include an id and name.

Update resource list methods to use pagination when https://github.com/phalt/pokeapi/issues/94 is fixed.

• Location
• Location area
• Pal park area
• Region

The test in web give me:

Caused by: me.sargunvohra.lib.pokekotlin.client.ErrorResponse: (503)

What's the problem?

Thanks.

Looks like this field is missing.

Should add these when the latest version of PokeApi is live:

• PokeAPI/pokeapi#211
• PokeAPI/pokeapi#213

It would be nice to add RxJava support to the Retrofit interface via RxJava Call Adapter

I would also enjoy working on this feature.

How to get different groups of stats of one pokeomon with different forms just like Rotom or Aegislash?

Bintray is being deprecated in a couple months: https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/

We need to publish to a different repository. Does Github Packages support public packages yet? If so that's probably the best place for this. If not, we'll have to find another repository, or fix the jitpack build.

• Language

Hi, I'm trying to use the models with a Jackson/Jaxrs client, but get errors since the id and category fields on ApiResource and NamedApiResource don't actually exist on the incoming JSON.

I could implement something similar to your ApiResourceAdapter, but for Jackson, but I thought default, lazy values on the classes would make more sense so they can be used as-is more widely. Ideally, this would also let us be able to remove the custom adapters in this repo, but it looks like Gson has issues with default values on kotlin classes.

• Generation
• Pokedex
• Version
• Version Group

PokeApi.getMoveAilment(-1) throws an error. This is due to https://github.com/phalt/pokeapi/issues/145.

Add dependencies pom.xml of my project:

Failed to collect dependencies for ... Could not transfer artifact ... from/to central ... Failed to transfer file ... Return code is: 501 , ReasonPhrase:HTTPS Required. -> [Help 1]

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>com.mycompany</groupId>
    <artifactId>PokemonProject</artifactId>
    <version>1.0-SNAPSHOT</version>
    <packaging>jar</packaging>
    <properties>
        <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
        <maven.compiler.source>1.8</maven.compiler.source>
        <maven.compiler.target>1.8</maven.compiler.target>
    </properties>
    <repositories>
	<repository>
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
	</repository>
    </repositories>
    <dependencies>
        <dependency>
            <groupId>com.github.PokeAPI</groupId>
            <artifactId>pokekotlin</artifactId>
            <version>2.3.1</version>
            <type>jar</type>
        </dependency>
    </dependencies>
</project>

When trying to run my project I get the error of:

Failed to execute goal on project PokemonProject: Could not resolve dependencies for project com.mycompany:PokemonProject:jar:1.0-SNAPSHOT: Failed to collect dependencies for [com.github.PokeAPI:pokekotlin:jar:2.3.1 (compile)]: Failed to read artifact descriptor for com.squareup.retrofit2:retrofit:jar:2.8.1: Could not transfer artifact com.squareup.retrofit2:retrofit:pom:2.8.1 from/to central (http://repo.maven.apache.org/maven2): Failed to transfer file: http://repo.maven.apache.org/maven2/com/squareup/retrofit2/retrofit/2.8.1/retrofit-2.8.1.pom. Return code is: 501 , ReasonPhrase:HTTPS Required. -> [Help 1]

The negative ID bug has been fixed, so the workaround in this project should be removed.

• Evolution chains (all scenarios)
• Evolution triggers

Move seems to be missing a way to retrieve its flavor text entries.

When trying to use the classes defined in the example case of the project:

PokeApi pokeApi = new PokeApiClient();

neither PokeApi nor PokeApiClient are being recognized as known classes

Add a test that polls http://pokeapi.co/api/v2/ and checks that each resource has the appropriate methods in the client.

Are there plans to add auto-caching to this wrapper? I am looking at using this and would like to cache the results, but preferably not have my own wrappers that cache the results. I'd look into doing this myself, but I am not familiar with Kotlin.

Hello!

I've been wanting to create a VGC companion app for quite a while and was thinking of doing so now.

I imported your API and tried your example code, but it instantly crashes with a network error.

Is there a fix for this? Because i can't find any.

PS: this happened on android studio.

• Use a local instance of PokeAPI to generate a copy of every JSON, and put it in src/test/resources
• Make the current tests call a mock client that actually hits the local files instead of the live PokeAPI
• Enable the BulkTest which is disabled now because it's a heavy test
• Add one or two basic tests that still hit the real PokeAPI.

This will greatly speed up the tests. However, we should be sure to regenerate the local copy of the data periodically to ensure the tests remain relevant. Maybe automate this by setting up a server that pulls everything from PokeAPI once a week or so and creates a PR here automatically?

http://stackoverflow.com/questions/31882306/how-to-configure-travis-ci-to-build-pull-requests-merges-to-master-w-o-redunda

Hi there! I'm trying to integrate this tool into my eclipse workspace but i cant find any guide and cant figure it out myself. I've copied all the files into a new Kotlin project and created a new Java class to run the test code provided in the readme. However, when i try to execute it, it return the Error:
Exception in thread "main" java.lang.NoClassDefFoundError: me/sargunvohra/lib/pokekotlin/client/PokeApi
any idea what to do?

I broke my bintray account. Use jitpack or build from source for now until I get the library on there again.

Hey guys, I'm just wondering what your appetite would be for the following:

• A cleaner API that implements some oft-used use cases for clients
  • For example, something like:

    client.pokemon.byId(1) (returns Pokemon type)
    client.pokemon.list(offset=0, limit=20) (returns List<Pokemon>)

• Alternate client implementations (i.e. JAX-RS), each in a separate module, so users can choose which type of client they would like to use
  • They should all implement the above interfaces, so can be swapped out with one another if necessary
  • Standard caching wrapper that can be used with any of the actual clients

I'm basically looking at doing this myself already (see stocky37/pokeapi-java-clients for very initial ideas), I'm just wondering if you would be interested in me contributing it here or would prefer me to keep it separate.

While using the example, I noticed that the code would crash my application if my device didn't have internet. There was also no callstack present. Should have some way to handle this case, and also something in the logging.

Named resources should be retrievable by name too, not just by id.

When trying to clean and package my own programs, it says the POM is invalid. After enabling debugging, it says the model version is missing.

<modelVersion>4.0.0</modelVersion>

I am using 2.3.0.

Version 2.3.1 not in repository.
implementation "me.sargunvohra.lib:pokekotlin:2.3.1" (ERROR: Failed to resolve: me.sargunvohra.lib:pokekotlin:2.3.1)