Dear Developers, I am facing a usability problem when using pokekotl

Java Application exits if calling PokeAPI with invalid argument about pokekotlin HOT 5 CLOSED

pokeapi commented on August 23, 2024

Java Application exits if calling PokeAPI with invalid argument

from pokekotlin.

Comments (5)

sargunv commented on August 23, 2024 1

We should probably return something more informative than 404 in case of rate limiting

…

On Thu, Apr 18, 2019 at 16:47 Kronopt ***@***.***> wrote: By running that code you're just going over the 100 API requests per minute of pokeapi.co (https://pokeapi.co/docs/v2.html#info), as there are 293 abilities. Please read the documentation. You shouldn't be scraping the API like that. As for the error, that's probably the default error for a 404 http error. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKCLJK55RT2E2H3HMBKXJ3PREB7RANCNFSM4HHA5JVA> .

from pokekotlin.

Kronopt commented on August 23, 2024 1

I just confirmed that all 293 abilities are reachable.

from pokekotlin.

Kronopt commented on August 23, 2024

By running that code you're just going over the 100 API requests per minute of pokeapi.co (https://pokeapi.co/docs/v2.html#info), as there are 293 abilities.

Please read the documentation. You shouldn't be scraping the API like that.

As for the error, that's probably the default error for a 404 http error.

from pokekotlin.

tdmalone commented on August 23, 2024

Hmm yes... we should have a 429 instead of a 404. Having said that, I don't think we've actually got rate limiting enabled on the API at the moment (IIRC).

from pokekotlin.

sargunv commented on August 23, 2024

In that case the 404 is interesting, can we confirm all the abilities are reachable?

from pokekotlin.

Recommend Projects