phpoffice / common Goto Github PK

The change is required for PHPOffice/PHPWord#483.

Is impressive the good job made in this Project.
We think the project will be boosted if WOPI protocol is implemented as a new feature, allowing it to be a great alternative to Collabora online or Office online.

In Text.php, buildControlCharacters() constructs array of control characters, but only characters 0 - 19(without 9, 10, 13).

If i create Word2007 file with some other control character, for example 20, generated file is corrupted.

Sample:

$phpWord = new \PhpOffice\PhpWord\PhpWord();
$section = $phpWord->addSection();
$section->addText('control char 27(ESC):' . chr(27));
$objWriter = \PhpOffice\PhpWord\IOFactory::createWriter($phpWord, 'Word2007');
$objWriter->save('test.docx');

Test branch: develop.
Please consider the following error output:

PhpOffice\Common\Tests\XMLReaderTest::testShouldThrowExceptionIfNamespaceIsNotKnown
DOMXPath::query(): Undefined namespace prefix

And it seems that this test will be broken when executing the $this->xpath->query($path);.
Please see more details about this Travis build log.

Thanks.

CSV上传，单独中文字符，导致其后续空的field直接被去除，并补充到本行末尾。作者大大能复现么，或者在读取时候需要加上什么限制

Hello. I see all your projects dependence on this package and this package use pclzip. I think pclzip is very slow solution in case of managing zip-archives. As alternative for this I can support using my package (https://github.com/wapmorgan/UnifiedArchive). It provides all needed functions to work with zip archives with very big speed gain (comparing to PclZip). Also, you don't need to change all things that work with archives, only initiation part. Let me show.
It provides PclZip-like interface for ZIP archives, so all you need is to change PclZip initiation

$archive = new PclZip("archive.zip");

to UA initiation and receiving PclZip-interface

$archive = UnifiedArchive::open('ziparchive.zip')->pclzipInteface();

That's all! After that speed of all archive operations will increase.

Take your time to think that and I can help you test your products and replace old requirements with modern ones.