Git Product home page Git Product logo

asynctwitter's People

Contributors

daverandom avatar iroegbu avatar jsmitty12 avatar peehaa avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

asynctwitter's Issues

Implement sanity checks to match the API

All calls should be checked and requests should be validated.

E.g. what happens when people use both the user ids and the screen names here.

If this fails the class should add constraints to prevent this.

Update::replyTo() type hint fails on 32-bit PHP

Twitter message ids are very large, and are too big to be represented by a 32-bit integer. The int type hint on the declaration of \PeeHaa\AsyncTwitter\Api\Request\Status\Update::replyTo() causes a TypeError on 32-bit PHP:

TypeError: Argument 1 passed to PeeHaa\AsyncTwitter\Api\Request\Status\Update::replyTo() must be of the type integer, float given, called in D:\projects\phptek-asynch\twitter-bot.php on line 43 in D:\projects\phptek-asynch\vendor\peehaa\async-twitter\src\Api\Request\Status\Update.php on line 19

Originally I was thinking that this could be avoided by simply removing the type hints, but my testing shows that it won't work because PHP converts the integer to a floating point, losing some precision in the process as show in this partial print_r output of a status update:
Array ( [created_at] => Wed May 24 01:21:10 +0000 2017 [id] => 8.6718869400397E+17 [id_str] => 867188694003974148 )
The only solution is to require 64-bit PHP.

Todo before stable release

  • Check all namespaces of examples
  • Check all namespaces of tests
  • Check all namespaces of source
  • Explain project structure
  • Update readme
  • Check all namespaces of examples
  • Add contribution notes
  • Test the streaming API
  • Branch out the v1 release to the v1 branch and move ampv2 development to master
  • Write documentation
  • Move all GET, POST and DELETE requests into their own namespace
  • Check all parameters
  • Rename all lang methods to langauge

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.