Git Product home page Git Product logo

Comments (2)

DaveRandom avatar DaveRandom commented on August 29, 2024 2

My view is that we should start explicitly treating them as strings, as they are identifiers and they will never need to be treated as numbers. This would be a simple enough change, would only require JSON_BIGINT_AS_STRING and (string) casts.

There would be no need to add any additional validation that the string is numeric, since we can assume that anything returned by the API is valid, and in any operations where we send an ID to the API we already need to be prepared for errors that result from passing an identifier that doesn't exist.

This solves the 32-bit issue, and skirts any future issues we might hit because of numeric casting weirdness.

from asynctwitter.

PeeHaa avatar PeeHaa commented on August 29, 2024

Makes total sense. Thanks.

Considering this is a breaking change I will fix this in some future release. Probably https://github.com/aenglander/amp-twitter-bot also need updating so once I made the change we need to PR downstream.

from asynctwitter.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.