origamidev-pete / meshbatcher Goto Github PK

Hello, i have a question.
I have imported a model(glb) and saved it as a scene. I would like to directly use the scene saved file to batch, is it possible?

Getting error:
res://addons/MultiMeshBatcher/Batcher_Node.gd:146 - Invalid get index '0' (on base: 'Array').

Its seems there is no array check in function verify_meshes
Possible solution

 func verify_meshes(meshes : Array) -> bool:
	if meshes != []:
		var mesh_test = meshes[0].mesh
		for i in meshes:
			if i.mesh == mesh_test:
				continue
			else:
				push_error("All meshes must be the same for batching.")
				return false
		return true
	else:
		push_warning("No child meshes found! You must add mesh as children of MeshBatcher node.")
		return false

Hello, I realized the MeshBatcher node can inherit directly from MultiMeshInstance instead of spatial. It simplifies the code a great deal and creates less nodes.

I did the modification on my version and it works very well, the simpler the better I say ;)
https://github.com/Yogoda/MeshBatcher

Also not sure why you are storing the transforms (faster unbatching?). I removed it in my version, it's a lot of data.

Tell me if you want a pull request, but I'm not sure it is worth it.