Git Product home page Git Product logo

decidim's People

Contributors

agustibr avatar ahukkanen avatar aitorlb avatar andreslucena avatar armandfardeau avatar beagleknight avatar crashillo avatar davidbeig avatar decidim-bot avatar deivid-rodriguez avatar digharatta avatar entantoencuanto avatar imgbot[bot] avatar itsgenis avatar jesusdb avatar jkraemer avatar jmnzdz avatar josepjaume avatar jsperezg avatar lastpotion avatar leio10 avatar leusev avatar marcreniu avatar microstudi avatar mijailr avatar mrcasals avatar oriolgual avatar pierremesure avatar rbngzlv avatar tramuntanal avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

decidim's Issues

On 0.10-stable, reporting content (proposition or a comment) not working

When I report a content (for instance a proposition or a comment) and if I go to the admin backoffice to moderate it and hide it, in the process menu > moderation, I get this error :

capture d ecran 2018-04-10 a 19 10 38

ArgumentError (wrong number of arguments (given 1, expected 2)):
/Users/juliesimon/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/bundler/gems/decidim-fb24acdc05e5/decidim-admin/app/commands/decidim/admin/hide_resource.rb:11:in `initialize'

I was on decidim#0.10-stable with osp-app#0.10-stable

Configuration of an authorization handler

When we seed a decidim organization, as a user, we can use an authorization handler to fill in our birthday, postal code and document number.
screenshot-2018-3-15 conventions citoyennes europeennes 1

1/ How can we configure the type of fields of this authorization handler?

2/ How do we activate it so that its available to the users?

3/ In the admin dashboard, for each component, we can configure who can have access to it. What I don't understand is what sorts of data do you expect in the "options" field ? We can see that it expects a JSON, but what does decidim expect in this JSON ? For instance if you want to pass some postal codes that are authorized ? Or if you want to only let people over 18 to participate?

auth_hand_back

I can't find any documentation on the subject.
Thanks !

Quelle version de decidim utiliser pour ce répo de référence ?

Decidim sort une nouvelle version tous les 2 mois.

Vous pouvez consulter les releases log ici.
Les instances suivantes sont mises à jour :

Pour l'instant nous avons surtout travaillé avec la 0.7 stable. Je pense qu'on a intérêt à passer à la 0.8 et à migrer la modération à priori faite par Ludivine. Faudrait vérifier que les engines Conversation Pol.is et user-export fonctionne bien avec cette nouvelle version.

by @virgile-dev

Adaptation des règles de validation du formulaire de proposition

Les règles de validation se trouvent dans le dans le fichier decidim-core/app/validators/etiquette_validator.rb.

Voici une explication des différents règles. Il faut qu'on décide desquelles on garde car certaines d'entre elle nous ont causé des problèmes.
Notamment ces deux là

  • validate caps : est problématique avec l'utilisation des acronymes (ex SNCF) - voir issue
  • Le champ description est limité à 500 caractères - issue
  • validate marks nous a aussi causé des souci à plusieurs reprises.

@valentinchaput qu'en penses-tu ?


Decidim form validators

Ce bout de code sert à vérifier si il y a des majuscules qui se suivent :

def validate_caps(record, attribute, value)
    return if value.scan(/[A-Z]/).length < value.length / 4
    record.errors.add(attribute, options[:message] || :too_much_caps)
  end

Celui la sert à vérifier qu'il n'y a pas de signe de ponctuation qui se suivent :

def validate_marks(record, attribute, value)
     return if value.scan(/[!?¡¿]{2,}/).empty?
     record.errors.add(attribute, options[:message] || :too_many_marks)             
   end

Celui ci sert à ne pas avoir de mot de plus de 35 lettres :

def validate_long_words(record, attribute, value)
    return if value.scan(/[A-z]{35,}/).empty?
    record.errors.add(attribute, options[:message] || :long_words)
  end

Ce bout la permet de faire commencer la phrase par une majuscule :

def validate_caps_first(record, attribute, value)
    return if value.scan(/^[a-z]{1}/).empty?
    record.errors.add(attribute, options[:message] || :must_start_with_caps)
  end

Et celui la permet d'avoir des titres d'au moins 15 caractères :

def validate_length(record, attribute, value)
    return if value.length > 15
    record.errors.add(attribute, options[:message] || :too_short)
  end

by @virgile-dev

Possibility for pre-moderation (priori) of proposals and comments

This is a Feature Proposal

🎩 Description

This issue originates from the decidim main repository.

Regarding that, I was made aware that pre-moderation (or priori moderation) has been implemented in this Decidim repository due to convincing some organizations into using Decidim. Further details regarding the feature proposal and also about the implementation details can be found from the linked Decidim main repository issue. The implemented code is available in the f-moderation branch of this repository.

What I am suggesting is that we should extract this feature into its own gem so that this feature would be more widely available to the decidim users. There is the ideological debate also concerning this issue whether it is good for the Decidim community to make this feature mode widely available. However, I personally believe this may lead into more Decidim users as already proven by the original need of developing this feature.

Action points:

  • 👍 Yes, let's do it! - Leave a thumbs up to this thread if you feel this feature should be available for all Decidim users.
  • 👎 No, this should not be done! - Leave a thumbs down to this thread if you feel this feature should NOT be available for all Decidim users.

The repository maintainer can decide the threshold on when this would be accepted/rejected.

In case this is accepted, we would need to scratch out a plan on the implementation details and how it would be possible to extract this feature into its own gem.

📌 Related issues

📋 Additional Data

  • Decidim deployment where you found the issue:
  • Browser & version:
  • Screenshot:
  • Error messages:
  • URL to reproduce the error:

Screens about the implementation:
https://www.figma.com/file/MX4BYbJ5VKUO1xSraC8DQefk/user-flow-moderation-a-priori

Logical workflow:

Customize secondary navbar

On the MEL's platform, you hide "Processus participatifs" + "Plus d'information" on the secondary navbar in order to place custom links :
capture d ecran 2018-03-08 a 17 00 21

Angers also uses a custom link to "Budget participatif 2018" but cannot display it before "Participations en cours" + "Plus d'information" as they are not hidden :
capture d ecran 2018-03-08 a 17 02 21

Could you make the same change in order to have "Accueil / Budget participatif 2018 / Participations en cours / Plus d'information" (they may have to recreate the last two manually)? And document the issue so Julie will know how to do it next time ;)

Comments not working on debates and blogs

As a user I can't leave a comment on the features that have been added by the Decidim team since OSP developed upstream moderation.
Here is the error message I get when I try to leave a comment :

Completed 500 Internal Server Error in 104ms (ActiveRecord: 8.0ms)
NoMethodError (undefined method `comments_upstream_moderation_enabled' for #<#<Class:0x00007fe94d87a620>:0x00007fe94da5c470>)

Maybe it's because upstream moderation has to be set for the new features "debates" and "blogs"

Front nouvelle aquitaine

  1. Faire les modifications sur decidim/0.9-separate_proposal
  2. Merger dans OSP/0.9-separate_proposal
  3. Et enfin fait une PR de OSP/0.9-separate_proposal dans 0.9-nouvelle_aquitaine (Fais moi signe à ce moment là afin que je la merge rapidement)
  • Affichage des icones

screen shot 2018-02-28 at 17 05 05

  • Quand on passe en mode mobile, les propositions ne s'affichent plus. L'un des containers doit avoir un média querie lui disant de disparaitre en mobile.

screen shot 2018-02-28 at 17 08 29

  • La partie grise (lorsque l'affichage est en ligne) n'est pas tout à fait responsive

screen shot 2018-02-28 at 17 32 28

  • Mettre de l’espace entre “X propositions” et les propositions

screen shot 2018-02-28 at 17 10 38

  • Le bouton "voir toutes les propositions"

screen shot 2018-02-28 at 17 11 23

doit ressembler à :

screen shot 2018-02-28 at 17 11 51

Understanding (and fixing ?) Managed users

  • Now using the dummy authorisation handler, with field "document number" that has to end with an X --> should create a specific AH for each client/need ?

  • No error message appears when trying to managed a user with a name that is already taken

  • Two buttons "Create" and "Send" that do the same action : what is the need for these two buttons ?

capture d ecran 2018-03-23 a 16 47 37

French translation keys

  • Changer "Assemblées" (car confusion avec l'Assemblée nationale) en "Initiatives" (même mot qu'en catalan ?) @valentinchaput vu que ya déjà un espace de participation qui s'appelle "Initiative" faut qu'on lui trouve un autre nom. Des idées ?
  • Dans la section "Auteurs" des filtres des proposition, remplacer "Elu-e-s" par "Propositions officielles" et "Citoyens" par "Propositions citoyennes"
  • Dans le formulaire de signalement des propositions/commentaires, rajouter "homophobes" après sexistes (Traduction actuelle: "Contient des propos racistes, sexistes, des insultes, des attaques personnelles, des menaces de mort, des incitations au suicide ou toute forme de discours de haine."

Navbar custom

Objectif : rendre la secondary navbar éditable pour pouvoir

  • intégrer un lien direct vers une page du site (ex : budget Angers)
  • intégrer un lien direct vers un site externe

by @valentinchaput

Showing user data in exports (of proposals, meetings, etc)

So far, nothing about the user appears in the export of a proposal (and for all exports)

capture d ecran 2018-03-23 a 17 30 52

Angers needs it since the administrators of the platform sends the xls to the service which in fine contacts the users regarding their proposals.

Should we include user data, in terms of privacy ?
If so, what could we include ? Name, username, email ?

Modifier les états d'une proposition

Actuellement, les administrateurs peuvent "répondre" à une proposition en lui accordant un statut "retenue/refusée/en cours d'évaluation". Il faudrait pouvoir ajouter un ou plusieurs statuts supplémentaires (ex d'Angers : recevable, non recevable, en cours d'évaluation, réalisable, non réalisable, soumis au vote...).

by @valentinchaput

#FrenchConnection

Standardisation FR

Traduction

  • couverture à 99.9% (cf. decidim:check_locales ou crowdin.com)
  • exemple(s) de surcharge de clé standard pour projets custo
  • français par défaut au déploiement (bien vérifier que la partie /system et db:seed soient pris en compte)

Authorization Handler

  • ajouter un AuthorizationHandler dédié aux formats FR (N° Sécu, Carte Identité, Passeport etc...)
  • Tests des fonctionnalités pour comptes validés / non validés ( Certification ✅ )

France Connect

  • ajout d'un connecteur OmniAuth / France Connect
  • gestion Authorization Handler (auto validation)
  • documenter la procédure d'ouverture de service

Documentation
Exemple de connecteur

Geocoding BAN data.gouv.fr

  • Carte : intégration de leaflet-rails
  • Géocodage : intégration de OpenStreetMap(Nominatim) et Google Map API
  • Géocodage : intégration de la base adresse.data.gouv.fr
  • ajout des options et clé de configuration ad-hoc

Module Geocoder
(et le mode data.gouv)
Gem leaflet-rails

Exports Decidim : piste d'amélioration pour réaliser un traitement automatique

1 / Les exports des commentaires de Decidim ne mentionnent pas la catégorie de la proposition à laquelle ils sont reliés. Ceci pose problème dans l'analyse du corpus car sans ces catégories les commentaires ne peuvent pas être traités de façon pertinente.

2 / Il faudrait donc que dans les exports des commentaires, il y ait une colone "Category" comme dans les exports des propositions, qui mentionne le nom de la catégorie.

Bug sending invit for admin

As an admin I can invite another person to be an admin when I create the organisation

This is a Bug Report

Bug sending invitation for admin when creating an organisation
by @virgile-dev

🎩 Description

📌 Related issues

📋 Additional Data

Translation "email_intro" is not working in email

On pompano.osp.cat, when there is a new comment, the mail that is sent to the administrator is not using the french translation for the email_intro variable :
capture d ecran 2018-03-12 a 14 02 25

But we can see in the locale file decidim/decidim_comments/config/locales/fr.yml that email_intro is translated in french

    events:
      comments:
        comment_created:
          comment:
            email_intro: '"%{resource_title}" a été commenté. Vous pouvez lire le commentaire sur cette page:'
            email_outro: Vous avez reçu cette notification parce que vous suivez "%{resource_title}" ou son auteur. Vous pouvez annuler ces notifications à partir du lien précédent.
            email_subject: Un nouveau commentaire a été publié par %{author_name} dans %{resource_title}
            notification_title: Un nouveau commentaire a été publié par <a href="%{author_path}">%{author_name} %{author_nickname}</a> dans <a href="%{resource_path}">%{resource_title}</a>

Responsivité de l'affichage en liste des propositions à améliorer

@ludivine cette issue faisait partie de la liste que tu m'avais confiée mais je n'ai pas eu le temps (à me battre avec le déploiement), penses tu pouvoir t'en occuper pendant tes journées decidim ?

  • Lorsque les catégories "proposals" des cartes en liste sont très longues, les boutons de vote vont à la ligne et l'affichage est étrange, que ce soit sur un petit, moyen ou grand écran. Il y a également un problème d'affichage en liste des propositions refusées, qui n'ont donc pas de vote possible :
    1/ LARGE
    capture d ecran - 2018-03-06 a 10 12 13
    2/ MEDIUM
    capture d ecran - 2018-03-06 a 10 12 04
    3/ SMALL
    capture d ecran - 2018-03-06 a 10 11 44

Il faudrait que l'affichage des cards-lists suive les comportements suivants :

  • en écran large, les boutons de vote reste à droite. Les catégories vont à la ligne dans leur container, comme sur les cards classiques :

capture d ecran 2018-03-06 a 10 41 07

- en écran medium/small, les boutons de vote vont en bas de la carde et prennent toute la largeur. Les catégories vont aussi à la ligne dans leur container.

capture d ecran 2018-03-06 a 10 42 28

  • Dans le cas d'une proposition refusée, il faut que le footer gris de la card prenne toute la largeur, comme lors de l'affichage classique :

capture d ecran 2018-03-06 a 10 45 48

Enhancement on navbar links

Navbar links first version was done based on this #3 for spec

Is left to do :

Several bugs in production related to user sign up

This is a (Bug Report / Feature Proposal)

🎩 Description

In the past few days we've had several problems related to the decidim-angers repo that is deployed in angers.opensourcepolitics.eu.

Bugs were related to user sign ups :

  • At first, when trying to sign up, once form filled and clicking on the sign up button, the app would return a "the server couldn't locate your page".
  • Then after @moustachu spent some time on it, but it seem we haven't solved all problems. The behaviour right now is that when signing up you are able to fill the form but you never receive the confirmation email. I've been doing some testing on my side using the regular osp-app and i replicated this bug. So it's not just related to osp-angers.

Add status tags for the comment moderation

This is a Feature Proposal

🎩 Description

Context :
Ludivine has been working on moderations adding the possibility to moderate content a priori for proposals and comments (on all comment objects on the app : meetings, results, etc.). On the Decidim core it is only possible to moderate a posteriori, meaning after a comment / proposal was published and signaled. A priori moderation means that moderators and admins can review what's being published before hand and decide to publish it or not. Here is the spec that was given to Ludivine
user flow

Admin and moderator can see content that is not visible to normal users so they can checkout what they moderate.

The problem we had is that when moderating comments, it's not easy for admins and moderators to see the effect of their moderation work as everything was displayed (included content that were moderated and don't display for normal users). So to see the effect you had to log off and load the page as a normal user.

For proposals we just filtered the list of proposals to only show those which where tagged as OK to display.

For comments @ludivinecp told me it might be complicated to filter them to only show those which were tagged as OK to display.

Maybe if you could quickly explain why

We came up with this solution of displaying tags next to comments to specify the status of the comment to help admin and moderators distinguish them. Here is a little mockup we did.

Ludivine suggested that @netbe could try to work on this as the comment system on decidim uses react and he is familiar with that technology.

Strange date display on Admin

A strange behaviour occurs with the date configuration in a participatory process.

1/ Months are written in French, but dates are in English (MM/DD/YYYY) -- which we might change eventually for our French-speaking clients.

2/ The main problem: when you add dates on the information page of your participatory process, they change with no reason when you save the page. The dates are good on the front page but the ones in the admin panel are wrong. Even when you try to restore them, they change again when you save your page.

Pictures from a same participatory process:

capture d ecran 2018-01-25 a 14 04 48

capture d ecran 2018-01-25 a 14 12 54

/admin/officializations shows all users across all organizations

We have a weird behaviour since we upgraded to 0.9 the /admin/officializations is showing all the users accross all the organizations. For example if signup on org A, the user will also be listed on org B in /admin/officializations. Is the same happening for you ? Thanks in advance.

The decidim core team submitted a patch :
decidim#2912

It'd be great to apply it to our repo.

Distinguish user generated content in emails

This is a Feature Proposal

🎩 Description

Quand la modération à priori est activée et qu'un nouveau contenu est envoyé par un utilisateur, les modérateurs et les admin reçoivent un mail comme celui-ci.
capture d ecran 2018-01-03 a 16 06 15
On a du mal a distinguer le contenu à modérer. Je propose de changer un peu le layout de l'email pour qu'il ressorte plus. Comme ceci :
mailing-highlight-uc

Translation error in proposals index

Proposal index : the proposals counter is not correct when the language is set to french. It display "1" even if there is no proposal. The counter has the correct value in English.

screen shot 2018-01-09 at 23 07 30

screen shot 2018-01-09 at 23 11 02

Add images to snippets when sharing on social networks

This is a Feature Proposal

🎩 Description

When sharing a process/page/proposal on facebook, we get the content of the proposal + the box with a link. On decidim.barcelona, they also manage to show an image which makes the content more attractive. How could we achieve the same result?

capture d ecran 2018-02-16 a 13 12

Going further, would it be possible to choose/edit those text & image?

Typo in statistics

On club.decidim.opensourcepolitics.eu, there is a typo in the activity statistics at the bottom of the page :

typo in statistics

It should print "1 PROPOSITION" and "1 REUNION".

Moderation a priori des commentaires/propositions ne fonctionne pas sur la branche 0.9-Nouvelle-Aquitaine

This is a Bug Report

🎩 Description

Modération a priori des propositions ne fonctionnent pas sur https://concertations-preprod.nouvelle-aquitaine.fr/processes/second/f/44/
Osp-app : deploy-NA
Decidim : 0.9-Nouvelle-Aquitaine

Il est très probable que de la même manière, la modération a priori des commentaires ne fonctionne pas non plus (à tester)

A titre de comparaison, la modération a priori semble fonctionner sur https://cndp.test.opensourcepolitics.eu/processes/test/f/52/
Osp-app : alt/cndp
Decidim : 0.9-stable

  • Decidim deployment where you found the issue:
  • Browser & version:
  • Screenshot:
  • Error messages:
  • URL to reproduce the error:

Counter error

When French is activated, on club.decidim.opensourcepolitics.eu, there is an counting error : when there is no submitted proposition, it still reads "1 PROPOSITION".

counting error

Merger modération

Il faudrait merger la branche f-moderation. Elle a été mise à jour par rapport aux dernières MAJ des barcelonnais.
Il faut juste vérifier que tout marche correctement avant de la merger.

Check if branch f-moderation upgrade to 0.9.pre went OK

Context for the moderation à priori feature

Ludivine has been working on moderations adding the possibility to moderate content a priori for proposals and comments (on all comment objects on the app : meetings, results, etc.). On the Decidim original gem it is only possible to moderate a posteriori, meaning after a comment / proposal was published and signaled. A priori moderation means that moderators and admins can review what's being published before hand and decide to publish it or not. Here is the spec that was given to Ludivine
user flow

Mockups can be checked here : https://www.figma.com/file/MX4BYbJ5VKUO1xSraC8DQefk/user-flow-moderation-a-priori?node-id=0%3A1

Ludivine just merged the branch f-moderation with develop which was upgraded to the last version of decidim 0.9.pre.

The task here is to check if the upgrade went ok:

Migrations to run before deploying new version

rails decidim:install:migrations
rails  decidim_admin:install:migrations
rails      decidim_system:install:migrations
rails      decidim_accountability:install:migrations
rails      decidim_participatory_processes:install:migrations
rails       decidim:install:migrations
rails     decidim_budgets:install:migrations
rails       decidim_pages:install:migrations
rails     decidim_meetings:install:migrations
rails     decidim_comments:install:migrations
rails    decidim_surveys:install:migrations
rails decidim_proposals:install:migrations
rails decidim_assemblies:install:migrations

Proposal form not working (could be caused by old data)

This is a Bug Report

🎩 Description

@Olivier-B-Paris has been trying hard to create an agora with proposals that features philosophy text about democracy. He has stumbled upon a bug which can be described this way:

  • As a user I cannot create a proposal on an assembly

After some time trying to understand where it was coming from it seems that this bug is occuring only on this organization: https://demo.decidim.opensourcepolitics.eu

I think that it might be related with some old data or migration that didn't work. Indeed, we tried the same thing on a fresh organization: https://agora.decidim.opensourcepolitics.eu/ and it worked !! Proof here : https://agora.decidim.opensourcepolitics.eu/assemblies/ujklm/f/106/proposals/186

📋 Additional Data

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.