Git Product home page Git Product logo

apps-store's People

Contributors

oca-git-bot avatar sbidoul avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

apps-store's Issues

Order of module results doesn't help

See, I've made a search for the module l10n_es_toponyms and these are the results:

Captura de pantalla de 2020-01-29 08-20-12

As you can see, the most important result appears last. This is something that keeps bugging me around. It seems like the search also matches when a module depends on the one you're searching on any version, which could help or could just clutter the results without need when you know what you're searching. When there are several pages of results, it's fastidious.

For example, the module l10n_es_location_nuts appears there because in v8 it depended on l10n_es_toponyms, but it's unrelated in higher versions. Also that relation is not clear when you see the module page.

The situation for l10n_es_partner is pretty similar.

So, my suggestion is that we should reorder modules like this:

  1. Module that matches exactly the query (l10n_es_toponyms).
  2. Modules that match partially the query (l10n_es_toponyms_region).
  3. Modules where some dependency matches the query.

The 3rd one could even be a checkbox "search dependencies", which could be enabled or disabled by default. It could add a GET param to the URL, so bookmark users can just choose to (dis/en)able it directly.

[13.0] internal server error on download

I got this when trying to download from https://odoo-community.org/shop/product/mis-builder-budget-1639

Traceback (most recent call last):
  File "/home/openerp/instance/odoo-community-prod/src/odoo/odoo/addons/base/models/ir_http.py", line 234, in _dispatch
    result = request.dispatch()
  File "/home/openerp/instance/odoo-community-prod/src/odoo/odoo/http.py", line 809, in dispatch
    r = self._call_function(**self.params)
  File "/home/openerp/instance/odoo-community-prod/src/odoo/odoo/http.py", line 350, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/openerp/instance/odoo-community-prod/src/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/openerp/instance/odoo-community-prod/src/odoo/odoo/http.py", line 339, in checked_call
    result = self.endpoint(*a, **kw)
  File "/home/openerp/instance/odoo-community-prod/src/odoo/odoo/http.py", line 915, in __call__
    return self.method(*args, **kw)
  File "/home/openerp/instance/odoo-community-prod/src/odoo/odoo/http.py", line 515, in response_wrap
    response = f(*args, **kw)
  File "/home/openerp/instance/odoo-community-prod/src/apps-store/website_apps_store/controllers/main.py", line 236, in download_product_zip
    disposition = 'attachment; filename="%s"' % attachment.datas_fname
AttributeError: 'ir.attachment' object has no attribute 'datas_fname'

Search is not working properly

Although the current code is performing a search on all the relevant fields, including technical name, name and descriptions, my experience in the App store is that it is not working as expected.

Specific example:

  • there is a auth_topt module, "MFA Support". The "topt" text is both in the technical name and in the module description.
  • searching the App store for "topt" returns no results!

Any ideas on why this might be?

Categories sync / Odoo

It seems that Odoo modules categories are inconsistent through versions.

I'm wondering what should we do with OCA apps site helping people filtering modules per categories.

Either staying with original ones ?

Or breaking with Odoo ones and maybe creating OCA ones in order to fulfill our specific needs?

@OCA/core-maintainers

[13.0] Apps Store

Hi All,

First off, really appreciate all the hard work you all do!!

Not sure to call this an issue, perhaps more of my probably just not sure I am using the addons correctly. With my use case, Its not to provide download for odoo modules, but to mobile applications I have I have built.

I create the product, I then add the android files, I then add my own variants, I then update the variant information. How this is where I then come into the issue.

No matter what I have tried, I keep getting

This product has no valid combination.

Just not sure what I am doing wrong to be honest. Would really appreciate the help.

Thanks in advance.

[RFC] Priority for search result

Currently when we search it is searching directly on the name, desc, rst/html desc, author and everything.
The result is we have a lot of modules in search and the real meaningful module will be pointed out.

IMO we should have smart sorting (or maybe a proper name) option for sort, which will search include the apps in below orders

  1. match with the technical name "=" operator
  2. match with the name "=" operator.
  3. match with technical name and name with ilike operator.
  4. author "=" and "ilike" operator
  5. rest current conditions.

Product variants are not created for new module versions, if product variants related to old module versions are already created.

Steps to reproduce issue:

  1. Go to Github menu → Repositories → Click on Branches sync.
  2. Click on “Branches” button.
  3. Select any branch. For example v9.
  4. Click on “Download Source Code”.
  5. Click on “Analyze Source Code”.
  6. Go to settings → Automation → Scheduled Actions and run scheduler of “Create product variants for each module version“.
  7. It will create product template and variants for v9.
  8. Fetch module for v10 or for any version by following above steps.
  9. Run scheduler again to create product variant for newer version.

Now, It is not creating product variant for newer version. Have I missed something?

Maturity level: PR

during some discussions at the code sprint I got the impression most unrest about reviews, conventions and merging stems from the fact that stuff has to be merged to be visible, and that's what people care for much more than the actual merge.

So why don't we approach the maturity slightly differently: We scan open PRs for the ones that add a module, that should be simple to detect. If the PR is done by an OCA member (in order to avoid people being able to spam the webshop), we add it to the shop with maturity alpha. So we get early releases, but don't have to merge subpar code. The advantage I see is that this way, a module can mature without creating possible problems in a branch by being merged prematurely (unprotected imports, wrong monkey patching and the like). This can also be a selling point for the OCA membership, and can inform us about which modules users like most, thus allowing us to direct the review efforts to the ones that are most wide-spread. Plus there's no interaction needed by anyone to get something published, which probably would stay a bottleneck.

cc @OCA/board

[RFC] Apps Store front end

Introduction

The modules on this repository aim to build an apps store based on:

  • Standard Odoo v10 ecommerce
  • Github Connector

Currently 2 modules are available apps_product_creator and apps_download linked to github-connector modules which information is used to create one product per module:

  • apps_product_creator will check the new modules in the repositories and create or update the products (one per module and version) in the database. Additionally important information from the manifest are populated in specific fields
  • apps_download is responsible to create and update one zip file per module based on the content of Github repository and link it to the product in Odoo.

A third module is needed to complete the other 2 and display the module specific information in a standard Odoo e-commerce website (front-end).

This document aims to specify the views, data and process to be done via this third module.

Module information

  • Module name: website_apps_store
  • Version: v10.0 (compatible Community and Enterprise Edition)
  • Dependency: ecommerce, apps_download, apps_product_creator
  • License: AGPL-3

Front-end view

E-commerce catalogue page

Here is the mock up suggested for the product catalogue page:
front

Changes expected to the standard e-commerce page:

  • Add Author
  • Hide the price
  • Add Versions supported by the module

Search function should allow:

  • Fuzzy search
  • Content in module name, author and summary

3 filters widget to be added:

  • Author
  • Version
  • Category

Product Detailed page

Here is the mock up suggested for the product detailed page:
detail

NB: Current design is based on one page for all versions of the module, displaying the module description of the highest version.

Standard Odoo Fields:

  • Image
  • Product name

Add following fields (based on the manifest of the higher version)

  • Module summary
  • Radio button with the versions available for the module (From higher to lower, default = higher)
  • Button "Download"
  • Miscellaneous fields:
    • Technical Name
    • Author
    • Maintainer (Link to Contributor Page - static page in odoo-community.org)
    • License (Link to the license on the OSI website)
    • Website (URL)
    • Repository (URL)
  • HTML description of the product

NB:

  • all link should open in new tab
  • Module details (summary, name, description...) should be dynamic depending on the selected version.
  • Update Process: Pages are rebuilt every night via cron job after the module information have been update from Github. Only pages from updated modules are to be rebuilt.

checkout process

  1. The visitor will select a module from the catalogue page
  2. The visitor select the version he wants to download for the module
  3. Visitor clicks on Download button and the download of the zip file linked to the selected product starts in the browser

NB:

  • no login is required for download
  • All other checkout buttons should be hidden

Roadmap:

  • add an extensive search based on the content of RST
  • Add multiple images if the modules contains multiple screenshots/images/icon.
  • Add a donation button

apps_product_creator: External ID not found attribute_odoo_version

Hello !
We have used
Odoo Version attribute in Py file for creating Product's variants
https://github.com/OCA/apps-store/blob/10.0/apps_product_creator/models/odoo_module.py#L90
But it has been added from the demo data.
https://github.com/OCA/apps-store/blob/10.0/apps_product_creator/__manifest__.py#L22
https://github.com/OCA/apps-store/blob/10.0/apps_product_creator/demo/product_attribute.xml#L6
IMO the place of product_attribute.xml will be in Data tag and folder and not in demo data.
I can change it while working on the website. but just wanted to confirm that Am I right or not.

[RFC] `breaks` in manifest

To make the shop a pleasant experience, we should be able to tell users that some module doesn't work in their specific situation. Might be view incompatibilities, incompatible overrides or the like.

I've put a breaks key in the roadmap of https://github.com/OCA/server-tools/tree/10.0/base_manifest_extension, I think it would be useful to implement that for the shop. Then we can add this information to our ecosystem, making stuff more stable for everyone. We can also go crazy and add more debianish keys, like recommends or suggests. Versioned dependencies also could be helpful in the shop context.

Search filter is lost when paging the results

peek 2018-12-03 09-41

  1. input a text for search "account currency"
  2. Click on page 2 button
    Expected result: see page 2 of the search result
    Current result: the search text is remove and page 2 is irrelevant

website_apps_store: The search domain is very open

Module

website_apps_store

Describe the bug

The search domain is so open that it generates a lot of noise.

To Reproduce

Affected versions: 14.0

Steps to reproduce the behavior:

  1. Search 'web_responsive'

Expected behavior
Be clear about why the results are shown as they are shown. Perhaps a new filter would be helpful or give more importance to matches by technical name.

Additional context
search_oca

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.