Comments (15)
Ok, then this should be correct and can be closed.
from apps-store.
It is probably due to the fact that the algorithm will try to explore any kind of image in the module to display in front and pick the one of the contributor/maintainer in case of absence (a guess as I didnot revisit the code).
We should probably discuss the basic selection rules for images (in order of priority):
- image tag in manifest
- icon in description folder
- standard OCA icon
cc @OCA/board
from apps-store.
The module icon should have priority for sure.
from apps-store.
I am not sure here.
I would like to achieve this:
and icons are not suitable by default for this: an image with proper design is better
from apps-store.
Well, that's not what is achieved right now any way.
from apps-store.
I know: we are still finetuning
from apps-store.
it is taking the priority from https://github.com/OCA/interface-github/blob/11.0/github_connector_odoo/models/odoo_module_version.py#L23
as static/src/img path is first it is taking the icon from that path.
https://github.com/OCA/mis-builder/blob/8.0/mis_builder/static/src/img/icon.png
from apps-store.
Agh, curious thing! It's taking an old icon (valid for <v8) that hasn't been removed through all versions. @sbidoul can you please remove it in all branches? Or should I?
from apps-store.
@sbidoul @pedrobaeza Is this taken care of? Is there anything we could help?
from apps-store.
@bizzappdev What do you think about the image management?
Today we have another open issue #28 where the image is not even and I think we can improve without much work.
Shall I start a specific issue for that?
from apps-store.
In this case, @sbidoul should remove that old icon in the repo.
from apps-store.
Sorry guys, I lost the thread. What should I do exactly?
from apps-store.
Remove the acsone icon in mis-builder in the offending route (static/src/img/icon.png).
from apps-store.
At least the link above shows a 404 since many weeks. Is there another one?
from apps-store.
yes as it has been already taken care OCA/mis-builder@9b8f701
and also proper Image is on app store.
https://odoo-community.org/shop/product/mis-builder-1636?search=mis+builder
from apps-store.
Related Issues (20)
- Cannot select v12 in the filter HOT 6
- Cannot find module account_invoice_kanban HOT 3
- No visual feedback when selection version, maturity level from top right drop down
- Features to be developed during OCA Days sprint India HOT 8
- Search filter is lost when paging the results
- [RFC] Add the module technical name in front page
- [RFC] Priority for search result HOT 10
- Link target incorrect in repository reference HOT 1
- Migration to version 13.0
- Search is not working properly HOT 3
- Error on account_banking_payment_export v8 HOT 2
- Order of module results doesn't help HOT 4
- Migration to version 14.0 HOT 1
- [13.0] internal server error on download HOT 3
- Categories sync / Odoo HOT 4
- [13.0] apps_download: Error while trying to download an app (base_import_async) HOT 3
- [13.0] Apps Store HOT 1
- Migration to version 15.0 HOT 1
- Migration to version 16.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apps-store.