Hi,

I wanted to try this out on my AMD Vega 56 but i fail to run any sample. Is this Nvidia only ?

The procedure entry point D3DKMTOpenBundleObjectNtHandleFromName could not be located in the dynamic link library d3d12.dll

I am not sure what's the best way to contact Nvidia/Nir Benty about this, so I'll try just here:

At the end of Nir Benty's talk about Falcor during the GDC session "The Ray + Raster Era Begins: An R&D roadmap for the game industry", a sample pack has been promised (see [1] at 53:34). I wanted to ask if that samples pack is already available somewhere or when it will be released.

I am especially interested in denoiser examples, because I haven't been able to find any of these yet. There is a lot being talked about denoisers in the GDC talk "Ray Tracing in Games with NVIDIA RTX" [2], like that different denoisers have to be applied depending on the kind of data. I am wondering if these are stock denoisers (as they appear to be included with OptiX) and if so, how they can be used.

Thanks!

[1] https://youtu.be/Q8e3rFkLZUg?t=3274
[2] https://youtu.be/EFLimT4ik_8

Running the 13 or 14 .exe files, they give the error "Raytracing is not supported on this device. Make sure your GPU supports DXR (such as Nvidia's Volta or Turing RTX) and you're on the latest drivers. The DXR fallback layer is not supported."
I noticed that changing the following piece of code, bringing it back to that in the previous tutorials (from 02 to 12), the issue is solved:
Not working code:

ID3D12Device5Ptr createDevice(IDXGIFactory4Ptr pDxgiFactory)
{
    // Find the HW adapter
    IDXGIAdapter1Ptr pAdapter;

    for (uint32_t i = 0; DXGI_ERROR_NOT_FOUND != pDxgiFactory->EnumAdapters1(i, &pAdapter); i++)
    {
        DXGI_ADAPTER_DESC1 desc;
        pAdapter->GetDesc1(&desc);

        // Skip SW adapters
        if (desc.Flags & DXGI_ADAPTER_FLAG_SOFTWARE) continue;
#ifdef _DEBUG
        ID3D12DebugPtr pDx12Debug;
        if (SUCCEEDED(D3D12GetDebugInterface(IID_PPV_ARGS(&pDx12Debug))))
        {
            pDx12Debug->EnableDebugLayer();
        }
#endif
        // Create the device
        ID3D12Device5Ptr pDevice;
        d3d_call(D3D12CreateDevice(pAdapter, D3D_FEATURE_LEVEL_12_0, IID_PPV_ARGS(&pDevice)));

        D3D12_FEATURE_DATA_D3D12_OPTIONS5 features5;
        HRESULT hr = pDevice->CheckFeatureSupport(D3D12_FEATURE_D3D12_OPTIONS5, &features5, sizeof(D3D12_FEATURE_DATA_D3D12_OPTIONS5));
        if (FAILED(hr) || features5.RaytracingTier == D3D12_RAYTRACING_TIER_NOT_SUPPORTED)
        {
            msgBox("Raytracing is not supported on this device. Make sure your GPU supports DXR (such as Nvidia's Volta or Turing RTX) and you're on the latest drivers. The DXR fallback layer is not supported.");
            exit(1);
            return nullptr;
        }
        return pDevice;
    }
}

WORKING CODE:

ID3D12Device5Ptr createDevice(IDXGIFactory4Ptr pDxgiFactory)
{
    // Find the HW adapter
    IDXGIAdapter1Ptr pAdapter;

    for (uint32_t i = 0; DXGI_ERROR_NOT_FOUND != pDxgiFactory->EnumAdapters1(i, &pAdapter); i++)
    {
        DXGI_ADAPTER_DESC1 desc;
        pAdapter->GetDesc1(&desc);

        // Skip SW adapters
        if (desc.Flags & DXGI_ADAPTER_FLAG_SOFTWARE) continue;
#ifdef _DEBUG
        ID3D12DebugPtr pDx12Debug;
        if (SUCCEEDED(D3D12GetDebugInterface(IID_PPV_ARGS(&pDx12Debug))))
        {
            pDx12Debug->EnableDebugLayer();
        }
#endif
        // Create the device
        ID3D12Device5Ptr pDevice;
        d3d_call(D3D12CreateDevice(pAdapter, D3D_FEATURE_LEVEL_12_0, IID_PPV_ARGS(&pDevice)));

        D3D12_FEATURE_DATA_D3D12_OPTIONS5 features5;
        HRESULT hr = pDevice->CheckFeatureSupport(D3D12_FEATURE_D3D12_OPTIONS5, &features5, sizeof(D3D12_FEATURE_DATA_D3D12_OPTIONS5));
        if (SUCCEEDED(hr) && features5.RaytracingTier != D3D12_RAYTRACING_TIER_NOT_SUPPORTED)
        {
            return pDevice;
        }
    }
        msgBox("Raytracing is not supported on this device. Make sure your GPU supports DXR (such as Nvidia's Volta or Turing RTX) and you're on the latest drivers. The DXR fallback layer is not supported.");
        exit(1);
        return nullptr;
}

What to do in order to separate the plane instance from those of triangles, making the instance n. 0 reserved only to the plane and the following remaining reserved for only triangles?

14-Shaders.hlsl
#113 row
TraceRay(gRtScene, 0 /rayFlags/, 0xFF, 1 /* ray index*/, 0, 1, ray, shadowPayload);
---------------------------------------------------------------------------------------->
TraceRay(gRtScene, 0 /rayFlags/, 0xFF, 1 /* ray index*/, 2, 1, ray, shadowPayload);

I thine the muiltiplier for Geometry ContributionToHitGroupIndex may be 2, not 0.
Or it cannot fit with Shader Table Entry.

Now that both Win 1809 ,Windows SDK 17763 and 416.16 support it..

The latest version of this set of tutorials is at http://intro-to-dxr.cwyman.org/ , download direct link, I believe. For example, that set contains the "RayTracingInOneWeekend" demo. It would be good to update the code here, since Microsoft's repo points to it.

1>------ Compilação iniciada: Projeto: 01-CreateWindow, Configuração: Debug x64 ------
1>Fetching [email protected] from S3 ...
1>Connecting to S3 ...
1>Downloading ...
1>Unpacking ...
1> File "C:\IntelPython3\Lib\site.py", line 177
1> file=sys.stderr)
1> ^
1>SyntaxError: invalid syntax
1>!!! Failure while configuring local machine :( !!!
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(123,5): error MSB3073: O comando "call C:\Users\andre\Source\Repos\DxrTutorials\Framework\BuildScripts\prebuild.bat C:\Users\andre\Source\Repos\DxrTutorials\.............\Framework\ C:\Users\andre\Source\Repos\DxrTutorials\ C:\Users\andre\Source\repos\DxrTutorials\Tutorials\01-CreateWindow\ x64 x64 Debug C:\Users\andre\Source\Repos\DxrTutorials\Bin\x64\Debug
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(123,5): error MSB3073: :VCEnd" foi encerrado com o código 1.
1>Projeto de compilação pronto "01-CreateWindow.vcxproj" -- FALHA.
2>------ Compilação iniciada: Projeto: 03-AccelerationStructure, Configuração: Debug x64 ------
3>------ Compilação iniciada: Projeto: 04-RtPipelineState, Configuração: Debug x64 ------
4>------ Compilação iniciada: Projeto: 06-Raytrace, Configuração: Debug x64 ------
5>------ Compilação iniciada: Projeto: 07-BasicShaders, Configuração: Debug x64 ------
6>------ Compilação iniciada: Projeto: 08-Instancing, Configuração: Debug x64 ------
7>------ Compilação iniciada: Projeto: 09-ConstantBuffer, Configuração: Debug x64 ------
8>------ Compilação iniciada: Projeto: 10-PerInstanceConstantBuffer, Configuração: Debug x64 ------
9>------ Compilação iniciada: Projeto: 11-SecondGeometry, Configuração: Debug x64 ------
2>03-AccelerationStructure.cpp
3>04-RtPipelineState.cpp
4>06-Raytrace.cpp
5>07-BasicShaders.cpp
9>11-SecondGeometry.cpp
6>08-Instancing.cpp
7>09-ConstantBuffer.cpp
8>10-PerInstanceConstantBuffer.cpp
4>c:\users\andre\source\repos\dxrtutorials\tutorials\06-raytrace\06-raytrace.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
2>c:\users\andre\source\repos\dxrtutorials\tutorials\03-accelerationstructure\03-accelerationstructure.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
3>c:\users\andre\source\repos\dxrtutorials\tutorials\04-rtpipelinestate\04-rtpipelinestate.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
5>c:\users\andre\source\repos\dxrtutorials\tutorials\07-basicshaders\07-basicshaders.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
9>c:\users\andre\source\repos\dxrtutorials\tutorials\11-secondgeometry\11-secondgeometry.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
7>c:\users\andre\source\repos\dxrtutorials\tutorials\09-constantbuffer\09-constantbuffer.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
8>c:\users\andre\source\repos\dxrtutorials\tutorials\10-perinstanceconstantbuffer\10-perinstanceconstantbuffer.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
6>c:\users\andre\source\repos\dxrtutorials\tutorials\08-instancing\08-instancing.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
9>Projeto de compilação pronto "11-SecondGeometry.vcxproj" -- FALHA.
3>Projeto de compilação pronto "04-RtPipelineState.vcxproj" -- FALHA.
2>Projeto de compilação pronto "03-AccelerationStructure.vcxproj" -- FALHA.
5>Projeto de compilação pronto "07-BasicShaders.vcxproj" -- FALHA.
10>------ Compilação iniciada: Projeto: 12-PerGeometryHitShader, Configuração: Debug x64 ------
7>Projeto de compilação pronto "09-ConstantBuffer.vcxproj" -- FALHA.
4>Projeto de compilação pronto "06-Raytrace.vcxproj" -- FALHA.
6>Projeto de compilação pronto "08-Instancing.vcxproj" -- FALHA.
8>Projeto de compilação pronto "10-PerInstanceConstantBuffer.vcxproj" -- FALHA.
11>------ Compilação iniciada: Projeto: 13-SecondRayType, Configuração: Debug x64 ------
12>------ Compilação iniciada: Projeto: 14-Refit, Configuração: Debug x64 ------
13>------ Compilação iniciada: Projeto: 02-InitDXR, Configuração: Debug x64 ------
14>------ Compilação iniciada: Projeto: 05-ShaderTable, Configuração: Debug x64 ------
10>12-PerGeometryHitShader.cpp
11>13-SecondRayType.cpp
12>14-Refit.cpp
13>02-InitDXR.cpp
14>05-ShaderTable.cpp
10>c:\users\andre\source\repos\dxrtutorials\tutorials\12-pergeometryhitshader\12-pergeometryhitshader.h(36): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
11>c:\users\andre\source\repos\dxrtutorials\tutorials\13-secondraytype\13-secondraytype.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
12>c:\users\andre\source\repos\dxrtutorials\tutorials\14-refit\14-refit.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
13>c:\users\andre\source\repos\dxrtutorials\tutorials\02-initdxr\02-initdxr.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
14>c:\users\andre\source\repos\dxrtutorials\tutorials\05-shadertable\05-shadertable.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
10>Projeto de compilação pronto "12-PerGeometryHitShader.vcxproj" -- FALHA.
12>Projeto de compilação pronto "14-Refit.vcxproj" -- FALHA.
11>Projeto de compilação pronto "13-SecondRayType.vcxproj" -- FALHA.
13>Projeto de compilação pronto "02-InitDXR.vcxproj" -- FALHA.
14>Projeto de compilação pronto "05-ShaderTable.vcxproj" -- FALHA.
========== Compilar: 0 com êxito, 14 com falha, 0 atualizados, 0 ignorados ==========

I can't run second tutorial with that problem.
DxDiag.txt

1>------ Recompilação total iniciada: Projeto: 01-CreateWindow, Configuração: Release x64 ------
1>Setting user environment variable PM_PACKAGES_ROOT to C:\packman-repo
1>
1>SUCCESS: Specified value was saved.
1>Fetching [email protected] from S3 ...
1>Connecting to S3 ...
1>Downloading ...
1>Unpacking ...
1> File "C:\IntelPython3\Lib\site.py", line 177
1> file=sys.stderr)
1> ^
1>SyntaxError: invalid syntax
1>!!! Failure while configuring local machine :( !!!
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(123,5): error MSB3073: O comando "call C:\Users\andre\Source\Repos\DxrTutorials\Framework\BuildScripts\prebuild.bat C:\Users\andre\Source\Repos\DxrTutorials\.............\Framework\ C:\Users\andre\Source\Repos\DxrTutorials\ C:\Users\andre\Source\repos\DxrTutorials\Tutorials\01-CreateWindow\ x64 x64 Release C:\Users\andre\Source\Repos\DxrTutorials\Bin\x64\Release
1>C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(123,5): error MSB3073: :VCEnd" foi encerrado com o código 1.
1>Projeto de compilação pronto "01-CreateWindow.vcxproj" -- FALHA.
2>------ Recompilação total iniciada: Projeto: 03-AccelerationStructure, Configuração: Release x64 ------
3>------ Recompilação total iniciada: Projeto: 04-RtPipelineState, Configuração: Release x64 ------
4>------ Recompilação total iniciada: Projeto: 06-Raytrace, Configuração: Release x64 ------
5>------ Recompilação total iniciada: Projeto: 07-BasicShaders, Configuração: Release x64 ------
6>------ Recompilação total iniciada: Projeto: 08-Instancing, Configuração: Release x64 ------
7>------ Recompilação total iniciada: Projeto: 09-ConstantBuffer, Configuração: Release x64 ------
8>------ Recompilação total iniciada: Projeto: 10-PerInstanceConstantBuffer, Configuração: Release x64 ------
9>------ Recompilação total iniciada: Projeto: 11-SecondGeometry, Configuração: Release x64 ------
2>03-AccelerationStructure.cpp
4>06-Raytrace.cpp
7>09-ConstantBuffer.cpp
5>07-BasicShaders.cpp
3>04-RtPipelineState.cpp
2>c:\users\andre\source\repos\dxrtutorials\tutorials\03-accelerationstructure\03-AccelerationStructure.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
6>08-Instancing.cpp
9>11-SecondGeometry.cpp
4>c:\users\andre\source\repos\dxrtutorials\tutorials\06-raytrace\06-Raytrace.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
8>10-PerInstanceConstantBuffer.cpp
7>c:\users\andre\source\repos\dxrtutorials\tutorials\09-constantbuffer\09-ConstantBuffer.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
5>c:\users\andre\source\repos\dxrtutorials\tutorials\07-basicshaders\07-BasicShaders.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
2>Projeto de compilação pronto "03-AccelerationStructure.vcxproj" -- FALHA.
3>c:\users\andre\source\repos\dxrtutorials\tutorials\04-rtpipelinestate\04-RtPipelineState.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
10>------ Recompilação total iniciada: Projeto: 12-PerGeometryHitShader, Configuração: Release x64 ------
6>c:\users\andre\source\repos\dxrtutorials\tutorials\08-instancing\08-Instancing.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
9>c:\users\andre\source\repos\dxrtutorials\tutorials\11-secondgeometry\11-SecondGeometry.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
4>Projeto de compilação pronto "06-Raytrace.vcxproj" -- FALHA.
11>------ Recompilação total iniciada: Projeto: 13-SecondRayType, Configuração: Release x64 ------
5>Projeto de compilação pronto "07-BasicShaders.vcxproj" -- FALHA.
7>Projeto de compilação pronto "09-ConstantBuffer.vcxproj" -- FALHA.
12>------ Recompilação total iniciada: Projeto: 14-Refit, Configuração: Release x64 ------
13>------ Recompilação total iniciada: Projeto: 02-InitDXR, Configuração: Release x64 ------
6>Projeto de compilação pronto "08-Instancing.vcxproj" -- FALHA.
14>------ Recompilação total iniciada: Projeto: 05-ShaderTable, Configuração: Release x64 ------
9>Projeto de compilação pronto "11-SecondGeometry.vcxproj" -- FALHA.
8>c:\users\andre\source\repos\dxrtutorials\tutorials\10-perinstanceconstantbuffer\10-PerInstanceConstantBuffer.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
8>Projeto de compilação pronto "10-PerInstanceConstantBuffer.vcxproj" -- FALHA.
11>13-SecondRayType.cpp
10>12-PerGeometryHitShader.cpp
12>14-Refit.cpp
13>02-InitDXR.cpp
14>05-ShaderTable.cpp
11>c:\users\andre\source\repos\dxrtutorials\tutorials\13-secondraytype\13-SecondRayType.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
10>c:\users\andre\source\repos\dxrtutorials\tutorials\12-pergeometryhitshader\12-PerGeometryHitShader.h(36): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
3>Projeto de compilação pronto "04-RtPipelineState.vcxproj" -- FALHA.
13>c:\users\andre\source\repos\dxrtutorials\tutorials\02-initdxr\02-initDXR.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
12>c:\users\andre\source\repos\dxrtutorials\tutorials\14-refit\14-Refit.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
11>Projeto de compilação pronto "13-SecondRayType.vcxproj" -- FALHA.
10>Projeto de compilação pronto "12-PerGeometryHitShader.vcxproj" -- FALHA.
14>c:\users\andre\source\repos\dxrtutorials\tutorials\05-shadertable\05-ShaderTable.h(35): fatal error C1083: Não é possível abrir arquivo incluir: 'Falcor.h': No such file or directory
13>Projeto de compilação pronto "02-InitDXR.vcxproj" -- FALHA.
12>Projeto de compilação pronto "14-Refit.vcxproj" -- FALHA.
14>Projeto de compilação pronto "05-ShaderTable.vcxproj" -- FALHA.
========== Recompilar Tudo: 0 com êxito, 14 com falha, 0 ignorados ==========

D3DKMTOpenBundleObjectNtHandleFromName could not be located in the dynamic link library d3d12.dll

solved , my windows build version still not the latest

I have download the project and open it with VS2015 community. The other assets (i.e. freeimg dear_imgui etc.) have been downloaded.

At first ,I build it and run. VS tell me I lose some dll. I copy the assets dll to the path: DxrTutorials/Bin/x64/Debug.

Then it tell me, that:

"Can not locacte program entry point D3DKMTOpenBundleObjectNtHandleFromName in dynamic library F:\Project\DirectX12\DxrTutorials\Bin\x64\Debug\d3d12.dll"

Did i lose some files or make some mistakes?

screenshot:
MyDebugPath

trying to run the tutorials.
My adapter supports D3D_FEATURE_LEVEL_12_0 but the D3D12EnableExperimentalFeatures is causing the create device call to fail.
If I remove the D3D12EnableExperimentalFeatures the D3D12CreateDevice works fine, but then other crashes occur.

I am using a GTX 1050 TI with the latest nvidia driver and the lates windows insider update.
the recently released DXRSDK_v0.09.01 compiles and run fine for me.

Is there any special hardware requirement related to the EnableExperimentalFeatures call?

thanks,
Emanuel

Seems to build ok... but running 01-CreateWindow causes:

"The application was unable to start correctly(0xc0000007b)"

Have latest Windows build 1809 and SDK, GTX 2080 Ti, latest drivers....

These samples do not include the fallback layer, do they?
Is support for the fallback layer planned anytime soon?
If not, does it make any sense if I try to integrate it or will I likely have a bad time?

Hi,

Sorry to ask naive question, but this repository seems like simple implementation without Falcor framework, am I right?

I like these concise word documents explaining the main idea for each tutorial but IMHO the doc for the Tutorial 14 is missing a rather important note on synchronization problem when updating the TLAS resources.
The code is working properly and it has a comment explaining the changes made to the endFrame() function but for people who are following the docs files code walkthroughs it might take a while to find out why their code is not working. Therefore mentioning the problem might be really helpful.