Git Product home page Git Product logo

Comments (2)

GeraldLx avatar GeraldLx commented on July 22, 2024

That has nothing to do with ClassFixture or NSubstitute.

Your test is just wrong.

By using the ClassFixture you have only one instance of your substitute for both tests.

So your first tests sets up the substitute´s Validate function to return true AND calls CheckIfNumberExists. This of course leads to ca call of Exists.

Then your second test runs. You change the Validate to return false AND call CheckIfNumerExists a second time. This of course leads to no call of Exists.

But then you check the number of calls to Exists. Of course the number of calls is 1 if you run both tests. But you expect it to be zero. Therefore the 2nd test fails.

Just change your test like this:

public class Tests
{
  private readonly Fixture _fixture;

  public Tests()
  {
    _fixture = new Fixture();
  }

  //1.
  [Fact]
  public void ExistsIsCalledWhenValidationIsSuccessful()
  {
    //first we make sure that Validate() passes so that Exists() gets called
    _fixture.SharedSubstitute
      .Validate(Arg.Any<int>())
      .Returns(true);

    //act:
    _fixture.App.CheckIfNumberExists(1);

    //then we test that the substitute received a call to Exists() 
    _fixture.SharedSubstitute.Received().Exists(Arg.Any<int>());
  }

  //2.
  [Fact]
  public void ExistsIsNotCalledWhenValidationFails()
  {
    //now we pretend that Validate() fails, i.e. returns false.
    _fixture.SharedSubstitute
      .Validate(Arg.Any<int>())
      .Returns(false);

    //act:
    _fixture.App.CheckIfNumberExists(1);

    //we shouldn't expect a call to Exists()
    _fixture.SharedSubstitute.DidNotReceive().Exists(Arg.Any<int>());
  }
}

and it works, regardless of running both or only one test.

But what you experienced in your version is just by design

from nsubstitute.

urnie avatar urnie commented on July 22, 2024

That makes total sense, looks like I failed to consider that. Thanks for the response!

from nsubstitute.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.