Comments (3)
Hi @BenjaminAbt ,
Sorry for the delayed response.
If you have the time would you be happy to send your branch as a PR?
A few notes on the existing commit:
- I'd prefer to avoid
ReceiveAtLeast
. We already dump so much into intellisense with extension methods on Object and I'd prefer not to exacerbate the problem. 😅 - I think we only call
Quantity.Matches
with aList
, soCount()
would probably end up being more efficient than something like.Take(minInclusive).Count()
for this case. Any thoughts on whether we should changeMatches
to take a list to make this more obvious? - Did you want to add any of
AtMost
,LessThan
,MoreThan
as well? - Existing problem, but if you do send through a PR would you also be able to add code docs to the public members of
Quantity
that are currently missing doc comments?
As per @304NotModified's reply, if you have other specific examples please create an issue/s for them. 👍
from nsubstitute.
I like the idea here, but IMO this GitHub issue is very broad and therefore hard to fix.
people no longer had to google workarounds.
I don't know what this exactly means, other than the given examples
from nsubstitute.
I like the idea here, but IMO this GitHub issue is very broad and therefore hard to fix.
Yes, that was the intention. I wanted to find out what the general attitude was before I put more time into it; also because there have been statements about it in the past (see above).
If you have the time would you be happy to send your branch as a PR?
For sure.
I'd prefer to avoid ReceiveAtLeast. We already dump so much into intellisense with extension methods on Object and I'd prefer not to exacerbate the problem.
Yes, I understand this, but I see devs struggling. IntelliSense is just normal in our .NET / Visual Studio ecosystem, and I just see developers browsing IntellISense instead of people looking at the docs. It's not a one-off thing either, I see it consistently.
Did you want to add any of AtMost, LessThan, MoreThan as well?
Sounds good.
Existing problem, but if you do send through a PR would you also be able to add code docs to the public members of Quantity that are currently missing doc comments?
Yes.
I don't know what this exactly means, other than the given examples
There is one thing I do differently now and recommend to other people: use CHatGPT instead of GitHub Copilot to migrate from Moq to NSubstite.
The results are better and people need less help with things they can't find the equivalent for.
GitHub Copilot has sometimes suggested things for NSubstite that correspond to Moq's API - of course that doesn't work because they dont exist.
from nsubstitute.
Related Issues (20)
- Proposition: Mark as unlisted and Deprecated some old versions HOT 4
- Library is not compatible with .NET MAUI 8.0.6 HOT 4
- How can I pass event args to event with Func<TEventArgs, Task>? HOT 2
- Add ability to capture and verify on an argument at the same time HOT 1
- NSubstitute.Exceptions.SubstituteInternalException HOT 1
- IMemoryCache TryGetValue mocking not working HOT 2
- Unable to match arguments whose type is generic, when their concrete type is not known HOT 1
- Arg.Any<Arg.AnyType>() does not match arguments passed by reference
- Provide a way to pass null for custom event args so that Raise.EventWith can be used to raise events for custom event args without a default constructor
- I can't test code that has dbcontext.SomeEntity.SingleOrDefault() HOT 2
- I'm receiving NSubstitute.Exceptions.NotASubstituteException when I shouldn't HOT 3
- Need to release 5.2.0 HOT 6
- Configured calls to 'hidden' properties are not matched HOT 2
- Improve output for expected argument for custom argument matchers on non-match or make it customizable HOT 8
- Open issues that could be closed? HOT 8
- Ability to mock requests from Protected methods in sequences HOT 1
- Proposal: Replace Google groups with GitHub discussions HOT 7
- .When(...).Throws gives a CouldNotSetReturnDueToNoLastCallException HOT 1
- ReceivedCallsException despite the expected and actual calls being identical. HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nsubstitute.