Git Product home page Git Product logo

Comments (3)

dtchepak avatar dtchepak commented on May 26, 2024 1

Hi @BenjaminAbt ,

Sorry for the delayed response.
If you have the time would you be happy to send your branch as a PR?

A few notes on the existing commit:

  • I'd prefer to avoid ReceiveAtLeast. We already dump so much into intellisense with extension methods on Object and I'd prefer not to exacerbate the problem. 😅
  • I think we only call Quantity.Matches with a List, so Count() would probably end up being more efficient than something like .Take(minInclusive).Count() for this case. Any thoughts on whether we should change Matches to take a list to make this more obvious?
  • Did you want to add any of AtMost, LessThan, MoreThan as well?
  • Existing problem, but if you do send through a PR would you also be able to add code docs to the public members of Quantity that are currently missing doc comments?

As per @304NotModified's reply, if you have other specific examples please create an issue/s for them. 👍

from nsubstitute.

304NotModified avatar 304NotModified commented on May 26, 2024

I like the idea here, but IMO this GitHub issue is very broad and therefore hard to fix.

people no longer had to google workarounds.

I don't know what this exactly means, other than the given examples

from nsubstitute.

BenjaminAbt avatar BenjaminAbt commented on May 26, 2024

I like the idea here, but IMO this GitHub issue is very broad and therefore hard to fix.

Yes, that was the intention. I wanted to find out what the general attitude was before I put more time into it; also because there have been statements about it in the past (see above).

If you have the time would you be happy to send your branch as a PR?

For sure.

I'd prefer to avoid ReceiveAtLeast. We already dump so much into intellisense with extension methods on Object and I'd prefer not to exacerbate the problem.

Yes, I understand this, but I see devs struggling. IntelliSense is just normal in our .NET / Visual Studio ecosystem, and I just see developers browsing IntellISense instead of people looking at the docs. It's not a one-off thing either, I see it consistently.

Did you want to add any of AtMost, LessThan, MoreThan as well?

Sounds good.

Existing problem, but if you do send through a PR would you also be able to add code docs to the public members of Quantity that are currently missing doc comments?

Yes.

I don't know what this exactly means, other than the given examples

There is one thing I do differently now and recommend to other people: use CHatGPT instead of GitHub Copilot to migrate from Moq to NSubstite.

The results are better and people need less help with things they can't find the equivalent for.
GitHub Copilot has sometimes suggested things for NSubstite that correspond to Moq's API - of course that doesn't work because they dont exist.

from nsubstitute.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.