Comments (8)
That'd be awesome! I've sent you an invite with access to manage issues and PRs if you would like to do that? (if you prefer a different approach please let me know.)
The only rule we've had for managing this stuff is we try to stay disgustingly polite with all our responses. π€£ If you think something can be closed but aren't sure you're welcome to close with something like "Please re-open if you need further information or would like us to take another look at this."
Thanks very much for your help! β€οΈ
from nsubstitute.
Please ask me the same question in 3 months. :) Currently I don't have enough insights of this great library to (final) review PRs.
Understood. π Please let me know if you want to take this on at a later date. From your work with NLog I think you're more than qualified.
Really appreciate your contributions so far; I'm happy even if you prefer to stick to contributing in that capacity without ever taking on reviews.
Quick clarification: I'm not after reviews on in-depth changes or giving final approval to PRs from external contributors (I'm happy to review and approve those), more that I need someone to review changes I make like the release build change when other core team members aren't available (I can't approve those myself haha).
First a long holiday soon
Enjoy! Have a safe and relaxing holiday.
from nsubstitute.
The only rule we've had for managing this stuff is we try to stay disgustingly polite with all our responses.
I find this also very important! :)
Maybe we should add a code of conduct for this?
For example: https://github.com/NLog/NLog/blob/dev/CODE_OF_CONDUCT.md
from nsubstitute.
@dtchepak I will also tag some GitHub issues to make it more clear. If I made some mistakes, feel free to change the tags
from nsubstitute.
I'd be happy to add a code of conduct. My only concern is around enforcement. My response times aren't great at the moment and I don't want to mislead people that I'll always be able to effectively deal with transgressions in a timely way.
Would it be acceptable to adopt parts of the Contributor Covenant Code of Conduct? The "Our Pledge" and "Our Standards" sections I think are perfect, then maybe we could have something like this:
Reporting and Enforcement
We reserve the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. If you feel this has been done in error you can contact [INSERT CONTACT METHOD].Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to [INSERT CONTACT METHOD]. We will respect the privacy and security of the reporter of any incident, and will work with the reporter to handle the incident in an appropriate manner.
(Will need to setup an appropriate reporting channel; not sure if we can email @nsubstitute/admins or a new group/team for this?)
Then can include "Attribution".
Actually just saw that earlier versions probably align more closely with how we would likely be able to deal with violations. E.g. version 1.2.0
WDYT?
from nsubstitute.
I'd be happy to add a code of conduct. My only concern is around enforcement. My response times aren't great at the moment and I don't want to mislead people that I'll always be able to effectively deal with transgressions in a timely way.
Would it be acceptable to adopt parts of the Contributor Covenant Code of Conduct? The "Our Pledge" and "Our Standards" sections I think are perfect, then maybe we could have something like this:
I understand, that would be more than acceptable for me :)
(Will need to setup an appropriate reporting channel; not sure if we can email @nsubstitute/admins or a new group/team for this?)
I'm not sure about this.
Actually just saw that earlier versions probably align more closely with how we would likely be able to deal with violations. E.g. version 1.2.0
That's also fine to me :)
from nsubstitute.
Hi @304NotModified ,
I really appreciate your work in sorting through all these issues! Would you be open to joining the contributers team? It would be great to get another person able to help with merging PRs.
No obligations in terms of amount of involvement or anything -- can be as little or as much as you like.
You are welcome to email [email protected] if you have any questions. π
from nsubstitute.
Hi @304NotModified ,
I really appreciate your work in sorting through all these issues! Would you be open to joining the contributers team? It would be great to get another person able to help with merging PRs.
No obligations in terms of amount of involvement or anything -- can be as little or as much as you like.
You are welcome to email [email protected] if you have any questions. π
Please ask me the same question in 3 months. :)
Currently I don't have enough insights of this great library to (final) review PRs.
First a long holiday soon and than I will try to dig deep in the code
from nsubstitute.
Related Issues (20)
- I can't test code that has dbcontext.SomeEntity.SingleOrDefault() HOT 2
- I'm receiving NSubstitute.Exceptions.NotASubstituteException when I shouldn't HOT 3
- Need to release 5.2.0 HOT 8
- Configured calls to 'hidden' properties are not matched HOT 2
- Improve output for expected argument for custom argument matchers on non-match or make it customizable HOT 8
- Ability to mock requests from Protected methods in sequences HOT 1
- Proposal: Replace Google groups with GitHub discussions HOT 7
- .When(...).Throws gives a CouldNotSetReturnDueToNoLastCallException HOT 1
- ReceivedCallsException despite the expected and actual calls being identical. HOT 4
- GetArguments is returning the latest call for all calls if we're using the same reference type HOT 3
- Uncommented code causes unrelated test to pass (NSubstitute version: 4.18.1) HOT 2
- Received calls method a second time. HOT 2
- Clear configured call HOT 3
- Proposal: Change Arg.Is(Expression<Predicate<T>>) to Arg.Is(Predicate<T>) HOT 1
- Precompile error during Received assertion HOT 3
- When..Do - versatile way of configuring substitutes using delegates
- Received() did not recognize call that certainly was performed correctly HOT 1
- How to tell if a method/property has been substituted/configured?
- Argument matchers fail if null passed in to an out parameter of a generic derived type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nsubstitute.