Comments (6)
@joyeecheung yup. We could definitely do that to flag the commits. We would need a bot that could poll for labels, land the commits, and push upstream.
TBQH at that point the landing of the commit isn't the biggest deal... it is more about the review of what should / shouldn't land. Although in thinking about it, if the process of landing the commit was abstracted from the review process it would likely be easier to onboard more reviewers, and potentially inspire folks to review their own PRs.
We would likely still need to audit the backlog of un labelled issues... but perhaps it would be easier to inspire people to label if it were an automated process...
from automation.
So, I've used https://github.com/evanlucas/node-backport for the past few releases I've done, and it sure makes things easier. Warning: It's pretty raw at this point though.
from automation.
IIUC correctly, right now we just backport every PR that has suitable semver labels? Or do lts-watch-x
labels do the job?
from automation.
@joyeecheung currently I use branch diff to generate a list of commits with a command line
branch-diff v6.x-staging upstream/v8.x --exclude-label semver-major,semver-minor,dont-land-on-v6.x,backport-requested-v6.x,backported-to-v6.x,baking-for-lts --filter-release
and then manually review every commit. The labels are all manual too 😅
from automation.
@MylesBorins OK I think I get what you meant now, including certain labels instead of excluding? Yes right now that looks like too much manual pings.
from automation.
We've already done lots of related work in the github bot, trying to backport PRs and add different labels: nodejs/github-bot/scripts/attempt-backport.js.
Initially it also added dont-land-on-*
labels which got disabled after lots of discussions (nodejs/github-bot/acd5bc).
I assume it something similar you're suggesting @MylesBorins with the addition of actually pushing changes to git branches?
from automation.
Related Issues (20)
- Should Automation take ownership of make-node-meeting? HOT 6
- What about a related project for @nodejs/automation projects utils? HOT 19
- Proposing to form a monorepo HOT 14
- Can we automate appending changelogs to a release HOT 3
- Side effect: Working with Build WG to change description on Nodejs.org ? HOT 9
- CitGM testing Node-Core-Utils? HOT 10
- Include collaborators/team members in the README? HOT 8
- Idea: A twitter bot to thank new contributors HOT 4
- An app for managing bans HOT 8
- greenkeeper-like feature for ncu-team HOT 5
- Use ncu-team in create-node-meeting-artifacts HOT 1
- avoid CI typos HOT 6
- Tool for generating/maintaining/auditing CODEOWNER file HOT 12
- doc REPLACEME linter/fixer HOT 3
- Commit Queue HOT 8
- explore k8s prow as a way to automate stuff in github HOT 4
- Github team management (reply here if you want to join) HOT 33
- Node.js clone repo for testing HOT 6
- Brigade HOT 3
- Repo and npm accesses of related projects HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from automation.