Comments (12)
For instance, ncu could include a git command that uses the CODEOWNERS file to identify who would be notified for any given set of commits.
I am curious, which commands could use that?
I thought about something for the release team to find proper backporters but have not reached the point where I can start writing code yet, but the owners specified by the CODEOWNERS file seems to be too broad in that case, at least not better than the "reviewer + author" group.
from automation.
@jasnell can you point to any doc or the existing CODEOWNERS files? I touch a quick look in the src directory but I did not see it.
from automation.
https://github.com/nodejs/node/blob/master/.github/CODEOWNERS
from automation.
@BridgeAR thanks !
from automation.
Currently, the CODEOWNERS
file is of limited value because it will only do automatic notifications if the team or individuals have write access in the repository. Since most o our teams include people who do not have write access, GitHub does not automatically process the notifications. This makes me sad.
We could augment that by having the Github bot automatically do those notifications for us based on CODEOWNERS
file. It's a stop gap measure, but a useful one.
Another idea would be having git node land
use the CODEOWNERS
file to determine if anyone from the owning teams has reviewed the PR in question. That would, of course, require the git nod land
tool to know who is on each team, but, for instance, if the PR changes http2
and no one from the nodejs/http2
has reviewed, then the landing tool can emit a warning.
from automation.
@jasnell Maybe we should replace the teams in CODEOWNERS with teams that have write access? Otherwise it does not seem to be useful to have them anyway.
from automation.
By the way ncu already has code (for ncu-team
) to know about members in teams and requires necessary access when creating tokens.
from automation.
I was wondering. If we're overriding GitHub, then we already have the bot doing it's black magic for tags. IMHO we should reuse that for @
mentioning teams.
from automation.
Along the lines of what @refack mentioned, would it be easier, for now, to avoid CODEOWNERS and handle all of this in github-bot
? It already matches file paths to add labels to PRs, in theory we could do the same thing but just match to the relevant team(s) to ping. For example, if a PR edits http2 code (it will currently get the http2 label), and we could request a review from the http2 GitHub team.
from automation.
So my only question there is how we would best manage those mappings in the GitHub bot. Otherwise tho, I'm perfectly fine with that approach so long as it works :)
from automation.
I think we just need to make sure that the labels match the team names?
from automation.
Unarchived this repo so I could close all the PRs and issues. Will re-archive when I'm done.
from automation.
Related Issues (20)
- Should Automation take ownership of make-node-meeting? HOT 6
- What about a related project for @nodejs/automation projects utils? HOT 19
- Proposing to form a monorepo HOT 14
- Can we automate appending changelogs to a release HOT 3
- Side effect: Working with Build WG to change description on Nodejs.org ? HOT 9
- CitGM testing Node-Core-Utils? HOT 10
- Include collaborators/team members in the README? HOT 8
- Idea: A twitter bot to thank new contributors HOT 4
- An app for managing bans HOT 8
- greenkeeper-like feature for ncu-team HOT 5
- Use ncu-team in create-node-meeting-artifacts HOT 1
- avoid CI typos HOT 6
- doc REPLACEME linter/fixer HOT 3
- Commit Queue HOT 8
- explore k8s prow as a way to automate stuff in github HOT 4
- Github team management (reply here if you want to join) HOT 33
- Node.js clone repo for testing HOT 6
- Brigade HOT 3
- Repo and npm accesses of related projects HOT 13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from automation.