CitGM testing Node-Core-Utils? about automation HOT 10 CLOSED

The point of CitGM is to test that new changes in node-core do not break userland packages. I'm not sure if ATM this tool does anything fragile, but even if it's still straight forward the cost of adding ti to CitGM is low. Just read https://github.com/nodejs/citgm/blob/master/CONTRIBUTING.md#submitting-a-module-to-citgm and open a PR similar to nodejs/citgm#475

from automation.

I'd say let's just skip LTS and go with current, considering most of its users should have master build on their machines already.

from automation.

Also I am a bit confused, does the OP mean we add node-core-utils to citgm's lookup.json?

from automation.

That's a fair point. As I don't know if there are many backporting PRs, testing against previous versions may not be relevant.

For the record, adding Node-core-utils to the lookup.json wasn't my intention at first. More like using citgm on our side in our test suite if it was possible.
Dumb idea, sorry!

from automation.

@Tiriel Do you mean we should test node-core-utils against different releases? I think we can just add new entries to travis or appveryor configs for that?

from automation.

Indeed we can, that was more to enable testing before pushing. But it's indeed not relevant in fact.

from automation.

Closing as it's irrelevant :)

from automation.

@joyeecheung I'll leave it to you to decide if we should reopen the issue or not, or make a PR to citgm or not.

In any case, I'm willing to do it, if everyone thinks it's a good idea

from automation.

@Tiriel If the CIGTM team thinks it's a good idea then I am all for it (which reminds me we need to put an "engines" field in our package.json and skip lower versions of Node). Do you want to open a PR in the citgm repo?

from automation.

@joyeecheung No problem! Thanks!

from automation.