nmoehrle / libacc Goto Github PK

I will need the barycentric coordinates of the hit point in closest_point. I think of creating some Hit like struct with triangle id, 3D point, barycentric point and possibly distance as well or maybe a pair<Vec3fType, Hit>. What type would you prefer and do I need to care about the API in the develop branch or is it not used, yet?

While you're using a template argument for the vector format, you have quite concrete requirements on the vector (i.e. it needs to implement dot and cross product), without having an example implementation in the repository.
This makes it hard to actually use it in such a generic way (you would for example expect to be able to use std::vector, std::valarray, double[3] for a real generic structure).

But your expected structure works quite fine with libeigen Eigen::Vector3f, if you change a few things:

• change squared_norm to squaredNorm
• change Vec3fType(inf) to Vec3fType(inf, inf, inf) everywhere.

Another thing is, that you might consider to make float a template, so data structures using doubles can be used as well (i.e. Eigen::Vector3d).

I get an out of bounds error at bvh_tree.h#L267, with node.last == indices.size().

I guess this is a off by one error coming from somewhere else, but I do not see from where.

Currently I implemented a workaround to set node.last to indices.size()-1 when its bigger, but I am not sure if this only changes the structure of the bounding volumes or if it changes the result.

I got another index error in bvh_tree.h#L181

min = -5.00958252
max = -5.00958014
d = 0
mid(aabb, d) - min = 2.4516127083984429e-06
((mid(aabb, d) - min) / (max - min)) * (NUM_BINS - 1) = 64.781696632504463
idx = 64
NUM_BINS = 64
aabb.min = (-5.0095801960014716, 0.63644947007425456, 0.041062743939970059)
aabb.max = (-5.0095799398356107, 0.64464411815625533, 0.054988806854231520)

Hello,

I am working on wrapping libacc for Julia, as it is quite a bit faster than whatever I have been able to come up with. (Also, I wanted to learn how to wrapp C++ packages).

Now I have a basic wrapper working, and I am thinking about making it available to everyone. It compiles against libacc, but I also copied the vector.h and algos.h files from the MVE project you linked in #3.

I wanted to ask what kind of licensing would work for you. I have your code in a separate folder with the License.txt file from the MVE repository. Would that work for you? I am not yet sure about the License of my code, but this is in total only about 60 lines of code, so not that significant.

I also would like to give some credit in the description. I read the license as requiring me to ask you, so would it be fine for you, if I referenced this repo in the Readme and description of the wrapper repository?

Thanks for the cool library and all the best
Paul