Switch to "ANSI C" style function declarations about neovim HOT 16 CLOSED

Thank you! A modern Vim should be written in a modern C.

from neovim.

I'd like to contribute and this seems like a pretty easy way to get started. Is this something that is done by hand, file by file? Should Gaelan and I coordinate to make sure we don't edit the same files?

This is my first time contributing to an OS project. Help me to help you!

from neovim.

@iamjboyd Thank you so much! As far as I can tell, the best way to do is to do it by hand, unfortunately. There is a script that will automate it, but it is not very smart about things like comments on the old-style declarations, so even if we used it, we would have to fix it by hand afterward. If you would like to help out, let me know and I can add you as a collaborator on the fork.

Welcome to the OSS community!

from neovim.

I'd just like to throw out that I'm also entirely open to help with this simple bit. (Good excuse to get familiar with the new style).

EDIT: Damn, I didn't realize how old Vim was.

from neovim.

@Tamul @iamjboyd I added you both to the fork, so you can help out. Please comment before you start on a file, so that we don't waste effort on the same file.

from neovim.

I'm going to do digraph.c.

from neovim.

Also, please try and compile on your own machine before pushing instead of using Travis, so we can avoid "fixup" commits.

from neovim.

OK!

I'll take os_unix.c

Some function calls have the following syntax:

long_u mch_total_mem(special)
int special UNUSED; 

I'm guessing UNUSED is to eliminate compiler warnings. Anything special need to be done for the "UNUSED"s?

from neovim.

As far as I can tell, all you need to do is put it after the variable name in the prototype, basically in the same place it is now. Thanks!

from neovim.

I've created a table to keep track of who has done what:

Last Updated 2/23/2014 4:56 US Central Time

from neovim.

Thanks! However, I've done and pushed arabic.c through digraph.c, so those should be marked as pushed.

from neovim.

OK, I'll go ahead and update.

from neovim.

Should this be compartmentalized in Gaelan’s repo? To me at least, it would make sense to make an issue for each file, or categories of files, and then one of us can assign ourselves to the issue. This makes sure no two people are working on the same file.

from neovim.

Looks like someone used cproto (which I hadn't heard of before) to automate it it in #91, so I say we just fix the two files that cproto botched, then call it good.

from neovim.

Sounds good to me. Not going to argue if it works, and makes much less work.

from neovim.

closed by #91

from neovim.