Problem When there is an ext mark with virtual lines outside of th

This seems to be missing a pair of parentheses: <div class="highlight highlight-so

Backtrace: <div class="snippet-clipboard-content notranslate position-relative ove

`decor_virt_lines` fails on scroll when there are virt_lines outside the viewport about neovim HOT 2 CLOSED

lukas-reineke commented on June 12, 2024

`decor_virt_lines` fails on scroll when there are virt_lines outside the viewport

from neovim.

Comments (2)

zeertzjq commented on June 12, 2024 1

This seems to be missing a pair of parentheses:

diff --git a/src/nvim/move.c b/src/nvim/move.c
index c055f6baa..4448091b8 100644
--- a/src/nvim/move.c
+++ b/src/nvim/move.c
@@ -2362,7 +2362,7 @@ static int get_scroll_overlap(Direction dir)
   }
 
   loff.lnum = dir == FORWARD ? curwin->w_botline : curwin->w_topline - 1;
-  loff.fill = win_get_fill(curwin, loff.lnum + dir == BACKWARD)
+  loff.fill = win_get_fill(curwin, loff.lnum + (dir == BACKWARD))
               - (dir == FORWARD ? curwin->w_filler_rows : curwin->w_topfill);
   loff.height = loff.fill > 0 ? 1 : plines_win_nofill(curwin, loff.lnum, true);

from neovim.

zeertzjq commented on June 12, 2024

Backtrace:

#0  0x00007ffff7cfe32c in ?? () from /usr/lib/libc.so.6
#1  0x00007ffff7cad6c8 in raise () from /usr/lib/libc.so.6
#2  0x00007ffff7c954b8 in abort () from /usr/lib/libc.so.6
#3  0x00007ffff7c953dc in ?? () from /usr/lib/libc.so.6
#4  0x00007ffff7ca5d46 in __assert_fail () from /usr/lib/libc.so.6
#5  0x000055555669f9de in decor_virt_lines (wp=0x526000000100, lnum=0, lines=0x0, has_fold=kNone) at **/src/nvim/decoration.c:891
#6  0x0000555557395e6c in win_get_fill (wp=0x526000000100, lnum=0) at **/src/nvim/plines.c:700
#7  0x00005555571384c4 in get_scroll_overlap (dir=FORWARD) at **/src/nvim/move.c:2365
#8  0x00005555571364e7 in pagescroll (dir=FORWARD, count=1, half=false) at **/src/nvim/move.c:2503
#9  0x000055555718d361 in nv_page (cap=0x7ffff5e04690) at **/src/nvim/normal.c:2269
#10 0x000055555718c426 in normal_execute (state=0x7ffff5e04620, key=6) at **/src/nvim/normal.c:1229
#11 0x00005555577ade2a in state_enter (s=0x7ffff5e04620) at **/src/nvim/state.c:101
#12 0x000055555716a4cb in normal_enter (cmdwin=false, noexmode=false) at **/src/nvim/normal.c:518
#13 0x0000555556e9376a in main (argc=3, argv=0x7fffffffe118) at **/src/nvim/main.c:663

from neovim.

Recommend Projects