Git Product home page Git Product logo

Comments (5)

zeertzjq avatar zeertzjq commented on June 3, 2024 1

Note: if this is supported, it's also necessary to prevent nvim_win_set_config from moving autocmd window into another tabpage.

from neovim.

luukvbaal avatar luukvbaal commented on June 3, 2024

I think the expectation here is wrong. win is not the target window that will be made floating, but rather the window where the newly opened float's position will be relative to.
Supplying a win from a different tabpage with relative == 'win' should probably be an error.

from neovim.

asmodeus812 avatar asmodeus812 commented on June 3, 2024

I never implied that the passed in win is the one to be made floating. What the relative to win implies to me is that the newly created floating window by the api will be rendrred and anchored / relative to the target win. However, the target win is not in the current tab page, so either the correct tabpahe layout has to be modified to correctly reflect and render the floating window or error out.

from neovim.

luukvbaal avatar luukvbaal commented on June 3, 2024

OK fair I interpreted incorrectly. But yeah the issue is not that the relative float is rendered on the wrong tab page, but rather that the API does not support opening a float on a non-current tabpage, and unexpectedly does not give an error with a relative window from a different tabpage.

from neovim.

willothy avatar willothy commented on June 3, 2024

Supplying a win from a different tabpage with relative == 'win' should probably be an error.

Imo this should only be an error in the short-term if at all. I think the expectation to be able to open windows in non-current tabpages is reasonable and should be supported if possible. Splits should already support this since #25550, I'll have to check again, but maybe I can look into getting that working for floats as well.

from neovim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.