nemosupremo / gifdrawable-android Goto Github PK

Thanks for that have done a good job. However, using the code from the example as is visible rendering artifacts when playing a GIF. Like as:
http://www.youtube.com/watch?v=DjKI9b8jBMw&feature=youtu.be.
I would be grateful if you shared their ideas about the cause and how to fix it.

I try to play this gif:
https://www.dropbox.com/s/xjzrhrtfnx0712x/2013-05-08%2011.23.06.gif

Loading two gifs from the asset directory will cause undefined behavior.

Fix:
libgifdrawable.c @ c58e2ec
Line 45:

typedef struct GifAnimInfo {
  int duration;
  int current_frame;
+   int fd;
+   int bytesLeft;
} GifAnimInfo;

- int fd, bytesLeft;

Line 254:

static int readFunc(GifFileType* gif, GifByteType* bytes, int size)
{
+  int szRead = read(((GifAnimInfo *)gif->UserData)->fd, bytes, MIN(size, ((GifAnimInfo *)gif->UserData)->bytesLeft));
+  ((GifAnimInfo *)gif->UserData)->bytesLeft -= szRead;
  return szRead;
}

Line 273:

+GifAnimInfo * gif_info = malloc(sizeof(GifAnimInfo));
+gif_info->fd = fd;
+gif_info-> bytesLeft = bytesLeft;
+GifFileType* gif = DGifOpen((void *)gif_info,&readFunc,&error);
error = DGifSlurp(gif);

I tried loading the following GIF using the latest version of your library:

Sadly, it causes the app to crash... Any ideas what might be wrong with it?

Suddenly, playback is interrupted and goes to the beginning.
This occurs in the same animation on the same place.
As sample this gif: