I assume this isn't updated anymore but I've been messing with this and I can't seem to get the bloom shader to work, but all the other shaders work.

Nothing happens at all when it's enabled as far as I can tell.

I am using 0.9.0.

Could you provide getters for the postprocessing width and height ?

In a project I'm working on, my team found out that if the window is resized, the scene rendering (and thus postprocessing) stays within the original size of the window, the scene doesn't fill all the new space. ofxPostProcessing seems to be the culprit.

We found an easy fix : having a variable ofxPostProcessing post in the app, we found that setting post.width = windowWidth; and post.height = windowHeight; in the OF windowResized function does the trick.

However, these attributes are private and we had to tweak PostProcessing.h in the addon to make them public (that's ugly). I was a little astounded there was no getters for that.

Thank you for the awesome work 👍

EDIT : sorry that's an non-issue, I just checked the most up-to-date version and they are here. I guess we used an old version...

pixelatePass needs setter and getter functions - I have added some to my fork of this

Why could it be that with the SSAO filter I get just a black screen? I tried playing with the uniforms but still nothing.

Other filters like DOF and Bloom work fine.

I'm not able to render effects, for example text, with a transparent background, is this designed by choice, or is there any problem?

trying to compile i get this Use of undeclared identifier 'ofFboBeginMode'

Hello Neil, thanks for your addon. Some fixes to get it working with 10.1:
this
raw.begin(ofFboBeginMode::NoDefaults);
In PostProcessing.cpp no longer works. It needs to be:
raw.begin(OF_FBOMODE_NODEFAULTS);

And in RenderPass.h these two lines are needed.

#include "ofMain.h"
using namespace std;

After these small changes it works. Tell me if it is better to open a PR.
bye ;)

Make all fx parameters ofParameters and have and public ofParameterGroup that can be queried for each one.

I'm attempting to use an unmodified fork for your ofxPostProcessing addon with video and for some reason when I add the post-processing transformation the video is vertically mirrored. Here's the code I'm using in my testApp.cpp.

#include "testApp.h"

//--------------------------------------------------------------
void testApp::setup(){

    camWidth        = ofGetWidth(); // try to grab at this size.
    camHeight       = ofGetHeight();

    // set up video grabber
    vidGrabber.setDeviceID(0);
    vidGrabber.setDesiredFrameRate(24);
    vidGrabber.initGrabber(camWidth,camHeight);

    // set up shader post-processing
    post.init(camWidth, camHeight);
    post.createPass<RimHighlightingPass>()->setEnabled(true);
}

//--------------------------------------------------------------
void testApp::update(){

    ofBackground(100,100,100);
    vidGrabber.update();
}

//--------------------------------------------------------------
void testApp::draw(){

    // copy enable part of gl state
    glPushAttrib(GL_ENABLE_BIT);

    // setup gl state
    glEnable(GL_DEPTH_TEST);
    glEnable(GL_CULL_FACE);


    // begin scene to post process
    post.begin();

    vidGrabber.draw(0,0);

    // end scene and draw
    post.end();

    // set gl state back to original
    glPopAttrib();
}

This commit uses ofFboBeginMode, an enum which isn't introduced in the latest OF public versioned release. That means end users have to be working off the development branch, and many newcomers to OF will download your addon only to find it doesn't compile.

I just thought I should point that out, I'm not sure what you could do about it. Maybe put the dev version stuff in a dev branch, or add a note to the readme that this addon is for advanced users only..?

can't run the example:

error: use of undeclared identifier 'ofFboBeginMode'

It used to run flawless until some latest modifications. Example doesn't run here either.

Thank you

I got this error when compiling on xcode, of10.1
Implicit instantiation of undefined template 'std::__1::basic_ostringstream<char, std::__1::char_traits<char>, std::__1::allocator<char> >'

This seems to be present others file.

Hi there,
I'd love to use the noiseWarpPass and be able to tweak the parameters. Everything seems to be there in the class but I can't seem to figure out how to access e.g. setFrequency and getFrequency. I tried to call them statically and I tried new'ing an object but no luck. If you could write an example including how to use createPass the parameters of noiseWarpPass I would be very grateful...

The effects seem to work, though some of them are subtle (like BleachBypassPass) so I'm not sure if they're being affected by the warning messages I'm getting:

[warning] ofShader: GL_FRAGMENT_SHADER, offending line 1 : 1 uniform float opacity; uniform sampler2D tDiffuse; void main() { vec2 vUv = gl_TexCoord[0].st; vec4 base = texture2D( tDiffuse, vUv ); vec3 lumCoeff = vec3( 0.25, 0.65, 0.1 ); float lum = dot( lumCoeff, base.rgb ); vec3 blend = vec3( lum ); float L = min( 1.0, max( 0.0, 10.0 * ( lum - 0.45 ) ) ); vec3 result1 = 2.0 * base.rgb * blend; vec3 result2 = 1.0 - 2.0 * ( 1.0 - blend ) * ( 1.0 - base.rgb ); vec3 newColor = mix( result1, result2, L ); float A2 = opacity * base.a; vec3 mixRGB = A2 * newColor.rgb; mixRGB += ( ( 1.0 - A2 ) * base.rgb ); gl_FragColor = vec4( mixRGB, base.a ); }

Using Visual Studio 2019 on Windows 10. Tried replacing ofSetupOpenGL(1024,768,OF_WINDOW); with

ofGLWindowSettings settings;
	settings.setGLVersion(3, 2);
	ofCreateWindow(settings);

because I was told to do this in other tutorial videos when using shaders, but this turns the warning into an error and nothing is displayed.

Everything is ok in of 0.98 but with 0.10.0 i have errors

ps: thank you for this great addons!

fixed by changing the header for DofAltPass

namespace itg
{
    /*
     * @see http://blenderartists.org/forum/showthread.php?237488-GLSL-depth-of-field-with-bokeh-v2-4-(update)
     */
    using namespace tr1;
    class DofAltPass : public RenderPass
    {
    public:
        typedef shared_ptr<DofAltPass> Ptr;
       ...

hey, thanks for this addon. I'm wondering what kind of license you're publishing this in...? I've been using it tons of times and would like to once know for sure what your opinion about this is..

thanks already :)

yours,
marcel

hi, I loaded a .cube LUT and it works.
But I must hardcode the path into the addon class like this:

    LUTPass::LUTPass(const ofVec2f& aspect, bool arb) : RenderPass(aspect, arb, "lut"), lut_tex(0)
    {
		loadLUT("6.cube");
    } 

It's possible to load LUTs on the fly? Any idea?

is it possible to add toon shade pass?
thanks