neildarlow / marlin Goto Github PK

That definition

#define analogInputToDigitalPin(p)  ((p < NUM_ANALOG_INPUTS) ? (p) + 24 : -1)

can be found in

• Marlin / ArduinoAddons / Arduino_1.x.x / hardware / Sanguino / variants / standard / pins_arduino.h:113
• Marlin / ArduinoAddons / Arduino_1.x.x / hardware / Melzi / variants / standard / pins_arduino.h:113

The wrong definition prohibits setting Pin Ext A1 on the extension connector via M42 P30 Snnn. That pin is connected to Port A1, which is Analog Pin 1, Digital Pin 30. The wrong definition maps AI6 (used for the bed temp sensor) to D30 (24+6=30) which in turn rejects M42 P30. It should map AI6 to D25 (31-6=25).
Thus the definition should read

#define analogInputToDigitalPin(p)  ((p < NUM_ANALOG_INPUTS) ? 31 - (p) : -1)

since the digital port numbering is reversed on port A.

On a side note: the above files also redefine TIMER5A, TIMER5B, TIMER5C which causes some undesired warnings during compilation. It would be best to just delete these definitions since the 1284P doesn't seem to have these timers.