Comments (4)
matklad
commented on July 18, 2024
1
FWIW, I’ve recently written down my current thoughts on MSRV here: matklad/once_cell#201
from borsh-rs.
austinabell
commented on July 18, 2024
Hmm, I completely understand the viewpoint, and maybe we make no guarantees about bumping msrv during minor/patch versions, but is it not still beneficial to have this msrv controlled and visible?
Feel free to close, I don't have an actual opinion on this
from borsh-rs.
matklad
commented on July 18, 2024
Crates should document their MSRV policy, and, if the policy is different from "latest stable" it should be tested on CI.
I am not entirely sure what's the right MSRV policy for borsh, the following makes sense to me:
- MSRV is not breaking
- MSRV is six months at least
- explicit non-support for debian stable and such
- newer compilers can be used if required by a feature (cosnt-generics) or via feacher-checking in build.rs (eg, via rustc-version or autocfg crates).
If we have abundance of resources, 2 year MSRV would also make sense to me
If we are very short on resources, I think declaring "latest stable" won't be catastrophic either.
from borsh-rs.
dj8yfo
commented on July 18, 2024
taking this for trial and error and resolution
from borsh-rs.
Related Issues (20)
- Update near/near-abi-rs to work with alpha release
- Update zeropoolnetwork/bn to work with alpha release HOT 1
- BorshSchema vs custom serialisation HOT 4
- Include discriminant number in `BorshSchema::Enum::variants`
- Rename declarations (tuples, `nil`, `string`, `nonzero_xx` and arrays) HOT 5
- add implementation for `BorshSerialize`, `BorshDeserialize`, `BorshSchema` for `char` HOT 3
- Security Policy violation Branch Protection HOT 2
- Security Policy violation SECURITY.md HOT 2
- Restriction on Serializing Zero-Sized Types Affects Marker Component Usage HOT 7
- derive BoshSerialize fails if the type already uses `W` generic name HOT 4
- BorshSerialize derive fails for structs with packed attribute HOT 4
- Should `std` feature imply `rc` feature and vice-versa? HOT 4
- Read/Write mutable reference in `serialize` and `deserialize_reader` is unnecessary HOT 8
- `derive` macros require `cargo` to be present HOT 4
- Old NEAR contracts won't compile with the new `borsh` re-exported from `near-sdk-rs` ("Could not find `borsh`") HOT 5
- equivalent of `#[serde(default)]` HOT 2
- Borsh 2.0? Not planned HOT 2
- Extract `alloc` feature (2.0 candidate) HOT 1
- `bytes::Bytes` and `bytes::BytesMut` can be complemented with `BorshSchema`
- `bson::oid::ObjectId` can be complemented with `BorshSchema`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from borsh-rs.