Comments (4)
@Fuuzetsu Does serde
support it? I feel it is a rare case and users may just implement an internal helper struct for serializing/deserializing (kind of like this)
from borsh-rs.
@Fuuzetsu Does
serde
support it? I feel it is a rare case and users may just implement an internal helper struct for serializing/deserializing (kind of like this)
Seems to work out of the box in serde for this example: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=2005b735ca5ca80559abf53f03b36475
from borsh-rs.
serde
achieves #[repr(packed)]
partially working by surrounding (all) referenced fields with brackets { ... }
, which somewhat implicitly copies the field's value.
(it would be borsh::BorshSerialize::serialize(&{self.0}, writer)?;
in borsh
-s case
It works fine for Copy
fields:
#[derive(serde::Serialize)]
#[repr(packed)]
struct Bar {
x: u8,
y: u64,
}
and is a compilation error for non-Copy
types:
#[derive(serde::Serialize)]
#[repr(packed)]
struct Foo {
x: RefCell<u8>,
y: u64,
}
1 error[E0507]: cannot move out of `self.x` which is behind a shared reference
--> src/main.rs:12:10
|
12 | #[derive(serde::Serialize)]
| ^^^^^^^^^^^^^^^^ move occurs because `self.x` has type `RefCell<u8>`, which does not implement the `Copy` trait
|
= note: `#[derive(serde::Serialize)]` triggers a move because taking references to the fields of a packed struct is undefined behaviour
= note: this error originates in the derive macro `serde::Serialize` (in Nightly builds, run with -Z macro-backtrace for more info)
imo replicating serde
-s behaviour with packed
structs is worse than letting a user transparently work with unaligned references.
from borsh-rs.
a more versatile template for derives, allowing to work with non-Copy
types, might look like the following:
use core::mem;
use core::ops::Deref;
use core::ptr;
use std::rc::Rc;
#[repr(packed)]
struct Foo {
x: Rc<u8>,
y: u64,
}
impl borsh::ser::BorshSerialize for Foo {
fn serialize<W: borsh::io::Write>(
&self,
writer: &mut W,
) -> ::core::result::Result<(), borsh::io::Error> {
borsh::BorshSerialize::serialize(
mem::ManuallyDrop::new(unsafe { ptr::read_unaligned(ptr::addr_of!(self.x)) }).deref(),
writer,
)?;
borsh::BorshSerialize::serialize(
mem::ManuallyDrop::new(unsafe { ptr::read_unaligned(ptr::addr_of!(self.y)) }).deref(),
writer,
)?;
Ok(())
}
}
fn main() {
let foo = Foo {
x: Rc::new(42),
y: 182,
};
println!("{:?}", borsh::to_vec(&foo).unwrap());
}
from borsh-rs.
Related Issues (20)
- Security Policy violation SECURITY.md HOT 2
- Restriction on Serializing Zero-Sized Types Affects Marker Component Usage HOT 7
- derive BoshSerialize fails if the type already uses `W` generic name HOT 4
- Should `std` feature imply `rc` feature and vice-versa? HOT 4
- Read/Write mutable reference in `serialize` and `deserialize_reader` is unnecessary HOT 8
- `derive` macros require `cargo` to be present HOT 4
- Old NEAR contracts won't compile with the new `borsh` re-exported from `near-sdk-rs` ("Could not find `borsh`") HOT 5
- equivalent of `#[serde(default)]` HOT 2
- Borsh 2.0? Not planned HOT 2
- Extract `alloc` feature (2.0 candidate) HOT 1
- `bytes::Bytes` and `bytes::BytesMut` can be complemented with `BorshSchema`
- `bson::oid::ObjectId` can be complemented with `BorshSchema`
- Add struct/enum attr to relax bounds
- feat(schema): for chars HOT 4
- feat(schema): support serde of HashMap with S hasher
- Support for adding new fields to previously serialized structs HOT 2
- Can't serialize a `Vec<ZST>`, but it appears that the attack is only on deserialization HOT 1
- blanket implementation of `BorshSchema` for `&T` (where `T: BorshSchema`)
- Replace `schema_map!` tests with `insta` snapshots
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from borsh-rs.