Comments (7)
@cybersoulK , this is probably due to an optimization from compiler, where it makes single-variant enum zero-size.
rust-lang/rust#37649 .
Can likely be helped with adding #[repr(u8)]
attribute to the definition or just adding another variant.
from borsh-rs.
oh, congrats coming a long way with borsh 1.2!
from borsh-rs.
@cybersoulK , we've decided that using zero-sized types as keys in HashSet
/HashMap
is impractical, as there cannot be more that one instance of the type (and, transitively, more than one key in collection of this type).
Please share a minimal excerpt from your code to illustrate how this case is useful for you.
Ideally, if you shared it as a compilable repo with a previous version of borsh
.
from borsh-rs.
honestly i am having a hard time replicating it manually.
I thought it was
struct Marker;
enum Enum {
Marker(Marker)
SomethingElse(f32, ...)
}
Vec<Enum>
but i am able to run that successfuly, is there a way to print the exact type that's causing the issue?
from borsh-rs.
yep, i cannot see any Hashmap Key, or Vec Value that is an empty struct. i looked 10 times at the data
from borsh-rs.
Ok, i got it:
#[Component]
pub struct Cooldowns(pub HashMap<Skill, Interval>);
#[Component]
pub enum Skill {
Dash,
}
where right now, Skill is only one variant.
I feel relieved that my assumption of the markers was wrong.
But still, why ban an enum from being a key, if it only has one variant?
from borsh-rs.
Thank you ❤️, #[repr(u8)] should be good enough.
If there was anything can could be done is Borsh Derive to correct it automatically, would be nice.
from borsh-rs.
Related Issues (20)
- add implementation for `BorshSerialize`, `BorshDeserialize`, `BorshSchema` for `char` HOT 3
- Security Policy violation Branch Protection HOT 2
- Security Policy violation SECURITY.md HOT 2
- derive BoshSerialize fails if the type already uses `W` generic name HOT 4
- BorshSerialize derive fails for structs with packed attribute HOT 4
- Should `std` feature imply `rc` feature and vice-versa? HOT 4
- Read/Write mutable reference in `serialize` and `deserialize_reader` is unnecessary HOT 8
- `derive` macros require `cargo` to be present HOT 4
- Old NEAR contracts won't compile with the new `borsh` re-exported from `near-sdk-rs` ("Could not find `borsh`") HOT 5
- equivalent of `#[serde(default)]` HOT 2
- Borsh 2.0? Not planned HOT 2
- Extract `alloc` feature (2.0 candidate) HOT 1
- `bytes::Bytes` and `bytes::BytesMut` can be complemented with `BorshSchema`
- `bson::oid::ObjectId` can be complemented with `BorshSchema`
- Add struct/enum attr to relax bounds
- feat(schema): for chars HOT 4
- feat(schema): support serde of HashMap with S hasher
- Support for adding new fields to previously serialized structs HOT 2
- Can't serialize a `Vec<ZST>`, but it appears that the attack is only on deserialization HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from borsh-rs.