Comments (10)
I've hit this too, but can work around it if I increase the vertical height of the comment textarea using the resize handle. Not sure why that is relevant though
from gifs-for-github.
Thank you for all of the screenshots and helping debug 🎉
Sorry I haven't had a lot of time to look at this, after further digging I was finally able to reproduce it.
It wasn't happening for me because I had my scroll settings set to:
But when changing it to "Always" I could reliably replicate it.
I think I have a fix now which should be in version 24.1.16
from gifs-for-github.
Hey, thanks for submitting an issue!
I can't seem to reproduce this unfortunately, but I have a hunch, and made a PR that should hopefully fix this for you here: #71
I have submitted the updated extension for review, it should be version number 24.1.8
when it's active. If you could try again when it's updated and let me know that would be great.
from gifs-for-github.
Thanks for the quick and friendly response!
It's still broken in my end unfortunately (verified the version number as well as re-installed the extension). Works as expected for gifs in regular comments, but for PR reviews it looks as pictured above. Strangely enough, in PR comments it works as expected, only when adding the final verdict things are off.
I noticed similar behaviour (in regular Issue comments, for example) when narrowing the screen to <1112 pixels, i.e. when the GIF-button gets out of bounds, maybe that's easier to reproduce?
No sweat if this isn't a prioritised bug, workarounds are available after all (e.g. finding the perfect gif in a regular comment and then copying the link), just happy to report a finding for my legitimately no. 1 most used Chrome extension. 👏
from gifs-for-github.
For me it is not fixed on 24.1.8
regardless of the screen width. It is worth noting that I'm also using Refined Github extension, but it is not fixed even if I disable the extension.
Refined Github off, default state:
Refined Github off, opened state:
from gifs-for-github.
The latest version 24.1.18
should resolve this issue. Sorry it took so long, it took over 2 days to be reviewed 😢
from gifs-for-github.
from gifs-for-github.
from gifs-for-github.
GitHub has made another change to their layout which has caused it to break again 😭 I have already fixed it but have to wait for another approval before it's live.
from gifs-for-github.
from gifs-for-github.
Related Issues (19)
- [Feature request] Support for Github Enterprise HOT 7
- Popup window does not extend past the review / comment dropdown overlay HOT 2
- Inquiry: <img> tag instead of markdown style HOT 3
- Stopped working on "Files changed" (review) tab HOT 4
- [Feature Request] GitLab support? HOT 2
- Idea - show .gif selector on writing /giphy - similar to slack approach HOT 1
- Add more GIF providers HOT 2
- Feature Request: Ability to change GIF safety level. HOT 1
- [Feature Request] Make gifs collapsible, but open, by default
- GIF Button missing on release new/edit page HOT 1
- Double <img> insertion on GitHub Enterprise HOT 3
- Does not work any more (5th January 2024) HOT 4
- No longer available for Firefox? HOT 2
- GIF button appears below toolbar and makes toolbar unclickable HOT 2
- GIF button appears below toolbar in certain breakpoints HOT 4
- Repo: What license is this project operated under?
- Bug: funding.yml/FUNDING.yml collision after clone HOT 1
- Question: Does it work with Github Enterprise? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gifs-for-github.