Comments (4)
Thank you for reporting that the extension stopped working. You're right, GitHub has made some changes that caused the extension to break.
The fix for the recent changes are here: https://github.com/N1ck/gifs-for-github/pull/69/files (plus this sneaky additional fix here)
It is already available in version 24.1.6
, currently just in FIrefox and is awaiting review to be updated in Chrome but should be soon 🤞. I'll leave this issue open until I know it's out.
Thank you very much @mxosman also for investigating.
from gifs-for-github.
Experiencing the same thing with the extension not working in Chrome. It appears to be CSS related as it's rendering in the DOM, just behind other elements.
The problematic CSS class I noticed is select-menu-modal-right
in the giphy-toolbar-item.js
component:
<details class="details-reset details-overlay toolbar-item select-menu select-menu-modal-right ghg-trigger btn-octicon">
...
The position: relative;
seems to be clashing with the toolbar. When removed, the dropdown renders as usual (though the top margin is slightly off).
Happy to open a PR if granted write permissions - otherwise, my naive proposal (assuming no other issues) would be to adjust L5 in giphy-toolbar-item.js
to remove the select-menu-modal-right
class and adjust the styling slightly:
<details
class="details-reset details-overlay toolbar-item select-menu ghg-trigger btn-octicon"
style={{ 'margin-top': '4px' }}
>
from gifs-for-github.
Thank you! It's working again! ❤️
from gifs-for-github.
from gifs-for-github.
Related Issues (18)
- [Feature request] Support for Github Enterprise HOT 7
- Popup window does not extend past the review / comment dropdown overlay HOT 2
- Inquiry: <img> tag instead of markdown style HOT 3
- Stopped working on "Files changed" (review) tab HOT 4
- [Feature Request] GitLab support? HOT 2
- Idea - show .gif selector on writing /giphy - similar to slack approach HOT 1
- Add more GIF providers HOT 2
- Feature Request: Ability to change GIF safety level. HOT 1
- [Feature Request] Make gifs collapsible, but open, by default
- GIF Button missing on release new/edit page HOT 1
- Double <img> insertion on GitHub Enterprise HOT 3
- No longer available for Firefox? HOT 2
- Rendering is off in PR reviews HOT 10
- GIF button appears below toolbar and makes toolbar unclickable HOT 2
- GIF button appears below toolbar in certain breakpoints HOT 4
- Repo: What license is this project operated under?
- Bug: funding.yml/FUNDING.yml collision after clone HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gifs-for-github.