Git Product home page Git Product logo

Comments (4)

N1ck avatar N1ck commented on September 7, 2024 4

Thank you for reporting that the extension stopped working. You're right, GitHub has made some changes that caused the extension to break.

The fix for the recent changes are here: https://github.com/N1ck/gifs-for-github/pull/69/files (plus this sneaky additional fix here)

It is already available in version 24.1.6, currently just in FIrefox and is awaiting review to be updated in Chrome but should be soon 🤞. I'll leave this issue open until I know it's out.

Thank you very much @mxosman also for investigating.

from gifs-for-github.

mxosman avatar mxosman commented on September 7, 2024 2

Experiencing the same thing with the extension not working in Chrome. It appears to be CSS related as it's rendering in the DOM, just behind other elements.

The problematic CSS class I noticed is select-menu-modal-right in the giphy-toolbar-item.js component:

<details class="details-reset details-overlay toolbar-item select-menu select-menu-modal-right ghg-trigger btn-octicon">
...

The position: relative; seems to be clashing with the toolbar. When removed, the dropdown renders as usual (though the top margin is slightly off).

Happy to open a PR if granted write permissions - otherwise, my naive proposal (assuming no other issues) would be to adjust L5 in giphy-toolbar-item.js to remove the select-menu-modal-right class and adjust the styling slightly:

  <details
    class="details-reset details-overlay toolbar-item select-menu ghg-trigger btn-octicon"
    style={{ 'margin-top': '4px' }}
  >

from gifs-for-github.

ChrisJan00 avatar ChrisJan00 commented on September 7, 2024 2

Thank you! It's working again! ❤️

from gifs-for-github.

mxosman avatar mxosman commented on September 7, 2024 2

from gifs-for-github.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.