Comments (7)
I think it might be simply that I made a mistake with my most recent change
I have submitted another release 1.2.8
which I have verified will execute when the extension is enabled. I have still been unable to test GitHub enterprise, but I am crossing my fingers that the structure isn't different
Hopefully this works for you, if not I would love it if you could take a look for me! Let me know if I can help at all.
from gifs-for-github.
Hey @matthizou
Another option would be to use the module used by refined-github: https://github.com/fregante/webext-domain-permission-toggle. This should be pretty easy to add too!
If you are interested in contributing I think this would be a great addition. Let me know if you want to have a go at it, otherwise I am happy to take a look in the next week or so
from gifs-for-github.
Hey! Thanks for the reply
webpext-domain-permission-toggle
comes pre-canned and makes implementing this suggestion a really quick win. I am not a big fan of having to right-click on the icon and find this entry, it is not intuitive if you don't read the docs.- Custom implementation (like the one above) is more work. Ultimately, it is better for the user (imo), as they can do left-click on the icon and understand the interface intuitively. No need to browse the readme to find how to do it.
Last month I went for a custom implementation (https://github.com/matthizou/github-show-avatars/blob/master/extension/images/screenshots/popup-1.png), which work great, but am thinking of switching to something like the one from the Dark theme posted above, that I find even clearer.
I would suggest we start simple (webpext-domain-permission-toggle
), I'll let you do it if it is ok with you. Ping me if you are interested later on to do something more custom.
from gifs-for-github.
@matthizou sorry I took so long but I have pushed an update including webpext-domain-permission-toggle
(currently being reviewed by google) If you want to take a crack at a custom UI version at some point you are more than welcome
from gifs-for-github.
Glad to hear
No luck to make it work though, in my company's Github (it is activated + the browser has been reloaded)
I am not too surprised, as the 2 versions (enterprise and non-enterprise) have often major structural differences in the DOM - even in cases where they look the same. There are no errors in the console, though.
I will try to have a look a shot at it beginning of September except if work on it before. Keep it touch
from gifs-for-github.
from gifs-for-github.
Working like a charm
from gifs-for-github.
Related Issues (9)
- Popup window does not extend past the review / comment dropdown overlay HOT 2
- Inquiry: <img> tag instead of markdown style HOT 3
- Stopped working on "Files changed" (review) tab HOT 4
- [Feature Request] GitLab support? HOT 2
- Idea - show .gif selector on writing /giphy - similar to slack approach HOT 1
- Add more GIF providers HOT 2
- Feature Request: Ability to change GIF safety level. HOT 1
- No longer available for Firefox? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gifs-for-github.