morganstanley / desktopjs Goto Github PK

Initial list before investigation looks to be:

"rollup-plugin-commonjs": "^8.0.2"
"rollup-plugin-node-resolve": "^3.0.0"

https://colineberhardt.github.io/cla-bot/

node_modules/@morgan-stanley/desktopjs/dist/desktopjs.d.ts(3,1): error TS1046: A 'declare' modifier is required for a top level declaration in a .d.ts file.

Fix implementations of :

OpenFinContainer.getMainWindow()
OpenFinContainer.getAllWindows()

to use fin.desktop.Application.getCurrent().getWindow()

• Build Badge
• PR requirement

Typedocs by default uses the project README as the root. The relative link in there to the examples README is relative within the source tree and is broken within the docs.

https://morgan-stanley.github.io/desktopJS/

Identify change between [email protected] and 1.6.7 which causes issue
electron/electron@v1.6.6...v1.6.7

To reproduce, install [email protected]. While getting snap assist you can still easily move a window away from the snap threshold. Upgrade to [email protected] or later and the stickiness of the snap requires you to move the window fast and a large amount to leave snap threshold.

https://github.com/Morgan-Stanley/desktopJS/blob/573c58969119aba0c64282656a33b1e3fb4605f1/src/Default/default.ts#L129

Currently does not support relative urls which defeats some of the ability for the application to be easily container agnostic.

Change main window concept of an Electron application to be the first window created. If it doesn't exist or is closed then return undefined.

Due to parallel test execution the ordering of the tests can sometimes cause failure because the container registry was never being cleared between tests.

When loading/saving layouts, the position of the main window is not being included.

Libraries exposing dependent public types should define those @types as dependencies and not devDependencies. This removes the burden on the consumer of your library from manually adding the dependencies themselves.

Follows guidelines from microsoft/types-publisher#81

• Generate declarations
• Bundle declarations
• Include in module package

• OpenFin
• Electron

OpenFin getNativeWindow() sometimes returns null causing error saving url. Fallback to original options url when this happens.

Version 2.15.0 of tsutils was just published.

This version is covered by your current version range and after updating it in your project the build failed.

tsutils is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

unload event in chrome is called for new windows not just on close.

Provide for demo and testing in IE11

Publish on tags only branch master.

Developers should use the already caching resolveContainer() as it will always return the singleton.

Currently working with no errors and displaying on windows. Issue raised with vendor.

Race conditions due to asynchronous joinGroup

Changing Container from interface to container (#57) broke some hardcoded links in generated docs.

This will fix browser notifications on some browsers.

Add ability to get an enumeration of all open windows

Need to decide whether to set prototype of a static ContainerWindow.getWindow too which delegates back to container instance.getWindow.

Basic window layout persistence implemented over each concrete container.

export interface ContainerLayoutManager {
    loadLayout(name: string): Promise<PersistedWindowLayout>;
    saveLayout(name: string): Promise<PersistedWindowLayout>;
    getLayouts(): Promise<PersistedWindowLayout[]>;
}

export class PersistedWindow {
    public name: any;
    public bounds: any;
    public url: string;
    public state?: any;
}

export class PersistedWindowLayout {
    public name: string;
    public windows: PersistedWindow[] = [];

    constructor(name?: string) {
        this.name = name;
    }
}

Since snap handling is currently all asynchronous, when a window can be snapped and bounced back from a previous set of move event args.

When starting the electron example from the ./web directory the app throws an error

Uncaught Exception:
TypeError: Error processing argument at index 0, conversion failure from /Users/ripty/git/desktopJS/examples/electron..\web\favicon.ico
at ElectronContainer.addTrayIcon (../git/desktopJS/dist/desktop.js:775:20)
at App.createWindow (../git/desktopJS/examples/electron/electron.js:12:15)
at emitTwo (events.js:130:20)
at App.emit (events.js:213:7)

Test Environment
OS: MacOS 10.13.1
Electron: 1.6.11, 1.8.1

This appears to be related to electron/electron#7657, specifically an issue with conversion of a string to image.

After generating docs, place a .nojekyll file in the root to indicate to GitHub Pages that jekyll is not being used and to allow file names with underscores.

Implementation uses ipc but that can only be done from remote. When running in main the methods can be invoked directly.

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

When showing the frameless window for the context menu, the location and monitor bounds should be examined to determine position of the window.

http://cdn.openfin.co/jsdocs/stable/tutorial-system.getMonitorInfo.html

Static events are currently only sent over ipc and ipc -> ipc does not exist from main.

Electron removed BrowserWindowProxy.guestId property to correlate windows by ID when created via window.open.

https://stackoverflow.com/questions/32621988/electron-jquery-is-not-defined

Caused by #79

Add readme badge and integrate into PR comments.

When enumerating windows to persist, need to ignore notification windows