modm-io / cmsis-header-stm32 Goto Github PK

ST recently published their entire CubeHAL code on GitHub and it would significantly improve reliablity of this code to checkout the code from that.

In the stm32f103xb header file.
FLASH_ACR_LATENCY_n macros are defined incorrectly, which will cause a system fault when clock is 72MHz.
You may have also made the same error in similar families of CM3, so I will leave that to you to check.
I only noticed this because I am using a bluepill board.

So from line 9687, you defined the following:
#define FLASH_ACR_LATENCY_0 (0x1UL << FLASH_ACR_LATENCY_Pos) /*!< 0x00000001 /
#define FLASH_ACR_LATENCY_1 (0x2UL << FLASH_ACR_LATENCY_Pos) /!< 0x00000002 /
#define FLASH_ACR_LATENCY_2 (0x4UL << FLASH_ACR_LATENCY_Pos) /!< 0x00000004 /
This is incorrect, and according to the reference manual RM0008 Rev 21, page 60, Flash access control register (FLASH_ACR),
It should be the following:
#define FLASH_ACR_LATENCY_0 (0x0UL << FLASH_ACR_LATENCY_Pos) /!< 0x00000000 /
#define FLASH_ACR_LATENCY_1 (0x1UL << FLASH_ACR_LATENCY_Pos) /!< 0x00000001 /
#define FLASH_ACR_LATENCY_2 (0x2UL << FLASH_ACR_LATENCY_Pos) /!< 0x00000002 */

You have done a very fine job, thank you for your efforts.
Cheers.