Git Product home page Git Product logo

mmtk-v8's People

Contributors

caizixian avatar k-sareen avatar qinsoon avatar steveblackburn avatar udesou avatar wenyuzhao avatar wks avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

mmtk-v8's Issues

GC support

Currently V8 only works with NoGC. We need to support one or more of the simplest GCs we have (semispace, marksweep, or gencopy).

Some V8 tests fail on github hosted runners

See https://github.com/mmtk/mmtk-v8/pull/41/checks?check_run_id=3866176898.

Some tests failed with the following output:

[75:06|%  35|+ 6825|-   1]: cctest/test-concurrent-shared-function-info/Tes...
                                                                              
=== cctest/test-concurrent-shared-function-info/TestConcurrentSharedFunctionInfo ===
New Isolate: 564d16830f60
[2021-10-12T06:56:42Z INFO  mmtk::memory_manager] Initialized MMTk with NoGC


#
# Fatal error in ../../src/heap/heap-inl.h, line 610
# Debug check failed: top <= limit (8097875045981516645 vs. 1852400175).
#
#
#
#FailureMessage Object: 0x7f6e3caddde0
==== C stack trace ===============================

    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_libbase.so(v8::base::debug::StackTrace::StackTrace()+0x13) [0x7f6e57c14b63]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_libplatform.so(+0x1c00d) [0x7f6e57c3700d]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_libbase.so(V8_Fatal(char const*, int, char const*, ...)+0x153) [0x7f6e57c07463]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_libbase.so(+0x20ee5) [0x7f6e57c06ee5]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/cctest(v8::internal::Heap::IsPendingAllocation(v8::internal::HeapObject)+0x142) [0x564d13c04652]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::internal::compiler::JSHeapBroker::TryGetOrCreateData(v8::internal::Handle<v8::internal::Object>, v8::base::Flags<v8::internal::compiler::GetOrCreateDataFlag, int>)+0x18c) [0x7f6e569c9ccc]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::base::Optional<v8::internal::compiler::ref_traits<v8::internal::BytecodeArray>::ref_type> v8::internal::compiler::TryMakeRef<v8::internal::BytecodeArray, void>(v8::internal::compiler::JSHeapBroker*, v8::internal::BytecodeArray, v8::base::Flags<v8::internal::compiler::GetOrCreateDataFlag, int>)+0x2a) [0x7f6e56a0da3a]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::internal::compiler::SharedFunctionInfoRef::GetBytecodeArray() const+0xb5) [0x7f6e569f3b05]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::internal::compiler::BytecodeGraphBuilder::BytecodeGraphBuilder(v8::internal::compiler::JSHeapBroker*, v8::internal::Zone*, v8::internal::compiler::NativeContextRef const&, v8::internal::compiler::SharedFunctionInfoRef const&, v8::internal::compiler::FeedbackCellRef const&, v8::internal::BytecodeOffset, v8::internal::compiler::JSGraph*, v8::internal::compiler::CallFrequency const&, v8::internal::compiler::SourcePositionTable*, int, v8::internal::CodeKind, v8::base::Flags<v8::internal::compiler::BytecodeGraphBuilderFlag, int>, v8::internal::TickCounter*, v8::internal::compiler::ObserveNodeInfo const&)+0x6c) [0x7f6e56916b6c]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::internal::compiler::BuildGraphFromBytecode(v8::internal::compiler::JSHeapBroker*, v8::internal::Zone*, v8::internal::compiler::SharedFunctionInfoRef const&, v8::internal::compiler::FeedbackCellRef const&, v8::internal::BytecodeOffset, v8::internal::compiler::JSGraph*, v8::internal::compiler::CallFrequency const&, v8::internal::compiler::SourcePositionTable*, int, v8::internal::CodeKind, v8::base::Flags<v8::internal::compiler::BytecodeGraphBuilderFlag, int>, v8::internal::TickCounter*, v8::internal::compiler::ObserveNodeInfo const&)+0x122) [0x7f6e5692b2b2]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::internal::compiler::GraphBuilderPhase::Run(v8::internal::compiler::PipelineData*, v8::internal::Zone*)+0x12c) [0x7f6e56b37fbc]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(void v8::internal::compiler::PipelineImpl::Run<v8::internal::compiler::GraphBuilderPhase>()+0x8a) [0x7f6e56b2af4a]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::internal::compiler::PipelineImpl::CreateGraph()+0x4e) [0x7f6e56b26cce]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::internal::compiler::PipelineCompilationJob::ExecuteJobImpl(v8::internal::RuntimeCallStats*, v8::internal::LocalIsolate*)+0x61) [0x7f6e56b26f11]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_for_testing.so(v8::internal::OptimizedCompilationJob::ExecuteJob(v8::internal::RuntimeCallStats*, v8::internal::LocalIsolate*)+0x7f) [0x7f6e55b4f61f]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/cctest(v8::internal::compiler::BackgroundCompilationThread::Run()+0xb4) [0x564d13a84024]
    /home/runner/work/mmtk-v8/mmtk-v8/v8_deps/v8/out/x64.optdebug-mmtk/libv8_libbase.so(+0x2d4b0) [0x7f6e57c134b0]
    /lib/x86_64-linux-gnu/libpthread.so.0(+0x76db) [0x7f6e53e496db]
    /lib/x86_64-linux-gnu/libc.so.6(clone+0x3f) [0x7f6e537d471f]
Aborted (core dumped)
Command: out/x64.optdebug-mmtk/cctest test-concurrent-shared-function-info/TestConcurrentSharedFunctionInfo --random-seed=1158212576 --nohard-abort --enable-slow-asserts --verify-heap --testing-d8-test-runner
--- FAILED ---

V8 upstream compilation flag changes break mmtk builds

+++ gn gen out/x64.optdebug-mmtk
ERROR at //BUILD.gn:586:1: Assertion failed.
assert(!v8_enable_external_code_space || v8_enable_pointer_compression,
^-----
External code space feature requires pointer compression

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.