Subject.

The DE is KDE, if this matters.

Hi would you add a support for thunderbird? It's working fine with firefox, but I think thunderbird needs this extension a little more.

When I finish downloading a file with Firefox GNotifier correctly pops up a message saying the download is complete. But if I click on the blue-colored download icon in Firefox later it pops up the message again. If I delete or move the file I can even get it to pop up a third time. It used to properly only display once.

I'm using GNotifier 1.8.9.1-signed with Firefox 38 on Ubuntu 14.04 (Unity).

When clicking the notification to open the file Firefox will open the file then freeze for 2~3 minutes, dropping its CPU usage to 0 and memory to ~30 MB. I'm running Firefox 36.0.1 but the problem is noticeable for a while now (I believe it's as old and 34).

I have noticed that pages that trigger notifications (such as 9gag upvotes and comments) also cause Firefox to freeze.

When I disable GNotifier no native notification is shown and Firefox doesn't freeze anymore.

The notification for Thunderbird shows up perfectly, but it simply disappears when clicked. The expected behavior would be that clicking it would take you to the Thunderbird window.

First of all thanks for your really helpful addon!

As I don't know much about the notification implementation of Firefox: would it be possible to achieve compatibility with Tab notifier https://addons.mozilla.org/En-us/firefox/addon/tab-notifier/? Or should I ask the developer of Tab notifier?

Hi @mkoil,

Could you add turkish language support for GNotifier.

You can prepare tr.json file as following

{
"download_finished": "İndirme tamamlandı"
}

You can add "tr" in locales.json

{"locales": ["ar", "be", "bg", "cz", "de", "el", "en-US", "es", "fa", "fi", "fr", "hr", "it-IT", "ja", "ko", "nb-NO", "nl", "pl", "pt-BR", "pt-PT", "ro", "ru-RU", "sk", "sv-SE", "uk", "zn-CN", "zn-TW", "tr"]}

This extension is running without any problem on Cinnamon and Mate DE, You can add that supported DE list.

Best regards

Steps to reproduce:
Disable the extension

Expected results:
The extension switches the notification system to the default.

Actual results:
No notifications are displayed until the Firefox is restarted.

I posted this review [1] about a notification problem on debian wheezy.

Let me try to explain the problem better with a screenshot:

1. This is the kind of notification I'm expecting (the one gnome-shell uses):
   http://postimg.org/image/qu5xt9med/

2. This is what I'm getting after finishing a download:
   http://postimg.org/image/sycm64q3v/

[1] https://addons.mozilla.org/en-US/firefox/addon/gnotifier/reviews/494745/

Hi, can you please fix Czech translation ? You have it as "cz" but it should be "cs" in order to be recognized by the Firefox / Thunderbird. Here is also updated translation which I use locally.

Thank you.

{
 "File": "Soubor", 
 "Folder": "Složka", 
 "New_message": "Nová zpráva!", 
 "New_message_from": "Nová zpráva od", 
 "Number_of_unread_messages": "Počet nepřečtených:", 
 "Open_file": "Otevřít soubor", 
 "Open_folder": "Otevřít složku", 
 "download_finished": "Stahování dokončeno", 
 "open": "Otevřít"
}

Would you ever consider supporting Seamonkey?

Would it be possible to add a download progress bar (with a number that gives the numbers of files downloaded) to the launcher in Unity? Another add-on used to do this, but it has been broken for quite some time and is no longer being developed (https://launchpad.net/unityfox).

I'm not sure if this would be within the scope of GNotifier, but since it's, well, a download notifier it might fit. And would be really cool for those who use Ubuntu's default desktop environment! Regardless, thank you for this useful add-on.

In the specification (the updated one) it is explicit that app_icon (the direct paramater) and "image-path" (the hint) are icon names (for themes) or URIs and that only file:// URIs are supported.

In my daemon, I see the icon is passed as a simple path "/tmp/gnotifier-l7xukC" while is definitely should have the file:// scheme.
Also, I believe you should pass it as "image-path" and not icon, and the icon should probably be "firefox".

Doing that allows the server to either display the image (if there is one), the icon (if there is no image, as a fallback) or both (for rare servers that support it, mine does).

I think it should be trivial to change, but I could not decide where to do that change (in linux.js I guess, but where exactly). I can make a pull request or provide a patch if you point me to the right place to change that.

This extension is fantastic when it is working..Firefox's notifications get in the way a LOT especially if you setup PushBullet to provide Android notifications in your Firefox (awesome but gets overbearing).

I installed this extension on Firefox Nightly 35 and it worked GREAT but then I updated to Nightly 36 and it does not seem to work at all anymore.

I am using Firefox Nightly (36) on Arch Linux with GNOME Shell 3.14 and libnotify 0.7.6. - I am fairly certain it worked fine with GNOME 3.14 before the upgrade to Nightly 36. As of now, none of the notifications are being sent to libnotify, not even the basic download completed messages.

I realize it could be an Arch specific issue because those seem to be frequent with Nightly but just in case I am posting this issue on the chance that it isnt Arch related.

Linux notification server supports some html markups. To be 100% sure that no malicious script will be pass, content of notification body should be sanitized against Cross-site scripting (XSS).

This is blocking issue for the AMO submission.

My tests show that GNotifier is passing through the message body verbatim. Unfortunately, notification daemons don't expect HTML and many react poorly.

(This is a common mistake people make since Pango markup borrows certain common tag names like <b> from HTML but is not actually HTML.)

For example:

• The notification-daemon reference implementation which Lubuntu 12.04 uses applies XML-style strict parsing rules and, if there's markup it doesn't recognize, it displays a blank message.
• GNOME Shell apparently displays anything but <b>, <i>, and <u> as literal plaintext.

According to the Web Notifications spec, "The user agent must process any markup in this string so that it appears as plain text when used as a string in the underlying notification platform."

On Bug 858519 in Bugzilla, I've gone into detail on what the restrictions are and proposed an approach to performing said transformations.

Firefox warns about Gnotifier not being signed or verified

https://support.mozilla.org/en-US/kb/add-on-signing-in-firefox

Might be a problem later…

Sorry I didn't know pull requests create bug, bug report here: #2

Notifications from some Addon SDK extensions don't seem to get redirected to the system notification deamon. The exension that always seems to have this issue is PushBullet.
I am using Ubuntu, Gnome 3.10 and Firefox 31.

GNotifier 1.8.6 doesn't show utorrent server notifications.
But version 1.8.5 works fine.

ubuntu 14.4.1
libnotify4 0.7.6-1ubintu3

firefox 33
addons:
bittorrent webui+ 0.2.3.0
torrent status 1.16

utorrent server 3.3 (30470)

Right now you just get a plain notification with one default action set. However in most cases you need an option to either open the file or the folder, e.g.:

1. You download several images in a row. You don't want them all in your Downloads folder. so you want to go into the folder and move them.
2. You download an archive, and you want to directly look inside it.

Of course not all notification servers support this, like Unity's notify-osd. However, under the GNOME Shell and possibly Plasma this would be a great feature.

Thanks.

The firefox addon page says "Not available for your platform", so I tried to download and install the github version, which installs just fine, BUT it doesn't work, it still displays the default firefox notifications.

EDIT: I just fixed the, I used the addon blender to change my useragent, which caused an issue. This had nothing to with gnome 3.10.

Hello,

Thanks for your work.
Would it be possible to create a subdirectory in the /tmp dir or delete your "gnotifier-" just created ?
If not, can I delete them through a cronjob ?

Hi !
When I'm using Nightly with GNotify, the used icon is the Firefox one, not the Firefox-trunk (Nightly) icon.
It doesn't change anything to specify "firefox-trunk" for icon name in the settings…
Too bad ! Could you do anything to detect Nightly and use the right icon ? :D
Salamandar

Hi,

Thanks for writing this wonderful addon. I've installed the 1.5 version but it doesn't show notifications. I'm using Ubuntu 13.04 (package libnotify4 is installed). I've also tried triggering notifications using the test.html page in your repository, but to no avail.

Hello,
Thank for the work done, it is very good.

One thing though is that even when there were only one download, it says "Downloads complete", is it possible to have singular/plural strings ? This is not that important though, it is just to make it even more better.

Cheers,

As in title, I'm using 1.6 version of gnotifier, and latest aurora. Checked it with latest DTA from addons and latest beta.
Notification from DTA appears only once, then they die till restart of aurora.
Everything beside DTA is working fine so far.
With gnotifier disabled they work properly.

I have set browser.download.manager.showAlertOnComplete=false in about:config and it was working but, now that GNotifier is installed, the "Download Complete" notifications are appearing again despite the preference still being set.

However, this is even worse than before because, with GNotifier, if I don't play Whac-A-Mole with the alerts, they clutter up the desktop "missed notifications" log when I'm trying to a whole bunch of pics from a "Top X images of Y" post.

Recently in the last month or two, the alert service replacement mode of GNotifier has seemed to have stopped working, where the downloads still work fine.
I'm running Firefox 31, was this broken in a recent update?

New email notification sometimes contains only "Number of unread messages: XX" instead sender and subject info.

Not sure if this is possible with your setup, but could you add an open button to download notifications?

E.g. in KDE: https://i.imgur.com/tlaebDw.png

Sometimes when a Firefox notification is shown, the GNOME Shell freezes for a couple of seconds and then restarts. This seems to happen mostly (or only) when it's a notification for a completed download, and at that time another notification (from another application) also wants to show up.

I'm not sure if this extension is the cause, but it seems like this always happens right when it shows a Firefox notification and another notification, and I currently only use two shell extensions, so I think there is at least a relation somehow.

Using the recent-notifications applet in gnome-fallback, it seems to send a domain name and the xpi filename instead of "GNotifier" or "Firefox"

http://i.imgur.com/xLdLxwX.png

Since Thunderbird 38 messed up Linux libnotify support I have to use GNotifier, and it's great addon! However, I'd like the notification looked more like it used to on pure Thunderbird 31.7.

This is a notification I can see on Fedora 22 with GNotifier 1.8.9.1:

I'd suggest that "New message!" text is a "clutter", because seeing Thunderbirds icon here, I can safely assume I have a new email, no need to tell me again. I'd suggest a new design of the notification (summary and body terms are from notify-send --help) to look more like this:

SUMMARY: $subject
BODY: $from writes: "$body_excerpt"

...via:

notify-send -i thunderbird "This is a subject" "Michal Nowak <[email protected]> writes: \"Here comes the body...\""

Hi,

Maybe it's a wider problem, but I only see it with Gmail Panel (https://addons.mozilla.org/es/firefox/addon/gmail-panel/).

When Gmail Panel tries to show a notification, Firefox just exits. On a terminal you can see:

(firefox:8344): libnotify-CRITICAL **: notify_init: assertion '*app_name != '\0'' failed

(firefox:8344): libnotify-WARNING **: you must call notify_init() before showing
**
libnotify:ERROR:notification.c:568:notify_notification_show: code should not be reached

I tried other GNotify acting situations, like downloads or http://ttsvetko.github.io/HTML5-Desktop-Notifications/ and it works as expected. Again, maybe there are other ways to get the same error, but I only saw it with Gmail Panel.

Gmail Panel 1.0.7
GNotify 1.6
libnotify 0.7.6 on Fedora20

Thanks

Your mac ctypes of objective c is so awesome. I've been struggling a lot with it. I couldn't find any open source examples of it but finally found your repo, its excellent and I can learn a TON from it!! :) Thanks for it!

Just trying my luck here: Would you have time to chat about objc ctypes? I'm trying to get setApplicationIcon: https://bugzilla.mozilla.org/show_bug.cgi?id=1108246#c2

New mail notification does show a toast but when you ignore it (as in it timeouts), it does not show the notification in the action center. As per the documentation it should. Closing or "swiping" the toast does work as intended.

I tried to fix the issue myself but with no success. Perhaps it's an issue with the C++ API's in Windows 10 but I didn't really do more than setting a few breakpoints and commenting out pieces of code.

(Tested all this with version 1.9.0)

Hi,

I experimented a bit more with GNotifier and I appreciate the functionality more and more. A remaining problem is that the notifications show up without icons except it is a notification for a finished download. I don't have any errors in the error console so I don't have any clue where to look for the culprit. Any idea?

Best regards

I stumbled upon the problem that the temporary icon files are not deleted automatically. In the end the /tmp folder fills up with many many 0B files like gnotifier-cOwLfp. For me it seems that if there is no icon the temp file is 0B big and is not deleted automatically. If there is a image and the file size is bigger than 0B it is deleted as it should be the case. If you need further info, please ask.

Hi there,
I was learning objc in jsctypes and thanks to help and discussion from @arai-a we think that the class_addMethod implementation here last argument is wrong.

We think that the encoding should be:

so our conclusion is that we have to have a minimum of 3 chars so in summary: first char is return. second is the first arg for C which is always id, and third char is second arg of C which is always sel. and then the characters following are the 1st,2nd,3rd,nth objc args

So the code here:

should change from:

let r = class_addMethod( delegate, shouldPresentNotification, callback, "{NSUserNotification=#}");

to

let r = class_addMethod( delegate, shouldPresentNotification, callback, "B@:@");

What were your thoughts when you thought to use {NSUserNotification=#}, your thoughts would help us all learn :)

Hello,

This add-on looks great but does not work completely on my machine (quite different from bug #39). When I download something, then the notification correctly appears with notify-osd. However, when I use the Android Desktop Notifications addon (to get my phone notifications on Firefox), those Firefox/XUL notifications are not "transfered" to libnotify.

I am using Firefox 34.0 and Ubuntu 12.04 on GNOME 3 Session Fallback. Here is my machine configuration :

• Firefox 34.0
• GNotifier 1.8.7 - Debug Version
• Linux 3.2.0-75-generic
• libnotify 0.7.5-1

I don't know if this might help but the following message appears on a terminal when I installed GNotifier :

console.log: gnotifier: Linux
console.log: gnotifier: exports.main
console.log: gnotifier: system.name: Firefox
console.log: gnotifier: Notify server name: notify-osd
console.log: gnotifier: libnotify server info:
console.log: gnotifier: name: notify-osd
console.log: gnotifier: vendor: Canonical Ltd
console.log: gnotifier: version: 1.0
console.log: gnotifier: spec_version: 1.1
console.log: gnotifier: libnotify server capabilities:
console.log: gnotifier: body
console.log: gnotifier: body-markup
console.log: gnotifier: icon-static
console.log: gnotifier: image/svg+xml
console.log: gnotifier: x-canonical-private-synchronous
console.log: gnotifier: x-canonical-append
console.log: gnotifier: x-canonical-private-icon-only
console.log: gnotifier: x-canonical-truncation
console.log: gnotifier: private-synchronous
console.log: gnotifier: append
console.log: gnotifier: private-icon-only
console.log: gnotifier: truncation
console.log: gnotifier: notifApi.checkAvailable is ok
console.log: gnotifier: Expected exeption if FF>=26

Would it be possible to add support for Icedove? I just tested, and it works alright when I add tests for Icedove for the 1.9.1-pre3 xpi.

I tried editing the source code, but I couldn't create an xpi for it. For example, I didn't find the options.xul, or does it need to be generated? Anyway, the changes are quite trivial.

Hi there,
I just installed GNotifier on Thunderbird 38.4.0 (Windows 10) and it's working fine but I got this annoying issue with RSS: I am notified about each and every RSS article being fetched.

Is there a way/workaround to be notified on emails only?
Thanks

Steps to reproduce:

1. Try making a notification at http://aurelio.audero.it/demo/web-notifications-api-demo.html
2. Close it.

Expected results:
When looking at log, "show" event is displayed when the notification is shown and "close" event is displayed when the notification is closed.

Actual results: The "show" event is never displayed. The "close" event is displayed when the notification appears. When I close the notification, no event is fired.

System:
% uname -a
Linux ntb 3.11.0-19-generic #33~precise1-Ubuntu SMP Wed Mar 12 21:16:27 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux

Firefox Build identifier: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0

Notification daemon: xfce4-notifyd

Would it be possible to add support for Firefox forks (IceWeasel, IceCat, ...)? By this I mean that the addon already works on them, but the notification displays a Firefox icon rather than the icon of the browser that's actually being used. Or is this already supposed to happen?

When a file is downloaded, the notification should read "Download complete" not "Downloads complete" if only one file is downloaded. Actually, it seems like when there are multiple files downloaded they are all listed individually, so it should always just read "Download complete". This is the case with the English translation, as well as the French and German (and probably all the others).

Thanks for the add-on!

idk why, but i still see firefox-drawn toaster notifications.

is it possible that addons get load before this one, and get a hold of the old function/service implementation, and reuse this? or is this impossible and showAlertNotification always calls the currently registered implementation?

it seems like the former, since deactivating and activating my own addon makes it use native notifications as enabled by this addon.