1. Seems that it should not be called 'ancestor', in the context of a tree data structure. IMO, it should be a typo

2. Besides, the implementation of named_parameters should have a clearer description on how to reference the child parameters. I need to dive into the testing code to find out what exactly you want me to do.

3. Also, the final example here doesn't match the photo.

Anyway, thanks for the tutorial, it does help!!!

Would it make sense to add argparser to the run_tests.py scripts so that typing python run_tests.py --help will give the user more instructions and make it easier to run specific tests instead of all in the module?

First, thank you for sharing this project with us!

Could you please add an explicit LICENSE file to the repo so that it's clear
under what terms the content is provided, and under what terms user
contributions are licensed?

Per GitHub docs on licensing:

[...] without a license, the default copyright laws apply, meaning that you
retain all rights to your source code and no one may reproduce, distribute,
or create derivative works from your work. If you're creating an open source
project, we strongly encourage you to include an open source license.

Similar issue applies to all the other repos in this org, as none of them appear
to have specified their license.

Thanks!

I finished Task 0.1-0.4 and passed the tests.

For Task 0.5: Visualization, when run streamlit run app.py -- 0, browser shows an error:

ModuleNotFoundError: No module named 'minitorch'
Traceback:
File "/home/zeyuan/.conda/envs/torch/lib/python3.8/site-packages/streamlit/script_runner.py", line 379, in _run_script
    exec(code, module.__dict__)
File "/mnt/e/workspace/Module/Module-0/project/app.py", line 3, in <module>
    from interface.train import render_train_interface
File "/mnt/e/workspace/Module/Module-0/project/interface/train.py", line 5, in <module>
    import graph_builder
File "/mnt/e/workspace/Module/Module-0/project/graph_builder.py", line 1, in <module>
    import minitorch

How should I do to solve this problem?

This function should probably be named gt and the math should say f(x, y) instead of f(x)

datasets.py should have an import for “import matplotlib.pyplot as plt” at the top of it, because the assignment asks for images to be saved for readme viewing, and the saving mechanism is commented out on line 65 (presumably intentionally or as a hint) as “plt.savefig”. Or at least the import should also be commented out, or the commented plt.savefig should be deleted?

This template requires

• Python 3.8 or higher
• numba == 0.55 in requirements.txt

However, there is no matching version for numba == 0.55 and I had to install the closest version, 0.56 instead. It requires Python < 3.11 that I used for virtual environment.

This should change to

• Python > 3.8, Python < 3.11
• numba == 0.56 in requirements.txt

This test case at line 180 of test_operators.py tests the sum function against itself. The sum function is imported from operators.py and no longer bound to the builtin sum function.

@pytest.mark.task0_3
@given(lists(small_floats))
def test_sum(ls: List[float]) -> None:
    assert_close(sum(ls), sum(ls))

After completing the assignment, I tried to install the package with:

python setup.py install

I could import the package at path ~/Module-0/ but not anywhere else. What am I doing wrong?

import minitorch
ModuleNotFoundError: No module named 'minitorch'
PS C:\Users\noahi\Documents\minitorch-module-0-coffeerow-ai\workspace\venv\module-0>

Even though the problems comes up as - "No problem have been detected in the workspace."