miketheman / knife-community Goto Github PK

View Code? Open in Web Editor NEW

25.0 6.0 3.0 157 KB

A Knife plugin to assist with deploying completed Chef cookbooks to the Chef Supermarket

Home Page: http://miketheman.github.io/knife-community/

License: MIT License

Ruby 96.15% Gherkin 3.85%

deprecated cookbooks chef knife ruby knife-plugin

knife-community's People

Contributors

Stargazers

Watchers

Forkers

m00gs schisamo dldinternet

knife-community's Issues

Update for Chef 11

With Chef 11 installed:

/Users/jtimberman/.rbenv/versions/1.9.3-p327/lib/ruby/1.9.1/rubygems/specification.rb:1637:in `raise_if_conflicts': Unable to activate knife-community-0.0.1, because chef-11.0.0 conflicts with chef (~> 10) (Gem::LoadError)

conflict mixlib-shellout

After a fresh:

gem install chef
gem install berkshelf
gem install knife-community

I have an error:

knife community release --help
/home/guilhem/.rvm/rubies/ruby-1.9.3-p448/lib/ruby/site_ruby/1.9.1/rubygems/specification.rb:1638:in `raise_if_conflicts': Unable to activate knife-community-0.2.0, because mixlib-shellout-1.2.0 conflicts with mixlib-shellout (~> 1.1.0) (Gem::LoadError)

I bypass this by:
gem uninstall mixlib-shellout -v 1.2.0

Include default ignore file

There should be a list of files that are ignored by default:

# Put files/directories that should be ignored in this file when uploading
# or sharing to the community site

# Compiled source #
###################
*.com
*.class
*.dll
*.exe
*.o
*.so
*/rdoc/

# Packages #
############
# it's better to unpack these files and commit the raw source
# git has its own built in compression methods
*.7z
*.dmg
*.gz
*.iso
*.jar
*.rar
*.tar
*.zip

# Logs and databases #
######################
*.log
*.sql
*.sqlite

# OS generated files #
######################
.DS_Store
ehthumbs.db
Icon?
Thumbs.db

# SASS #
########
.sass-cache

# Bundler #
###########
.bundle

# POW #
#######
.pow
.powrc
.powenv

# Other Stuff #
###############
.project
.settings

# Editor #
##########
*~
*.sw[a-z]

# Subversion #
##############
.svn
*/.svn

# Git #
#######
.git
*/.git
.gitignore
.gitmodules
.gitconfig
.gitattributes

# Spec #
########
.rspec

# Ruby #
########
.rvmrc
.rbenv-version
Gemfile
Gemfile.lock
Rakefile

# Travis #
##########
.travis.yml

# Cookbook #
############
CONTRIBUTING*
CHANGELOG*
Colanderfile
Berksfile
Berksfile.lock
.colander
tmp

Look at using ruby-git instead of Grit

https://github.com/schacon/ruby-git

Use Chef::Knife::CookbookSiteShare instead of shellout to command

The share_new_version method uses shellout to the knife cookbook site share command, rather than using the Chef::Knife::CookbookSiteShare class.

      # The use the existing knife command to tarball & share.
      # This could possibly done in a more elegant fashion than shelling out again.
      knife_ckbk_path = "-o #{config[:cookbook_path].join(':')}" if !config[:cookbook_path].nil?
      shellout("knife cookbook site share #{@cb_name} #{category} #{knife_ckbk_path}")

Partial duplication of efforts?

Firstly, love the idea of making community site contributions simpler -- i kept meaning to get around to figuring it out, and this is going to make it simple :)

Any thoughts on the similarities with this plugin?
https://github.com/Atalanta/knife-cookbook-bump

//cc @Atalanta @fnichol

Github description still mentions community site

That should probably get updated for Supermarket

Agreeable to adding option for "vX.Y.Z" style tagging?

I can help with the work on this, but would much prefer if tagged releases of my cookbooks were of the form "v1.0.4" (vs. "1.0.4"). This allows you to sort and differentiate all release tags from other arbitrary ones. It's also the default style that Bundler and Jeweler use when releasing gems.

An opt-in flag is fine by me; it's about the only blocker for me to use this for all cookbook releases.

Thanks!

the `gsub!` that changes version number in metadata.rb is not specific enough

TL;DR - ALL THE VERSIONS are bumped, not just the cookbook's version.

An example of the commit that was produced:

% git show HEAD
commit ef24858cd4665dd68af28a4fde93995c7a1e552e
Author: Seth Chisamore <[email protected]>
Date:   Wed Feb 27 09:45:18 2013 -0500

    release v1.0.5

diff --git a/metadata.rb b/metadata.rb
index 1769b92..0be9655 100644
--- a/metadata.rb
+++ b/metadata.rb
@@ -4,7 +4,7 @@ maintainer_email "[email protected]"
 license          "All rights reserved"
 description      "Installs/Configures Opscode CI clusters"
 long_description IO.read(File.join(File.dirname(__FILE__), 'README.md'))
-version          "1.0.4"
+version          "1.0.5"

 # internal cookbooks
 depends "opscode-github"
@@ -20,6 +20,6 @@ depends "ntp", "~> 1.3.2"
 depends "python", "~> 1.2.2"
 depends "rbenv", "~> 1.4.1"
 depends "rsyslog", "~> 1.5.0"
-depends "runit", "~> 1.0.4"
+depends "runit", "~> 1.0.5"
 depends "sudo", "~> 2.0.4"
 depends "users", "~> 1.3.0"