midasplatform / slicerappstore Goto Github PK

Consolidate mechanism allowing developer to specify extension metadata.

This issue is created as a place holder to keep track of what has been done.

• X Homepage:
• X Source Code:

@zachmullen and @cpatrick: Is adding JS code to a div the recommended / standard midas way to expose data to JS ?

• https://github.com/midasplatform/slicerappstore/blob/master/views/index/index.phtml#L121
• https://github.com/midasplatform/slicerappstore/blob/master/public/js/index/index.index.js#L135

Using jsonContent div may conflict with some other code, what about using an explicit namespace ?
For example: https://github.com/midasplatform/slicerpackages/blob/master/controllers/ViewController.php#L267

Open question: What about using the api proposed by jquery? See http://api.jquery.com/data/

Make sure the left menu call back is not added

@cpatrick and @zachmullen

I really think the possibility to render the midas view without the surrounding element should be part of the core.

There is more than just checking for the value of the param slicerView. The possibility to pass json value should for example be managed by a core "simple" view.

Note that this issue is associated with milestone 2

As discussed:

• The widget summarising the rating will look like the one available on the android market.
• Rating won't be anonymous and will be limited to one rating per user per extension

Open questions:

• Should the average rating be computed over all the revision of an extension ?
• Should we limit the rating to only logged in user ?
• Should we limit the rating to user accessing the page only through Slicer embedded browser ?

The API associated with the rating module should allow to compute the average score on a list of items.

Self explanatory.

Ideally, if somebody want to either comment or rate a extension from within the embedded browser, it should be possible to do so.

If not logged in, a "lightbox" or "web 2.0 modal dialog" should appear and propose the user with the option to either logged in or register.

• For an example, see bottom of the following page
• Similarly I propose we integrate the Attribution-ShareAlike 2.5 Generic to the midas comment module.

If switch to "installed state", the button shouldn't be clickable.

For example, on my local install I attempted using the following URL: http://localhost/midas/slicerappstore?revision=19276&os=linux&arch=amd64 does not work.

Indeed, the OS/Arch selector are not updated accordingly which lead to incorrect parameters when invoking the listextension web API call.

The idea is to be able to associate comment to an item. Note also that within slicerpackages, an extension is mapped to an item (the concept of item revision is not used).

After selecting parameters, the url is not updated.

When you go to the extension details view for a single extension, you see breadcrumbs below the title and authors. We should move this above them into a more visible, pretty bar.

Currently the default icon associated with extension is a yellow puzzle piece. See http://10.171.2.159/Midas3/slicerappstore?slicerView

@zachmullen mentioned earlier that it's a little bit off-center. @SteveJordanKW do you have any idea how we could improve the icon ?

Self explanatory

@cpatrick, @zachmullen Any idea what could cause such problem ?

I noticed that issue only from within a regular browser.

I basically changed the URL from:

• http://localhost/midas/slicerappstore

to

• http://localhost/midas/slicerappstore?slicerView

Message displayed:

Fatal Error: Array
(
    [type] => 1
    [message] => Uncaught exception 'Zend_Session_Exception' with message 'session has already been started by session.auto-start or session_start()' in /home/jchris/Projects/Midas3/library/Zend/Session.php:461
Stack trace:
#0 /home/jchris/Projects/Midas3/library/Zend/Session/Namespace.php(143): Zend_Session::start(true)
#1 /home/jchris/Projects/Midas3/core/controllers/ErrorController.php(42): Zend_Session_Namespace->__construct('Auth_User')
#2 /home/jchris/Projects/Midas3/library/Zend/Controller/Action.php(133): ErrorController->init()
#3 /home/jchris/Projects/Midas3/core/GlobalController.php(41): Zend_Controller_Action->__construct(Object(Zend_Controller_Request_Http), Object(Zend_Controller_Response_Http), Array)
#4 /home/jchris/Projects/Midas3/library/Zend/Controller/Dispatcher/Standard.php(268): MIDAS_GlobalController->__construct(Object(Zend_Controller_Request_Http), Object(Zend_Controller_Response_Http), Array)
#5 /home/jchris/Projects/Midas3/library/Zend/Controller/Front.php(954): Zend_Controller_Dispatcher_Standard->
    [file] => /home/jchris/Projects/Midas3/library/Zend/Session.php
    [line] => 461
    [typeText] => E_ERROR
)


URL: http://localhost/midas/slicerappstore?slicerView

Server IP: 127.0.0.1
User agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:10.0.2) Gecko/20100101 Firefox/10.0.2
Server time: 2012-02-28 03:08:08
Parameters (post): Array
(
)

Parameters (get): Array
(
    [slicerView] => 
)

Propose a design showing a graphical scale illustrating how many of the Ron Rules an extension doesn't comply with: http://www.slicer.org/slicerWiki/index.php/Documentation-3.5-Rons-Rules

The design will have to be "compliant" with Slicer palette:

• http://www.slicer.org/slicerWiki/index.php/Slicer3:Human_Interface_and_Style_Guide_for_Developers#Colors:_application_palettes
• http://www.slicer.org/slicerWiki/index.php/Slicer4:ViewerDesign#Draft_palette_for_viewer_colors

When 'CSS and Javascript optimizer' is enabled, rendering this http://localhost/midas/slicerappstore?layout=empty gives the following javascript errors:

Thumbnail are all resized as squared image. Is there already some code with Midas to properly resize thumbnail by keeping the original ratio ?

@zachmullen: Let me know what you think. Thanks

Within the slicerpackages plugin there is already code allowing to expose the list of Os/Arch to both Js and PHP.

Ideally, this code should be re-used in the slicerappstore module.

See https://github.com/midasplatform/slicerpackages/blob/master/controllers/ViewController.php#L181

May a component could be created ?

Note also that currently the list of Os/arch is hardcoded. In the near future this list will either be contain in its own table or will be generated from the existing data.

See http://slicer.kitware.com/midas3/slicerappstore/extension/view?extensionId=15615&layout=layout

and click on the screenshot.

@pieper: Try to reload your cache

This issue is created as a place holder to keep track of what has been done.

On page: http://slicer.kitware.com/midas3/slicerappstore
After entering a revision, the count per category is incorrect.

As of today, comments are associated with a given extension/item.

When the extension ovewview page is displayed, we would like to list the comment associated with all extensions.

Internally, the comment module API could optionally allow to list the comment associated with a list of items instead of a single items.

If for a given revision of Slicer, multiple revision of an extension are uploaded, they will all appear on the page.

By default, let's display the most recent extension for any given version of Slicer.

As illustrated in the following image, SkullStripper extension is listed twice.

See https://github.com/midasplatform/slicerappstore/blob/master/controllers/IndexController.php

@SteveJordanKW and @zachmullen
Propose a design for the mechanism allowing to switch platform / bitness / version on the regular web page version of the extensionlist.
See https://www.kitware.com/KWWiki/index.php/NAMIC/Yr8/SlicerAppStore#.282.29_Regular_web_pages

A "sharewiththeworld" midas plugin could be created allowing to share item / community ...

The system should provide hook allowing to easily integrate the "sharing widget" with any custom view.

Within the extension overview page, the "tweet/facebook share / google+1" buttons could be on the top right.

The design will have to be "compliant" with Slicer palette:

• http://www.slicer.org/slicerWiki/index.php/Slicer3:Human_Interface_and_Style_Guide_for_Developers#Colors:_application_palettes
• http://www.slicer.org/slicerWiki/index.php/Slicer4:ViewerDesign#Draft_palette_for_viewer_colors