Git Product home page Git Product logo

Comments (8)

wekempf avatar wekempf commented on May 17, 2024 1

I've been spiking this, and the problem as I see it is two fold.

  1. Configuration providers are generally meant to be pretty static in nature. You load all configuration at once. Yes, you can reload, and yes it is possible with a bunch of work to make it work fully dynamically (though GetChildKeys may make it difficult for some providers), but this is pretty non-trivial stuff for this to feel like an abstraction like MEDI and MEL are.

  2. At the configuration level we're missing context to be able to use existing feature flag backends. For instance, with Launch Darkly you can't interrogate a flag without having a user. Some hacky "access global state" approach might work here, but that approach is ugly at best.

Configuration should be a provider, not the only provider, and the provider abstraction should include context hooks.

from featuremanagement-dotnet.

jimmyca15 avatar jimmyca15 commented on May 17, 2024

Hey @christogav it's a good suggestion. We are still working on some features that may result in tweaks to the current API surface. Once we finalize all of those items we can shift toward exposing the internals to make the library more open as you have described.

from featuremanagement-dotnet.

antmdvs avatar antmdvs commented on May 17, 2024

Hi @jimmyca15 ,

Could we please get visibility into the WIP features or is everything captured by https://github.com/microsoft/FeatureManagement-Dotnet/issues/created_by/jimmyca15?

Also I'd like to get an idea of when this lib might be considered stable..?

Thanks!

from featuremanagement-dotnet.

josephwoodward avatar josephwoodward commented on May 17, 2024

Likewise, very interested to know when this is considered stable so we can start using it. I'm also interested in using it with external vendors. @christogav Out of interest, what are the interfaces you'd like to see made public?

from featuremanagement-dotnet.

jimmyca15 avatar jimmyca15 commented on May 17, 2024

@antmdvs @josephwoodward

We have a couple of breaking changes in the dev branch awaiting a release.

Currently we don't expect any breaking changes after that and after the release of these features we plan to give it a little bit of time for final feedback then release a stable version. All changes on top of that will be additive.

from featuremanagement-dotnet.

christogav avatar christogav commented on May 17, 2024

@josephwoodward Looks like IFeatureSettingsProvider is the main one. There may be others but I haven't looked in detail.

from featuremanagement-dotnet.

antmdvs avatar antmdvs commented on May 17, 2024

Given the original inquiry:

We'd like to propose that some of the interfaces be made public so we can switch out their implementations...

It doesn't seem to me this should be necessary to integrate with FFaaS providers, given that:

Any .NET Core configuration provider is capable of acting as the back-bone for feature flags.

as stated in the README.

IOW, would it make more sense to create a custom .NET Core configuration provider for, say, LaunchDarkly or whichever?

from featuremanagement-dotnet.

jimmyca15 avatar jimmyca15 commented on May 17, 2024

This has been added in the latest release.

from featuremanagement-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.