Comments (3)
It makes more sense to use resourse filter for the feature gate scenario. I will take a look at your PR and learn how to implement a filter attribute.
from featuremanagement-dotnet.
Hi, @WeihanLi
The Feature Management ASP.NET library provides FeatureGateAttribute
and an extension method of AspNetCore.MVC.FilterCollection
called AddForFeature
which will add a FeatureGatedAsyncActionFilter
.
Here what you pointed out is the FeatureGateAttribute
which is built on ActionFilterAttribute
.
The ASP.NET Core includes some built-in filter attributes:
ActionFilterAttribute
ExceptionFilterAttribute
ResultFilterAttribute
FormatFilterAttribute
ServiceFilterAttribute
TypeFilterAttribute
There is no built-in filter attributes for resource filter and authorization filter.
The way to use FeatureGateAttribute
is to place it on MVC controllers, controller actions, or Razor pages.
The FeatureGateAttribute
implements the OnActionExecutionAsync
method which will [run before any of the action's filters]
(https://learn.microsoft.com/en-us/aspnet/core/mvc/controllers/filters?view=aspnetcore-8.0#controller-level-filters).
According to the diagram, it seems like the stage of "Model Binding" can be skipped. I don't think using AuthorizationFilter
is sensible.
Therefore, it brings two questions:
- Should the stage of "Model Binding" be skipped?
- How to implement an Attribute for resource filter?
I need to do more investigation.
from featuremanagement-dotnet.
Thanks for the reply
- I think it should be skipped if the feature is not enabled, it seems no need to go through the model binding
- Need to inherit the
Attribute
to make it work as an attribute and implement theIResourceFilter
/IAuthorizationFilter
or/and the async interface ...
I tried to propose an AuthorizationFilterAttribute
like the ActionFilterAttribute
, but seemed the asp.net team does not want to include it in the framework dotnet/aspnetcore#40542
from featuremanagement-dotnet.
Related Issues (20)
- Silent failure in TargetingTelemetryInitializer HOT 10
- The TargetingId should be included in the FeatureEvaluation event even if it's null/empty. HOT 4
- Targeting evaluation is CPU dependent. HOT 4
- Remove the support for variants and telemetry from the .NET feature flag schema HOT 14
- Include Targeting Information on outgoing telemetry HOT 2
- Support .NET 8 Targeting framework in Microsoft.FeatureManagement.Telemetry.ApplicationInsights.AspNetCore
- Target netstandard2.* in Microsoft.FeatureManagement.Telemetry.ApplicationInsights
- The approach to telemetry (using custom `ITelemetryPublisher`) seems overengineered and counter to modern OpenTelemetry abstractions HOT 37
- Add Default Http Targeting Context Accessor
- Consider moving `TargetingHttpContextMiddleware` to the App Insights package HOT 2
- No instance of ITargetingContextAccessor is available for variant assignment. HOT 6
- FeatureManagerSnapshot should snapshot TargetingContext as well
- EvaluationDataToApplicationInsights example
- Can't Set FeatureFilters In FeatureManager In .NET Framework Application HOT 7
- Update Package metadata
- Add a link to preview on main readme
- Cannot use the TargetingFilter in .NET class library project HOT 3
- Nuget "Microsoft.FeatureManagement.AspNetCore" Version 3.3.0 - Multiple feature filters match the configured filter named 'Microsoft.TimeWindow' HOT 8
- Consider using `TimeProvider` using Microsoft.Bcl.TimeProvider nuget package HOT 2
- Bug 4.0.0-preview: NullReferenceException when TargetingContext.UserId is null and TargetingEvaluationOption.IgnoreCase = true
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from featuremanagement-dotnet.