Comments (7)
Agree, we should preserve the behavior for this override. Thanks for raising the issue.
from featuremanagement-dotnet.
@FredericVaugeoisFlo I think this should be an oversight. Thanks for calling it out.
The override method AddFeatureManagement(configuration) should support your scenario. Otherwise, I think this method will be kind of useless.
My thought is that we can add an option for ConfigurationFeatureDefinitionProvider to read from the root of the configuration if no "FeatureManagement" section is found (the behavior in 2.6.0). This option should be false by default. But if it is registered by AddFeatureManagement(configuration), the option will be set to true.
from featuremanagement-dotnet.
Great thank you!
from featuremanagement-dotnet.
Will this feature be patched to work for .NET 8 again?
I don't expect any specific issue for .NET 8. All versions of .NET should behave the same.
It would be relevant to name the configuration-section to a custom name instead of relying on only "FeatureManagement".
Is this a request for that capability? That should be doable once we address the issue using the pattern in the initial issue description. services.AddFeatureManagement(configuration.GetSection("MyCustomFlagsSection"));
from featuremanagement-dotnet.
https://learn.microsoft.com/en-us/azure/azure-app-configuration/use-feature-flags-dotnet-core?tabs=core6x
In our public document, we mentioned this usage.
from featuremanagement-dotnet.
Will this feature be patched to work for .NET 8 again? It would be relevant to name the configuration-section to a custom name instead of relying on only "FeatureManagement".
from featuremanagement-dotnet.
Fixed in release 3.1.0
from featuremanagement-dotnet.
Related Issues (20)
- Suggest to have app.UseFeatureManagement HOT 8
- Silent failure in TargetingTelemetryInitializer HOT 10
- The TargetingId should be included in the FeatureEvaluation event even if it's null/empty. HOT 4
- Targeting evaluation is CPU dependent. HOT 4
- Remove the support for variants and telemetry from the .NET feature flag schema HOT 14
- Include Targeting Information on outgoing telemetry HOT 2
- Support .NET 8 Targeting framework in Microsoft.FeatureManagement.Telemetry.ApplicationInsights.AspNetCore
- Target netstandard2.* in Microsoft.FeatureManagement.Telemetry.ApplicationInsights
- The approach to telemetry (using custom `ITelemetryPublisher`) seems overengineered and counter to modern OpenTelemetry abstractions HOT 37
- Add Default Http Targeting Context Accessor
- Consider moving `TargetingHttpContextMiddleware` to the App Insights package HOT 2
- No instance of ITargetingContextAccessor is available for variant assignment. HOT 6
- FeatureManagerSnapshot should snapshot TargetingContext as well
- EvaluationDataToApplicationInsights example
- Can't Set FeatureFilters In FeatureManager In .NET Framework Application HOT 7
- Update Package metadata
- Add a link to preview on main readme
- Cannot use the TargetingFilter in .NET class library project HOT 3
- Nuget "Microsoft.FeatureManagement.AspNetCore" Version 3.3.0 - Multiple feature filters match the configured filter named 'Microsoft.TimeWindow' HOT 8
- Consider using `TimeProvider` using Microsoft.Bcl.TimeProvider nuget package HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from featuremanagement-dotnet.