Git Product home page Git Product logo

Comments (7)

jimmyca15 avatar jimmyca15 commented on June 15, 2024 3

Agree, we should preserve the behavior for this override. Thanks for raising the issue.

from featuremanagement-dotnet.

zhiyuanliang-ms avatar zhiyuanliang-ms commented on June 15, 2024 2

@FredericVaugeoisFlo I think this should be an oversight. Thanks for calling it out.
The override method AddFeatureManagement(configuration) should support your scenario. Otherwise, I think this method will be kind of useless.
My thought is that we can add an option for ConfigurationFeatureDefinitionProvider to read from the root of the configuration if no "FeatureManagement" section is found (the behavior in 2.6.0). This option should be false by default. But if it is registered by AddFeatureManagement(configuration), the option will be set to true.

from featuremanagement-dotnet.

FredericVaugeoisFlo avatar FredericVaugeoisFlo commented on June 15, 2024 1

Great thank you!

from featuremanagement-dotnet.

jimmyca15 avatar jimmyca15 commented on June 15, 2024 1

Will this feature be patched to work for .NET 8 again?

I don't expect any specific issue for .NET 8. All versions of .NET should behave the same.

It would be relevant to name the configuration-section to a custom name instead of relying on only "FeatureManagement".

Is this a request for that capability? That should be doable once we address the issue using the pattern in the initial issue description. services.AddFeatureManagement(configuration.GetSection("MyCustomFlagsSection"));

from featuremanagement-dotnet.

zhiyuanliang-ms avatar zhiyuanliang-ms commented on June 15, 2024

https://learn.microsoft.com/en-us/azure/azure-app-configuration/use-feature-flags-dotnet-core?tabs=core6x
image
In our public document, we mentioned this usage.

from featuremanagement-dotnet.

TobiasGPersson avatar TobiasGPersson commented on June 15, 2024

Will this feature be patched to work for .NET 8 again? It would be relevant to name the configuration-section to a custom name instead of relying on only "FeatureManagement".

from featuremanagement-dotnet.

zhiyuanliang-ms avatar zhiyuanliang-ms commented on June 15, 2024

Fixed in release 3.1.0

from featuremanagement-dotnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.