upgrade default Stanford NER to v3.9.2 about cliff-annotator HOT 9 CLOSED

Agreed - great suggestion. I'm working on upgrading the build infrastructure and will try to pull this in as part of it. I haven't touched the actual code in about a year, so it is taking me time to spin it back up :-(

from cliff-annotator.

thanks, that would be awesome ! I tried updating the maven dependencies and rebuilding the cliff.war, but in vain (getting a bunch of issues)

from cliff-annotator.

I have a version of this that upgrades stanford-nlp to 3.9.2 few minor changes and java 1.8 requirement was needed, however I am unable to get the GeoNameAncestryTest to pass as is written. Can you confirm it's working as designed?

from cliff-annotator.

n/m i just saw the pull request that's in to fix the test. I'll submit a pull request w/ the nlp updates but both will need to be merged in for the test to pass.

from cliff-annotator.

resolved by #66

from cliff-annotator.

FYI - I pushed this out as a v2.5.0 release (and updated the Docker image and API client accordingly). Thanks!

from cliff-annotator.

@rahulbot don't the models under https://github.com/mitmedialab/CLIFF/tree/master/stanford-entity-extractor/src/main/resources/models need to updated with the NER modules from the 3.9.2 jar ? Are there any there other updates other than the adding the latest NER models under resources and referencing them in the initialize method in StanfordNamedEntityExtractor.java that need to be done ?

from cliff-annotator.

Hmm.. I dunno. I tested it and it works fine with the old models and the new code, but of course I'm realizing that doesn't actually resolve this issue. You probably want the new models, duh. I'm in the middle of fixing the other new issues I need resolved, so let me push some of that stuff and test it out alongside the model updates.

from cliff-annotator.

Try out v2.6.0, which I just released on here. It loads the latest models.

from cliff-annotator.