ReadableStream typing does not match async iterator spec about web-streams-polyfill HOT 3 CLOSED

Thank you!

from web-streams-polyfill.

Thanks for the report!

The reason I defined it as a property rather than a method was because the spec demands that ReadableStream.prototype[Symbol.asyncIterator] === ReadableStream.prototype.values, so I have to do some trickery to make that work. Unfortunately, I didn't consider that this would be visible in the public type definitions... Sorry about that! I'm working on a fix.

I see that you've decided to switch to Node's native ReadableStream implementation in openai/openai-node#614. That's awesome, I'm happy to see streams get more native support! 😁

By the way, I noticed this type definition in your code:

export interface IterableReadableStreamInterface<T>
  extends ReadableStream<T>,
    AsyncGenerator<T> {}

That should really be:

export interface IterableReadableStreamInterface<T>
  extends ReadableStream<T>,
    AsyncIterable<T> {}

since a ReadableStream is not really an async generator. 😉

from web-streams-polyfill.

Ah got it - thanks for the context and heads up around that typing!

from web-streams-polyfill.