Comments (8)
Sorry about the inconvenience!
IMHO a minimum node version bump should not be made in a minor release. We'll probably be able to work around this issue with overriding the dependency version but just wanted to let you know anyway! (I assume more remix users are going to run into this)
You're right about the engines
bump, I shouldn't have done that. The polyfill should work fine when installed on Node 8, but building the polyfill requires a newer Node version (because of the build dependencies). I'll revert that.
Removing down-leveling is also a breaking change for TS users. Some users are stuck on older TS versions because of transpilation incompatibilities (see getsentry/sentry-javascript#2848 as an example we've run into). Is there appetite in making this a major version instead?
Hmm, I didn't think users would still be using such old TypeScript versions... I'll see what I can do.
from web-streams-polyfill.
Could you release a quick fix version for this? Maybe with the latest commit of 3.2.0? Some production systems are failing to build because of this.
from web-streams-polyfill.
Thanks for the quick turnaround!
from web-streams-polyfill.
Remove down-leveling for TypeScript 3.5 or lower
Removing down-leveling is also a breaking change for TS users. Some users are stuck on older TS versions because of transpilation incompatibilities (see getsentry/sentry-javascript#2848 as an example we've run into). Is there appetite in making this a major version instead?
from web-streams-polyfill.
whoops, sorry for the auto close, i just merged a workaround in our repo which accidentally closed this issue
from web-streams-polyfill.
Version 3.3.1 is out. Can you check if that fixes it?
from web-streams-polyfill.
Yes, it works now. Thank you.
from web-streams-polyfill.
Heads-up: I pushed a 3.3.2 release, since 3.3.1 was missing the dist/types/polyfill.d.ts
file. 🤦♂️
from web-streams-polyfill.
Related Issues (20)
- Issue with dynamic import HOT 3
- The stream is not in a state that permits enqueue; new Response(readable).blob().text() resolve to [object ReadableStream] not underlying source HOT 10
- ReadableStream and File/Blob HOT 2
- Use in a streaming library for nodejs and browsers HOT 6
- dom-exception.ts HOT 6
- closing a stream followed by respond(0) can error if close is not syncronously putting stream in closed state HOT 5
- `pipeTo` doesn't use `signal.reason` as error HOT 2
- Example for polyfilling TextDecoderStream in previous browsers HOT 2
- `pipeTo` with `preventCancel: true` never settle if `readable` doesn't produce new chunks HOT 2
- Upgrading to Typescript 4.9 results in error TS2322 when using web-streams-polyfill HOT 3
- Abilities to support web streams under IE8-? HOT 3
- Question: how to detach a TypedArray. HOT 1
- Add `ReadableStream.from(asyncIterable)` HOT 1
- welp, looking for that readableStream iterator polyfill HOT 7
- Q: how to best upgrade to byte stream? HOT 1
- ReadableStream typing does not match async iterator spec HOT 3
- [Question] TransformStream and Response as specified and implemented HOT 6
- Upgrade to 4.0.0 from 3.3.3 causes type issues in node HOT 3
- Could you please decrease the size of the package? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web-streams-polyfill.