Git Product home page Git Product logo

Comments (8)

MattiasBuelens avatar MattiasBuelens commented on May 30, 2024 2

Sorry about the inconvenience!

IMHO a minimum node version bump should not be made in a minor release. We'll probably be able to work around this issue with overriding the dependency version but just wanted to let you know anyway! (I assume more remix users are going to run into this)

You're right about the engines bump, I shouldn't have done that. The polyfill should work fine when installed on Node 8, but building the polyfill requires a newer Node version (because of the build dependencies). I'll revert that.

Removing down-leveling is also a breaking change for TS users. Some users are stuck on older TS versions because of transpilation incompatibilities (see getsentry/sentry-javascript#2848 as an example we've run into). Is there appetite in making this a major version instead?

Hmm, I didn't think users would still be using such old TypeScript versions... I'll see what I can do.

from web-streams-polyfill.

feluna avatar feluna commented on May 30, 2024 1

Could you release a quick fix version for this? Maybe with the latest commit of 3.2.0? Some production systems are failing to build because of this.

from web-streams-polyfill.

Lms24 avatar Lms24 commented on May 30, 2024 1

Thanks for the quick turnaround!

from web-streams-polyfill.

AbhiPrasad avatar AbhiPrasad commented on May 30, 2024

Remove down-leveling for TypeScript 3.5 or lower

Removing down-leveling is also a breaking change for TS users. Some users are stuck on older TS versions because of transpilation incompatibilities (see getsentry/sentry-javascript#2848 as an example we've run into). Is there appetite in making this a major version instead?

from web-streams-polyfill.

Lms24 avatar Lms24 commented on May 30, 2024

whoops, sorry for the auto close, i just merged a workaround in our repo which accidentally closed this issue

from web-streams-polyfill.

MattiasBuelens avatar MattiasBuelens commented on May 30, 2024

Version 3.3.1 is out. Can you check if that fixes it?

from web-streams-polyfill.

feluna avatar feluna commented on May 30, 2024

Yes, it works now. Thank you.

from web-streams-polyfill.

MattiasBuelens avatar MattiasBuelens commented on May 30, 2024

Heads-up: I pushed a 3.3.2 release, since 3.3.1 was missing the dist/types/polyfill.d.ts file. 🤦‍♂️

from web-streams-polyfill.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.