Comments (2)
Good catch! Indeed, the next
version of the polyfill seems to deviate from the specification. 🤔
The polyfill waits for both reads and writes to finish before shutting down the pipe. However, the reference implementation and most browser implementations only wait until all writes have finished. Any read requests that have been started by the pipe but haven't finished yet are "silently" discarded.
I think I did this because we had to ensure there were no more pending read requests before the shutdown process calls reader.releaseLock()
(see d77b1dd). However, that was before we changed releaseLock()
's behavior in whatwg/streams#1168. So really, the polyfill no longer needs to (and actually shouldn't) do this anymore.
I'll look into it. 🕵️
from web-streams-polyfill.
Fixed in v4.0.0-beta.3
from web-streams-polyfill.
Related Issues (20)
- Use in a streaming library for nodejs and browsers HOT 6
- dom-exception.ts HOT 6
- closing a stream followed by respond(0) can error if close is not syncronously putting stream in closed state HOT 5
- `pipeTo` doesn't use `signal.reason` as error HOT 2
- Example for polyfilling TextDecoderStream in previous browsers HOT 2
- Upgrading to Typescript 4.9 results in error TS2322 when using web-streams-polyfill HOT 3
- Abilities to support web streams under IE8-? HOT 3
- Question: how to detach a TypedArray. HOT 1
- Add `ReadableStream.from(asyncIterable)` HOT 1
- welp, looking for that readableStream iterator polyfill HOT 7
- Q: how to best upgrade to byte stream? HOT 1
- Node version bump from 8 to 18 breaks Remix installation HOT 8
- ReadableStream typing does not match async iterator spec HOT 3
- [Question] TransformStream and Response as specified and implemented HOT 6
- Upgrade to 4.0.0 from 3.3.3 causes type issues in node HOT 3
- "TypeError: Failed to execute 'pipeThrough' on 'ReadableStream'" HOT 4
- Issue with dynamic import HOT 3
- The stream is not in a state that permits enqueue; new Response(readable).blob().text() resolve to [object ReadableStream] not underlying source HOT 10
- ReadableStream and File/Blob HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web-streams-polyfill.