Comments (11)
I will take this one
from r68k.
I'm trying to implement this but the test for suba_16_pd is failing. I wonder if Musashi may have a similar bug as ADDA (or was that bug for ADDA only?)
from r68k.
My code might of course be wrong but just want to check
from r68k.
I haven't looked, but if you take a look at the PR fixing adda, the problem should be explained in enough detail for you to check Musashis suba implementation
from r68k.
If pd and pi both fail (sometimes, as it is random based) but never the others, I'd say it's very likely there's a bug in Musashi suba as well
from r68k.
Yeah if you look at the mame code:
https://github.com/mamedev/mame/blob/master/src/devices/cpu/m68000/m68k_in.cpp#L9590
And the original
https://github.com/kstenerud/Musashi/blob/master/m68k_in.c#L9455
it's likely a bug in SUBA also
from r68k.
I'm running all the tests except pd and pi to verify that the current code work as expect with it.
from r68k.
When I have time, I can fix suba in Musashi locally, abd retest
from r68k.
That would be great.. Thanks!
I will hold of with my suba PR right now and do something else in between.
from r68k.
No, please do the PR, it will help me verify the fix to Musashi, without duplicating your work. If there's still something, you can always update the PR before I merge.
from r68k.
Done
from r68k.
Related Issues (20)
- Implement TRAPV HOT 1
- Implement TST HOT 1
- Implement UNLK HOT 1
- Diff MAME version of Musashi with current HOT 29
- Compiler gets stuck when building release HOT 17
- Use default for Cpu struct
- More accurate cycle emulation for DIVS/DIVU needed?
- CHK, DIVU, DIVS trap case cycles differs from Musashi HOT 6
- Streamline qc and op_handler macros HOT 1
- Improve performance during QC HOT 27
- Improve QC coverage HOT 8
- Use a logging framework HOT 1
- Disassembler HOT 27
- Implement opcode completeness test HOT 5
- Consider using a codegen for glue HOT 2
- Generating cycle tables HOT 23
- Turn r68k into a lib HOT 14
- Host callbacks HOT 11
- Share fuzz testing code HOT 3
- fuzix HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from r68k.