lybros / appa Goto Github PK

View Code? Open in Web Editor NEW

6.0 6.0 3.0 9.39 MB

GUI for TheiaSfM multiview geometry and structure from motion library.

CMake 2.63% C++ 93.58% Shell 0.18% Python 3.52% C 0.09%

bsu c-plus-plus computer-vision course-work cpp cv famcs sfm structure-from-motion

appa's People

Contributors

Stargazers

Watchers

Forkers

imlab-uiip lxr0911 ogsdave

appa's Issues

ui:project

Implement project:new/open/save/save as functions

code style

@UladBohdan, i think we should find some code style, to follow it.

please use cpplint for fixing errors together
also check if cpplint_mac_os.sh from lint-branch work for Linux
and we can improve lint settings for us, and fix script

Now we have:

Category 'build/header_guard' errors found: 2
Category 'build/include_order' errors found: 17
Category 'build/include_subdir' errors found: 20
Category 'build/include_what_you_use' errors found: 7
Category 'legal/copyright' errors found: 1
Category 'readability/alt_tokens' errors found: 1
Category 'readability/casting' errors found: 3
Category 'readability/inheritance' errors found: 2
Category 'runtime/explicit' errors found: 3
Category 'runtime/indentation_namespace' errors found: 2
Category 'runtime/references' errors found: 4
Category 'whitespace/blank_line' errors found: 4
Category 'whitespace/comments' errors found: 1
Category 'whitespace/indent' errors found: 4
Category 'whitespace/line_length' errors found: 2
Category 'whitespace/parens' errors found: 8
Total errors found: 81

QWidgetWindow warnings on macOS

Following warnings at runtime:

QWidgetWindow(0x7f94da3d9ce0, name="projectToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3e14f0, name="featuresToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d7600, name="visualizationToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9f70, name="mainToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9ce0, name="projectToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9ce0, name="projectToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9ce0, name="projectToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d7600, name="visualizationToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9f70, name="mainToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3e14f0, name="featuresToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9ce0, name="projectToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9f70, name="mainToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3e14f0, name="featuresToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d7600, name="visualizationToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9ce0, name="projectToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3e14f0, name="featuresToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d7600, name="visualizationToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9f70, name="mainToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3e14f0, name="featuresToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d7600, name="visualizationToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9f70, name="mainToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.
QWidgetWindow(0x7f94da3d9ce0, name="projectToolBarWindow") ( QScreen(0x7f94d7c9b7d0, name="Color LCD") ): Attempt to set a screen on a child window.

create project crash

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       EXC_I386_GPFLT
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [0]

src:cmake

very slow build, maybe some bugs in cmake file

project paths

to make sure every path in project configuration has a trailing slash.

ui:progress bar

Application freezes every time you start feature extraction / reconstruction / whatever else.

We do need progress bars. Or something else.

A LOT OF MEMORY LEAK

due to my knowledge of c++
refactor required.

UI Thumbnails size bug

Thumbnails does not look really good if images names are too long

ui:menu

on Mac OS after starting app menu with project->new/open don't clickable

the app crashes if we are retrieving colors from the image, which is not in the root of IMAGES_LOCATION directory, but elsewhere
(we're loosing some parts of the file when concatenating IMAGES_LOCATION and IMAGE_NAME)

must be fixed.

searched image tumbnail

render searched image tumbnail on sidebar

Documentation

For future:

fully document code
use some tool for auto generating docs, for example doxygen

avoiding unix-style directory shortcuts ".."

in accordance with Google C++ styleguide and in order to keep code portability we should avoid unix directory shortcuts. https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

seems that with the project structure we have we're unable to do that.

should we be worried about that?

reset visualization on project open

when new project opened, thumbnails updated, but view not:

project quarry opened, but rendered model from previous project

src:reconstruction store

Move all work with reconstruction from Project to Storage
Read model from file and load it in memory on project open

Blind white areas when rendering the model

Rendering is not correct: white blind areas appear when zooming/rotating the model

timer

to embed timer into process manager.
separate timer for every process running.

src:features

implements classes: Extractor, Matcher, Reconstruction.
use force for overriding builded files

ui:console

add output for view building process

IO refactoring

to move all IO (config file, calibration file) to a separate module.

src:model coror: colorizing the model just after the build

As for now, model is colorized every time we're running visualization (that means, we're searching for colors in raw image data a lot of times)
We should move that to the process of model build and to save colors to the model.binary file.
That will also mean independence from folder with images (easier to share models).

When we highlight an image on a map we may simply ignore the color.

@Drapegnik what do you think?