Continuous integration about lumispy HOT 6 CLOSED

@ericpre If you are happy with this CI implementation, please cloase this issue. Otherwise we can work on it further.

from lumispy.

I have wrote a couple of comments on #30. Having Azure pipeline would be worth to test on the 3 main platforms.

from lumispy.

Working on adding Azure pipeline in #33 .

from lumispy.

Now both Travis and Azure pipelines work well.
However, I would ask if you could quickly check if the Azure pipeline is doing the tasks it is supposed to do (so far it simply runs the same pytest scripts as Travis), @ericpre .

I also don't seem to understand why in here if I set as endpoint: lumispy (so the organisation under my username in DevOps) the pipeline fails. As far as I know, both my username (jordiferrero) and the organisation (lumispy) should have full access to Github from Azure...

from lumispy.

However, I would ask if you could quickly check if the Azure pipeline is doing the tasks it is supposed to do (so far it simply runs the same pytest scripts as Travis), @ericpre .

Yes, both are working, but I would suggest to do the following:

• travis test pip only install using packages from pypi
• azure test conda environment

At the moment, it azure is doing almost the same as travis, using packages from pypi instead of conda packages. This is because you are missing the files defining what package to install in the conda environment (see https://github.com/hyperspy/ci-scripts#conda-environment).

Since pip and conda are the main way to install python packages, this is useful to check that both are working fine. For a pure python library, this may sounds overkill but it has the advantage that it checked that the dependencies are working fine in both cases. Also packages are usually release first on pypi before being available on anaconda cloud and if the update of a dependency break the test suite, it should come up first on travis.

As mentioned in hyperspy/ci-scripts#1, I will follow up with a PR to clarify these points.

I also don't seem to understand why in here if I set as endpoint: lumispy (so the organisation under my username in DevOps) the pipeline fails. As far as I know, both my username (jordiferrero) and the organisation (lumispy) should have full access to Github from Azure...

Can you please point out to a specific build?

from lumispy.

I also don't seem to understand why in here if I set as endpoint: lumispy (so the organisation under my username in DevOps) the pipeline fails. As far as I know, both my username (jordiferrero) and the organisation (lumispy) should have full access to Github from Azure...

Can you please point out to a specific build?

@ericpre Here are the examples:

• Here the build was made setting endpoint: jordiferrero. All good.

• Here the only change was to add endpoint:lumispy.
  This suddenly raises the following error:
  /azure-pipelines.yml: Could not get the latest source version for repository hyperspy/ci-scripts hosted on https://github.com/ using ref refs/heads/master. GitHub reported the error, "Not Found"

The same issue happens when I merge my personal fork to the lumispy repository.
I have opened a PR #36 for this specific issue.

from lumispy.