Git Product home page Git Product logo

Comments (4)

Attolight-NTappy avatar Attolight-NTappy commented on June 19, 2024

Hello!

Just wanted to share that the incriminated test runs fine with my configuration, so I don't think it is an upstream library modification issue:

lumispy 0.2.3.dev0 (main branch)
hyperspy 1.8.0.dev0 (both RELEASE_next_minor and RELEASE_next_patch branches)

============================= test session starts =============================
collecting ... collected 2 items

test_cl_spectrum.py::TestCLSpectrum::test__make_signal_mask 
test_cl_spectrum.py::TestCLSpectrum::test_remove_spikes 

======================== 2 passed, 3 warnings in 3.57s ========================

Process finished with exit code 0
PASSED       [ 50%]PASSED           [100%]

I have python 3.10.9 and numpy 1.23.5.

from lumispy.

ericpre avatar ericpre commented on June 19, 2024

Could it be related to the changes in the way random numbers are generated? See hyperspy/hyperspy#3103

from lumispy.

Attolight-NTappy avatar Attolight-NTappy commented on June 19, 2024

Ah sorry I just noticed that the tests have been commented out in the code ^^

Indeed it fails on my machine too.

Changing they way random is seeded does not really seem to change anything though

from lumispy.

Attolight-NTappy avatar Attolight-NTappy commented on June 19, 2024

I think @ericpre is right and it's just a float comparison issue in the test. Test fails based on what random number is generated if I don't let it to a fixed seed of 1.

Changing line 55 to s.data[0, 2, 29] += 1.001 fixes it.

I have opened PR #187 that fixes it

from lumispy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.