Comments (4)
Hello!
Just wanted to share that the incriminated test runs fine with my configuration, so I don't think it is an upstream library modification issue:
lumispy 0.2.3.dev0 (main branch)
hyperspy 1.8.0.dev0 (both RELEASE_next_minor and RELEASE_next_patch branches)
============================= test session starts =============================
collecting ... collected 2 items
test_cl_spectrum.py::TestCLSpectrum::test__make_signal_mask
test_cl_spectrum.py::TestCLSpectrum::test_remove_spikes
======================== 2 passed, 3 warnings in 3.57s ========================
Process finished with exit code 0
PASSED [ 50%]PASSED [100%]
I have python 3.10.9 and numpy 1.23.5.
from lumispy.
Could it be related to the changes in the way random numbers are generated? See hyperspy/hyperspy#3103
from lumispy.
Ah sorry I just noticed that the tests have been commented out in the code ^^
Indeed it fails on my machine too.
Changing they way random is seeded does not really seem to change anything though
from lumispy.
I think @ericpre is right and it's just a float comparison issue in the test. Test fails based on what random number is generated if I don't let it to a fixed seed of 1.
Changing line 55 to s.data[0, 2, 29] += 1.001 fixes it.
I have opened PR #187 that fixes it
from lumispy.
Related Issues (20)
- Docstring formatting in RTD HOT 11
- Transient signal classes HOT 3
- LumiSpy v0.2 HOT 2
- Create a `remove_background_signal` function HOT 1
- Extend functionality of crop_edges HOT 3
- Implementation of Spectroscopy File Readers HOT 18
- Increase coverage HOT 2
- Webhook failing HOT 3
- Adding an interactive way to slice HS over a wavelength range, and view the result spatially! HOT 12
- Consolidate axis conversion codes
- Failure with numpy 1.24.dev
- Slicing of energy/wavenumber signal with isig fails
- Failure with numpy dev HOT 1
- Documentation is broken HOT 3
- Azure tests failing HOT 2
- Find maximum and width of a peak HOT 1
- Reminder: Change doc-links to sphinx
- Slicing TransientSpec HOT 23
- `to_eV()` function and non-uniform axis HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lumispy.