Git Product home page Git Product logo

Comments (7)

sfsekaran avatar sfsekaran commented on May 28, 2024

Yeah, this fix would be nice. I get this, currently:

> git commit
/Users/sfsekaran/.rvm/gems/ruby-1.9.2-p290@topspin/gems/rmagick-2.13.1/lib/RMagick2.bundle: [BUG] Segmentation fault
ruby 1.8.7 (2010-01-10 patchlevel 249) [universal-darwin10.0]

/usr/local/bin/git-hooks: line 57: 55137 Abort trap              ${hook} "$@"

from lolcommits.

mroth avatar mroth commented on May 28, 2024

Hmm. I'm not sure how to address the issue... I assume a git hook executes the script in the context of the current gemset in rvm. So is the issue we'd need to peg the execution to a specific gemset that may not be the currently active one for the shell? If so, how would the proper gemset be determined?

from lolcommits.

sfsekaran avatar sfsekaran commented on May 28, 2024

Maybe we'd have to detect whether rvm is installed. Then get the correct gemset, and then the correct executable paths from rvm and embed them into the lolcommit.rb file or a config yml or env var or something.

from lolcommits.

mroth avatar mroth commented on May 28, 2024

Can you please uninstall (instructions in the new README) and install the new version I just uploaded? It's substantially refactored, and is packaged as a gem itself. My hope is this will make it's inclusion in gemsets simpler. Let me know how it works, thanks!

from lolcommits.

jlsuttles avatar jlsuttles commented on May 28, 2024

I like it 👍

from lolcommits.

sfsekaran avatar sfsekaran commented on May 28, 2024

Works for me :)

from lolcommits.

mroth avatar mroth commented on May 28, 2024

Sounds like it works (yay!), closing as fixed.

from lolcommits.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.