lkldev / pe Goto Github PK

Steps to reproduce

1. run add n/James Ho p/22224444 e/[email protected] a/123, Clementi Rd, 1234665 i/package1 t/friend t/colleague
2. run add n/james Ho p/22224444 e/[email protected] a/123, Clementi Rd, 1234665 i/package1 t/friend t/colleague

Expected

Person not added.

Actual

Person was added.

Screenshots

Since names are not case sensitive in real life, it should not be case sensitive in the application as well.

Steps to reproduce

1. Run edit 6 n/James Lee e/[email protected]
2. Run add n/James Lee p/22224444 e/[email protected] a/123, Clementi Rd, 1234665 i/package1 t/friend t/colleague

Expected

Person not added successfully.

Actual

Person added successfully.

Screenshots

Steps to reproduce

1. Run edit 2 n/James Lee e/[email protected]
2. Run edit 3 n/James Lee e/[email protected]

Expected

Run edit 3 n/James Lee e/[email protected] should be unsuccessful as person with James Lee exist.

Actual

Command ran successfully.

Screenshots

Considering that I am not able to add two people with the same name, I can however edit a person to have the same name. This defeats the purpose of checking for duplicate Persons when adding them.

Steps to reproduce

run find i/Golden Package

Expected

Return people with insurance package Golden Package.

Actual

Returns list of everybody with package inside.

Screenshots

Not really a bug but a feature flaw, as I was trying to delete packages with name Golden Package, and was not able to as somebody is tied to the package. Tried to find who was tied to it but I was return with a list of 6 people, which kind of defeats the purpose of the command.

Steps to reproduce

run addp i/basic package d/

Expected

Package not created as basic package exist (same name)

Actual

Package was created

Screenshots

Since package name are the unique identifier, it seems like package name should be case insensitive. Also, for a fast typist, it will be easier not to consider the case sensitivity here.

Steps to reproduce

1. export contact to csv
2. add same tag name to person

Expected

CSV import unsuccessful.

Actual

CSV import successful.

Screenshots

Bugs

There are duplicate lines found in sequence diagram for find command.

Screenshots

No details provided by bug reporter.

Bug

Links in DG still refers to AB3 code. Marking the severity as medium as it is troublesome having to navigate to the team repo to find the code when it should have been straightforward to click on the link and see the code.

Screenshots

Bug

Since insurance packages are heavily used in the application, this dependency should be illustrated in the model class diagram. Giving severity medium as subsequent documentation reference InsurancePackagesSet but it is not known where this set is stored.

Screenshots

since packages are not listed at the start, the person may not know that the packages are invalid.

The sequence diagram does not follow the colour scheme used by other sequence diagrams

Bug

hard to tell which part of the sentence is command, and which are explanations.

Screenshots

Bug

Missing dependency to InsurancePackagesStorage. Since dependencies to AddressBookStorage and UserPrefsStorage are illustrated, dependencies to InsurancePackagesStorage should be illustrated as well. Giving High as the dependency on InsurancePackagesStorage is not documented anywhere else, but is visible in the code. New developer would not know that such dependency exist without reading the code.

Screenshots

Steps to reproduce

run add n/James s/o Ho p/22224444 e/[email protected] a/123,Clementi Rd, 1234665 i/package1 t/friend t/colleague

Expected

Person added successfully.

Actual

Person not added due to invalid name.

Screenshots

Names with special characters, e.g. -, /, @ are legal names, at least in Singapore context, and especially in the field of insurance agents, the full names are important when dealing with legal documents. Marking severity as medium as this will not allow the insurance agent to add the name of people with special characters.

Bugs

There are different formats of sequence diagram found in the DG. The inconsistency would affect reader as there are drastic difference between the two formats

Screenshots

Bug

User guide commands are of the same colour as normal text, sometimes the words blend in and it is hard to differentiate which is are text and which are commands.

This can be resolved if the team created the PDF with "background graphics" enabled.

Screenshot